From: Tassilo Horn <tsdh@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: help-gnu-emacs@gnu.org
Subject: Re: My read-buffer-function doesn't work when called by switch-to-buffer
Date: Wed, 15 Mar 2023 10:06:23 +0100 [thread overview]
Message-ID: <874jqms6s2.fsf@gnu.org> (raw)
In-Reply-To: <87sfe9bien.fsf@web.de>
Michael Heerdegen <michael_heerdegen@web.de> writes:
Hi Michael,
>> > Maybe an advice of a higher level function would better fit your
>> > wished-for behavior.
>>
>> Do you have one in mind?
>
> `read-buffer-to-switch'.
Hm, but then it would be pretty specific to `switch-to-buffer' instead
of a general `read-buffer-function'. E.g., I just found out it's quite
convienient to be able to use `append-to-buffer' to append to a buffer
whose file I haven't found already but is in recentf-list.
>> I haven't checked their implementation but completion-extra-properties
>> is nil and the metadata completion requests also don't return an
>> annotation-function or affixation-function. Nevertheless, all standard
>> completions are annotated. I'll have a look how marginalia does it.
>
> They do this:
>
> (advice-add #'completion-metadata-get
> :before-until #'marginalia--completion-metadata-get)
>
> Looks like this is how they install their annotation-function.
Yes, thanks for the pointer.
>> Anyway, I've played a bit with responding to metadata requests and it
>> looks like it's not really suited for my goal because it seems to
>> assume that the metadata won't change (e.g., category from buffer to
>> file) during a single completion which is obviously a reasonable
>> assumption.
>
> Hmm, yes, that's a problem. Seems a completion table can only provide
> one kind of metadata for all completions and what you want doesn't fit
> at all into that approach. See the comment in
> `completion-table-in-turn'.
Agreed.
Bye,
Tassilo
next prev parent reply other threads:[~2023-03-15 9:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 21:10 My read-buffer-function doesn't work when called by switch-to-buffer Tassilo Horn
2023-03-11 0:32 ` Michael Heerdegen
2023-03-11 8:58 ` Tassilo Horn
2023-03-11 20:40 ` `when-let' (was: Re: My read-buffer-function doesn't work when called by switch-to-buffer) Emanuel Berg
2023-03-12 3:32 ` My read-buffer-function doesn't work when called by switch-to-buffer Michael Heerdegen
2023-03-12 18:51 ` Tassilo Horn
2023-03-13 0:32 ` Michael Heerdegen
2023-03-15 9:06 ` Tassilo Horn [this message]
2023-03-15 18:57 ` Michael Heerdegen
2023-03-16 9:18 ` Tassilo Horn
2023-03-16 16:59 ` Tassilo Horn
2023-03-16 23:46 ` Michael Heerdegen
2023-03-17 7:04 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jqms6s2.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=help-gnu-emacs@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).