From: Alex Kost <alezost@gmail.com>
To: Perry Smith <pedzsan@gmail.com>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Help needed with defadvice
Date: Fri, 22 Nov 2013 11:09:32 +0400 [thread overview]
Message-ID: <8738mo7w0j.fsf@gmail.com> (raw)
In-Reply-To: <AF488794-2AB5-4F7D-8949-64A73614A2FF@gmail.com> (Perry Smith's message of "Thu, 21 Nov 2013 20:45:26 -0600")
Perry Smith (2013-11-22 06:45 +0400) wrote:
> I have this defadvice:
>
> (defadvice get-buffer-create (around inherit activate)
> (let ((set-list (mapcar '(lambda ( v )
> (cons v (symbol-value v)))
> inherited-alist)))
> (with-current-buffer ad-do-it
> (mapcar '(lambda ( c )
> (message "Setting %s to %s inside %s"
> (car c) (cdr c) (buffer-name (current-buffer)))
> (set (car c) (cdr c)))
> set-list))))
>
> inherited-alist is a list of symbols that I add to. When a buffer is created, I run through the list of variables and get their values as seen from the current buffer. I then call get-buffer-create (via ad-do-it) and do a set on each of the variables. The "message" is there just for debugging. I get the messages like I expect .... e.g. "Setting foo to dog inside cat.c" or whatever. All the symbols in inherited-alist are buffer-local variables.
1. With `set' you set a global value, you probably want
(set (make-local-variable (car c)) (cdr c)) instead of
(set (car c) (cdr c)).
2. Don't quote lambdas: <http://www.emacswiki.org/emacs/QuotedLambda>.
3. "alist" means "association list", so you shouldn't call
`inherited-alist' like this as it's a simple list. For info about
alists look at (info "(elisp) Association Lists").
4. I believe making an advice for `get-buffer-create' is not a good
idea. Don't you have a lot of messages about setting variables in
*temp* buffers? Thus you will set unintended variables for any new
buffer. Do you really need that?
next prev parent reply other threads:[~2013-11-22 7:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 2:45 Help needed with defadvice Perry Smith
2013-11-22 6:27 ` Eric Abrahamsen
2013-11-22 7:09 ` Alex Kost [this message]
2013-11-22 15:50 ` Perry Smith
2013-11-22 21:56 ` Alex Kost
2013-11-23 1:41 ` Perry Smith
2013-11-23 7:00 ` Alex Kost
2013-11-23 14:48 ` Stefan Monnier
2013-11-23 15:22 ` Perry Smith
2013-11-23 15:38 ` Stefan Monnier
2013-11-23 16:24 ` Perry Smith
2013-11-24 18:21 ` Stefan Monnier
2013-11-23 15:43 ` Alex Kost
[not found] ` <mailman.6834.1385135422.10748.help-gnu-emacs@gnu.org>
2013-11-23 8:35 ` jack-mac
2013-11-22 14:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738mo7w0j.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=pedzsan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).