Adapting code to cl-lib

Adapting code to cl-lib

[João Távora]

Does anyone know of a package or something that gets rid of these
warnings:

   foo.el:2266:57:Warning: function `find' from cl package called at runtime
   foo.el:2370:63:Warning: function `remove*' from cl package called at runtime
   foo.el:2370:63:Warning: function `gensym' from cl package called at runtime

by replacing them with their cl- counterpairs from cl-lib?

João
   

Re: Adapting code to cl-lib

[Thierry Volpiatto]

joaotavora@gmail.com (João Távora) writes:

> Does anyone know of a package or something that gets rid of these
> warnings:
>
>    foo.el:2266:57:Warning: function `find' from cl package called at runtime
>    foo.el:2370:63:Warning: function `remove*' from cl package called at runtime
>    foo.el:2370:63:Warning: function `gensym' from cl package called at runtime
>
> by replacing them with their cl- counterpairs from cl-lib?

Yes, or adding this at end of file if you want to keep using 'cl' package:

,----
| ;; Local Variables:
| ;; byte-compile-warnings: (not cl-functions obsolete)
| ;; End:
`----

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Re: Adapting code to cl-lib

[João Távora]

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

> joaotavora@gmail.com (João Távora) writes:
>
>> Does anyone know of a package or something that gets rid of these
>> warnings:
>>
>>    foo.el:2266:57:Warning: function `find' from cl package called at runtime
>>    foo.el:2370:63:Warning: function `remove*' from cl package called at runtime
>>    foo.el:2370:63:Warning: function `gensym' from cl package called at runtime
>>
>> by replacing them with their cl- counterpairs from cl-lib?
>
> Yes

Then can you tell me what it is?

>, or adding this at end of file if you want to keep using 'cl' package:
>
> ,----
> | ;; Local Variables:
> | ;; byte-compile-warnings: (not cl-functions obsolete)
> | ;; End:
> `----

Yes, thanks, I already knew I could do this, but it's precisely what I
wanted to avoid.

In case there was a misunderstanding. I was looking for some
command/package that replaces these in the buffer. I could roll my own,
searching for symbols with some 'obsolete property or sth that also have
cl- counterparts bound to some function, and then passing these to a
global replace-regexp...

Re: Adapting code to cl-lib

[Thierry Volpiatto]

joaotavora@gmail.com (João Távora) writes:

> In case there was a misunderstanding. I was looking for some
> command/package that replaces these in the buffer. I could roll my own,
> searching for symbols with some 'obsolete property or sth that also have
> cl- counterparts bound to some function, and then passing these to a
> global replace-regexp...

So no I don't know any package doing this, I have converted code
recently to cl-lib using my own code similar to your code.
You can find a list of symbols to replace in cl.el#176.


-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Re: Adapting code to cl-lib

[João Távora]

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

> You can find a list of symbols to replace in cl.el#176.

Thanks, I took that list and wrote a replace-regexp expression. But just
a regexp won't cut since it will think

   (let ((position 5))
      ...)

is a call to cl-position, which is quite wrong. I ended up fixing these
by hand. A real tool must use the byte-compiler's output, or hop on the
byte-compiler itself. Probably not worth it...

João

Re: Adapting code to cl-lib

[Thierry Volpiatto]

joaotavora@gmail.com (João Távora) writes:

> Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
>
>> You can find a list of symbols to replace in cl.el#176.
>
> Thanks, I took that list and wrote a replace-regexp expression. But just
> a regexp won't cut since it will think
>
>    (let ((position 5))
>       ...)
>
> is a call to cl-position, which is quite wrong. I ended up fixing these
> by hand.

Yes, I had same problem, and finished fixing these occurences by hand
like you, looking at the byte-compiler output.

> A real tool must use the byte-compiler's output, or hop on the
> byte-compiler itself. Probably not worth it...

Yes, I didn't improve my tool because it is something I used once,
and I probably will not use it anymore.
Fixing small elisp packages (one file) don't require such a tool.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Re: Adapting code to cl-lib

[Thien-Thi Nguyen]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

() joaotavora@gmail.com (João Távora)
() Mon, 30 Dec 2013 21:48:48 +0000

   A real tool must use the byte-compiler's output, or hop on the
   byte-compiler itself. Probably not worth it...

It would be cool to capture byte-compiler warnings, anyway, for the sake
of downstream toolsmithing.  Maybe this is already possible?

[cc trimmed]

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]