Re: Bookmarks in EWW

[Michael Heerdegen <michael_heerdegen@web.de>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Oh, right `byte-hunk-handler` is to handle top-level uses only
> (e.g. top-level uses of `require` trigger loading the file at
> compilation time, whereas they don't when not at top-level).
>
> I think you want to use `(byte-defop-compiler-1 make-local-variable)`
> and then define `byte-compile-make-local-variable`.

And now I also understand why in

#+begin_src emacs-lisp
(defun byte-compile-make-variable-buffer-local (form)
  (if (and (eq (car-safe (car-safe (cdr-safe form))) 'quote)
           (byte-compile-warning-enabled-p 'make-local))
      (byte-compile-warn                                        ;; <--
       "`make-variable-buffer-local' not called at toplevel"))
  (byte-compile-normal-call form))
#+end_src

the warning seems to be raised unconditionally.  There is an additional
byte-hunk-handler for `make-variable-buffer-local', and first it seemed
redundant to me, but AFAIU it shadows the above byte-defop-compiler-1
function for top-level calls.

Michael.