Re: [Solved]

Re: [Solved]

[Memnon Anon]

Eli Zaretskii <eliz@gnu.org> writes:

> I urge you to reconsider.  Sending an email saying that the doc string
> of org-clock-in does not say what value to assign to the SELECT
> argument in a non-interactive call does not need any high level of
> expertise.  

Sending the mail does not need expertise. But recognizing if something
really is a deficiency does. Bug reports are great, but creating
"noise" is not; and I really don't want to be a nuisance to the experts
who provide me with so excellent tools. And even if I did recognize a
lack of precision - which requires some knowledge of best practice in
doc strings - I would want to send a patch, which requires even more
knowledge of doc strings in general (= not only seeing what is wrong but
also 'fixing' it).

One way is looking for other docstrings that seem to be "better".
In org, I found lots of functions that are usually called interactively
that have a doc string like the one before.
see eg:

,----[ org-remember.el ]
| (defun org-remember (&optional goto org-force-remember-template-char)
|   "Call `remember'.  If this is already a remember buffer, re-apply template.
| If there is an active region, make sure remember uses it as initial content
| of the remember buffer.
| 
| When called interactively with a \\[universal-argument] \
| prefix argument GOTO, don't remember
| anything, just go to the file/headline where the selected template usually
| stores its notes.  With a double prefix argument \
| \\[universal-argument] \\[universal-argument], go to the last
| note stored by remember.
| 
| Lisp programs can set ORG-FORCE-REMEMBER-TEMPLATE-CHAR to a character
| associated with a template in `org-remember-templates'."
|   (interactive "P")
|   (org-require-remember)
|   (cond
|    ((equal goto '(4)) (org-go-to-remember-target))
|    ((equal goto '(16)) (org-remember-goto-last-stored))
`----

I (so far) only found one docstring that seems "better" in this regard:

,----[ org-agenda.el ]
| (defun org-agenda-set-restriction-lock (&optional type)
|   "Set restriction lock for agenda, to current subtree or file.
| Restriction will be the file if TYPE is `file', or if type is the
* universal prefix '(4), or if the cursor is before the first headline
| ^^^^^^^^^^^^^^^^^^^^^^               
| in the file.  Otherwise, restriction will be to the current subtree."
`----

This one says explicitly '(4) is what is tested against.

So should I look for all interactive functions that check against a
universal argument with 

          (when (equal arg '(4)) ... 

and suggest the docstring, which usually only says something like: "When 
using \\[universal-argument], ..." to be modified like:
"When using \\[universal-argument] '(4)"? (Of course on a case to case
basis whenever it seems not clear so far.)

> If a doc string does not explain what are the valid values of the
> function's arguments, then that doc string needs to be improved.
> Documenting this is the absolute minimum of any doc string; without
> that, the doc string is useless.  It is sometimes okay to omit these
> details if the valid values are clear from the text and the context.
> But I cannot see how someone could claim that the value '(4) could be
> "clear".

Mhhh.
Please have a look at this docstring:

,----[ org-agenda.el ]
| (defun org-agenda-clock-out (&optional arg)
|   "Stop the currently running clock."
|   (interactive "P")
|   (unless (marker-buffer org-clock-marker)
|     (error "No running clock"))
|   (let ((marker (make-marker)) newhead)
|     (org-with-remote-undo (marker-buffer org-clock-marker)
|       (with-current-buffer (marker-buffer org-clock-marker)
| 	(save-excursion
| 	  (save-restriction
| 	    (widen)
| 	    (goto-char org-clock-marker)
| 	    (org-back-to-heading t)
| 	    (move-marker marker (point))
| 	    (org-clock-out)
| 	    (setq newhead (org-get-heading))))))
|     (org-agenda-change-all-lines newhead marker)
|     (move-marker marker nil)))
`----

This function takes an (optioal) arg, but it is in now way explain what
this arg does.

To tell the truth, in contrast to `org-agenda-clock-in', I do not even
see where this arg is used anywhere in the function...

Should I really file bug reports when I obviously do not understand
whats going on? I don't think so.

Plus: All these points are not really important, because these functions
are meant to be used interactively, what they usually are ...  except
when someone wants to bind them to a key with a lambda like in the case
of C-u C-c C-x C-i (org-clock-in) before.


Memnon

P.S.: Cool, I saw you really use the convention to start a new sentence
      with <SPC> <SPC>. I never saw anyone really that :)

Re: [Solved]

[Eli Zaretskii]

> From: Memnon Anon <gegendosenfleisch@googlemail.com>
> Cc: help-gnu-emacs@gnu.org
> Date: Sat, 14 Aug 2010 23:18:21 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I urge you to reconsider.  Sending an email saying that the doc string
> > of org-clock-in does not say what value to assign to the SELECT
> > argument in a non-interactive call does not need any high level of
> > expertise.  
> 
> Sending the mail does not need expertise. But recognizing if something
> really is a deficiency does. Bug reports are great, but creating
> "noise" is not; and I really don't want to be a nuisance to the experts
> who provide me with so excellent tools. And even if I did recognize a
> lack of precision - which requires some knowledge of best practice in
> doc strings - I would want to send a patch, which requires even more
> knowledge of doc strings in general (= not only seeing what is wrong but
> also 'fixing' it).

Sending a patch is fine.  But if you cannot send a patch, at least
make a bug report.  Doing nothing after you spotted a problem is IMO
worse than sending a bug report out of mistake or misunderstanding.

> One way is looking for other docstrings that seem to be "better".
> In org, I found lots of functions that are usually called interactively
> that have a doc string like the one before.

Even more reason to submit a report: it sounds like many doc strings
there need the same treatment.

> Should I really file bug reports when I obviously do not understand
> whats going on?

Yes.  An unclear doc string needs improvement.

Re: [SOLVED]

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

>>> "EBvUlftGEte" == Emanuel Berg via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org> writes:

> Uwe Brauer wrote:
>> Actually it was quite easy as in 
>> 
>> (defun randomise-region ()
>> "Like `ap/replace-words-randomly', but only replace inside region if it is active.
>> If the region is not active, replace from point to the end of the
>> buffer.  The region is never considered active outside
>> `transient-mark-mode'. "
>> (interactive)
>> (if (or (and (boundp 'zmacs-region-active-p) zmacs-region-active-p)
>> (and (boundp 'transient-mark-mode) transient-mark-mode mark-active))
>> (save-restriction
>> (save-excursion
>> (narrow-to-region (point) (mark))
>> (goto-char (point-min))
>> (ap/replace-words-randomly)))
>> (ap/replace-words-randomly)))

> ;;; -*- lexical-binding: t -*-
> ;;;
> ;;; this file:
> ;;;   http://user.it.uu.se/~embe8573/emacs-init/sort-incal.el
> ;;;   https://dataswamp.org/~incal/emacs-init/sort-incal.el

> (require 'edit)
> (require 'erc)
> (require 'sort)

Thanks but the file edit, is missing at least not included in my emacs

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Emanuel Berg via Users list for the GNU Emacs text editor]

Uwe Brauer wrote:

> Thanks but the file edit, is missing at least not included
> in my emacs

You are right, "must" fix the names, try these and only these:

(defun region-to-string ()
  "Return the region text as a string. Replace newlines with spaces."
  (when (use-region-p)
    (let ((beg (region-beginning))
          (end (region-end) ))
    (let ((text (buffer-substring-no-properties beg end)))
      (replace-regexp-in-string "\n" " " text) ))))

(defun scramble (beg end)
  "Shuffle chars in region from BEG to END."
  (interactive "r")
  (when (use-region-p)
    (save-excursion
      (let*((str        (region-to-string))
            (chars      (delete "" (split-string str "")))
            (rand-chars (sort chars (lambda (_ __) (zerop (random 2))))) )
        (delete-region beg end)
        (dolist (c rand-chars)
          (insert c) )))))

(require 'seq)
(defun scramble-string (str)
  "Randomize the characters of a string."
  (interactive "sscramble me: ")
  (let ((rand-str (seq-sort (lambda (_ __) (zerop (random 2))) str )))
    (if (called-interactively-p 'any)
        (message rand-str)
      rand-str) ))

(defun comic-book-insult ()
  (interactive)
  (insert (concat (scramble-string "@#$%&") "!")) )

;; (comic-book-insult) ; @#$%&!
;; (comic-book-insult) ; $&#@%!

;; (scramble-string "Hello there, Emacs is very cool piece of software")
;; "aye eposrr lvre olsec,ewfico ceti ftomH hseoa l E"

-- 
underground experts united
https://dataswamp.org/~incal

Re: [SOLVED]

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

>>> "EBvUlftGEte" == Emanuel Berg via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org> writes:

> Uwe Brauer wrote:
>> Thanks but the file edit, is missing at least not included
>> in my emacs

> You are right, "must" fix the names, try these and only these:

Thanks that works nicely, it is a bit different from the package I use
because mine replaces words by some randomly picked words of the same
size yours randomise also the words. Both approaches work, yours is
independent from any external tool, tough.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Emanuel Berg via Users list for the GNU Emacs text editor]

Uwe Brauer wrote:

>>>> "EBvUlftGEte" == Emanuel Berg via Users list for the GNU
>>> Emacs text editor <help-gnu-emacs@gnu.org> writes:
>
>> Uwe Brauer wrote:
>>> Thanks but the file edit, is missing at least not included
>>> in my emacs
>
>> You are right, "must" fix the names, try these and only these:
>
> Thanks that works nicely, it is a bit different from the package I use
> because mine replaces words by some randomly picked words of the same
> size yours randomise also the words. Both approaches work, yours is
> independent from any external tool, tough.

You mean zmacs-region-active-p and/or
ap/replace-words-randomly ?

Yeah, I don't have either ...

-- 
underground experts united
https://dataswamp.org/~incal

problems with better-registers: turn-off-all-minor modes or remove all text-properties

[Uwe Brauer]

Hi

better-registers found in https://github.com/emacsmirror/emacswiki.org/blob/master/better-registers.el
is unfortunately no longer maintained. It allows, among other things, to
save registers in a file for future sessions.

While there is no problem in saving some text of a buffer in fundamental
mode to a specific resister.

However for example message mode, that has in my case quite a bit of
minor modes turn on, results in a saving of the sort.

,----
| 
| (set-register 49 #("
| Test again
| and again 
| -- 
| I strongly condemn Putin's war of aggression against the Ukraine. I
| support to deliver weapons to Ukraine's military. I support the ban of
| Russia from SWIFT. I support the EU membership of the Ukraine. " 0 1
| (fontified t) 1 11 (fontified t) 11 22 (fontified t) 22 23 (fontified t)
| 23 25 (fontified t rear-nonsticky t field signature pabbrev-added t) 25
| 26 (fontified t rear-nonsticky t field signature) 26 27 (fontified t) 27
| 28 (fontified t pabbrev-added t) 28 29 (fontified t) 29 37 (fontified t
| pabbrev-added t) 37 38 (fontified t) 38 45 (fontified t pabbrev-added t)
| 45 46 (fontified t) 46 53 (fontified t pabbrev-added t) 53 54 (fontified
| t) 54 57 (fontified t pabbrev-added t) 57 58 (fontified t) 58 60
| (fontified t pabbrev-added t) 60 61 (fontified t) 61 71 (fontified t
| pabbrev-added t) 71 72 (fontified t) 72 79 (fontified t pabbrev-added t)
| 79 80 (fontified t) 80 83 (fontified t pabbrev-added t) 83 84 (fontified
| t) 84 91 (fontified t pabbrev-added t) 91 93 (fontified t) 93 94
| (fontified t pabbrev-added t) 94 95 (fontified t) 95 102 (fontified t
| pabbrev-added t) 102 103 (fontified t) 103 105 (fontified t
| pabbrev-added t) 105 106 (fontified t) 106 113 (fontified t
| pabbrev-added t) 113 114 (fontified t) 114 121 (fontified t
| pabbrev-added t) 121 122 (fontified t) 122 124 (fontified t
| pabbrev-added t) 124 125 (fontified t) 125 134 (fontified t
| pabbrev-added t) 134 135 (fontified t) 135 143 (fontified t
| pabbrev-added t) 143 146 (fontified t) 146 147 (fontified t
| pabbrev-added t) 147 148 (fontified t) 148 155 (fontified t
| pabbrev-added t) 155 156 (fontified t) 156 159 (fontified t
| pabbrev-added t) 159 160 (fontified t) 160 163 (fontified t
| pabbrev-added t) 163 164 (fontified t) 164 166 (fontified t
| pabbrev-added t) 166 167 (fontified t) 167 173 (fontified t
| pabbrev-added t) 173 174 (fontified t) 174 178 (fontified t
| pabbrev-added t) 178 179 (fontified t) 179 184 (fontified t
| pabbrev-added t) 184 186 (fontified t) 186 187 (fontified t
| pabbrev-added t) 187 188 (fontified t) 188 195 (fontified t
| pabbrev-added t) 195 196 (fontified t) 196 199 (fontified t
| pabbrev-added t) 199 200 (fontified t) 200 202 (fontified t
| pabbrev-added t) 202 203 (fontified t) 203 213 (fontified t
| pabbrev-added t) 213 214 (fontified t) 214 216 (fontified t
| pabbrev-added t) 216 217 (fontified t) 217 220 (fontified t
| pabbrev-added t) 220 221 (fontified t) 221 228 (fontified t
| pabbrev-added t) 228 231 (fontified t)))
`----



Which in turn causes problems when loading a file with such saved resisters.

Two workaround occured to me, but both did not work

    1. Turn off all minor mode (which might be the culprit of all the
       face stuff that is added) by using 
       (defun disable-all-minor-modes ()
         (interactive)
           (mapc
              (lambda (mode-symbol)
                   (when (functionp mode-symbol)
       ;; some symbols are functions which aren't normal mode functions
              (ignore-errors 
                (funcall mode-symbol -1))))
                   minor-mode-list))
       Found in
       https://emacs.stackexchange.com/questions/42239/how-to-disable-all-the-minor-modes-when-a-specific-major-mode-is-enabled-with

    2. Or delete all the text-properties, by something like this
       (let ((inhibit-read-only t))
  (set-text-properties (point-min) (point-max) nil))

It did not work neither.

Any idea?

Thanks and regards

Uwe Brauer 



-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

Re: problems with better-registers: turn-off-all-minor modes or remove all text-properties

[Thorsten Bonow]

>>>>> Uwe Brauer <oub@mat.ucm.es> writes: 
 
> Hi 
 
> better-registers found in 
> https://github.com/emacsmirror/emacswiki.org/blob/master/better-registers.el 
> is unfortunately no longer maintained. It allows, among other 
> things, to save registers in a file for future sessions. 
 
> While there is no problem in saving some text of a buffer in 
> fundamental mode to a specific resister. 
 
> However for example message mode, that has in my case quite a 
> bit of minor modes turn on, results in a saving of the sort. 
 
> ,---- | | (set-register 49 #(" | Test again | and again | -- | I 
> strongly condemn Putin's war of aggression against the 
> Ukraine. I | support to deliver weapons to Ukraine's military. I 
> support the ban of | Russia from SWIFT. I support the EU 
> membership of the Ukraine. " 0 1 | (fontified t) 1 11 (fontified 
> t) 11 22 (fontified t) 22 23 (fontified t) | 23 25 (fontified t 
> rear-nonsticky t field signature pabbrev-added t) 25 | 26 
> (fontified t rear-nonsticky t field signature) 26 27 (fontified 
> t) 27 | 28 (fontified t pabbrev-added t) 28 29 (fontified t) 29 
> 37 (fontified t | pabbrev-added t) 37 38 (fontified t) 38 45 
> (fontified t pabbrev-added t) | 45 46 (fontified t) 46 53 
> (fontified t pabbrev-added t) 53 54 (fontified | t) 54 57 
> (fontified t pabbrev-added t) 57 58 (fontified t) 58 60 | 
> (fontified t pabbrev-added t) 60 61 (fontified t) 61 71 
> (fontified t | pabbrev-added t) 71 72 (fontified t) 72 79 
> (fontified t pabbrev-added t) | 79 80 (fontified t) 80 83 
> (fontified t pabbrev-added t) 83 84 (fontified | t) 84 91 
> (fontified t pabbrev-added t) 91 93 (fontified t) 93 94 | 
> (fontified t pabbrev-added t) 94 95 (fontified t) 95 102 
> (fontified t | pabbrev-added t) 102 103 (fontified t) 103 105 
> (fontified t | pabbrev-added t) 105 106 (fontified t) 106 113 
> (fontified t | pabbrev-added t) 113 114 (fontified t) 114 121 
> (fontified t | pabbrev-added t) 121 122 (fontified t) 122 124 
> (fontified t | pabbrev-added t) 124 125 (fontified t) 125 134 
> (fontified t | pabbrev-added t) 134 135 (fontified t) 135 143 
> (fontified t | pabbrev-added t) 143 146 (fontified t) 146 147 
> (fontified t | pabbrev-added t) 147 148 (fontified t) 148 155 
> (fontified t | pabbrev-added t) 155 156 (fontified t) 156 159 
> (fontified t | pabbrev-added t) 159 160 (fontified t) 160 163 
> (fontified t | pabbrev-added t) 163 164 (fontified t) 164 166 
> (fontified t | pabbrev-added t) 166 167 (fontified t) 167 173 
> (fontified t | pabbrev-added t) 173 174 (fontified t) 174 178 
> (fontified t | pabbrev-added t) 178 179 (fontified t) 179 184 
> (fontified t | pabbrev-added t) 184 186 (fontified t) 186 187 
> (fontified t | pabbrev-added t) 187 188 (fontified t) 188 195 
> (fontified t | pabbrev-added t) 195 196 (fontified t) 196 199 
> (fontified t | pabbrev-added t) 199 200 (fontified t) 200 202 
> (fontified t | pabbrev-added t) 202 203 (fontified t) 203 213 
> (fontified t | pabbrev-added t) 213 214 (fontified t) 214 216 
> (fontified t | pabbrev-added t) 216 217 (fontified t) 217 220 
> (fontified t | pabbrev-added t) 220 221 (fontified t) 221 228 
> (fontified t | pabbrev-added t) 228 231 (fontified t))) `---- 
 
 
 
> Which in turn causes problems when loading a file with such 
> saved resisters. 

Hi,

could you please be more specific about the problems?

I ran a few quick tests with savehist mode; worked for me:

(savehist-mode 1)
(setq savehist-additional-variables '(register-alist))

This saves minibuffer history and `register-alist' in 
`savehist-file' (defaults to "~/.emacs.d/history").

Toto


 
> Two workaround occured to me, but both did not work 
 
> 1. Turn off all minor mode (which might be the culprit of all 
> the face stuff that is added) by using (defun 
> disable-all-minor-modes () (interactive) (mapc (lambda 
> (mode-symbol) (when (functionp mode-symbol) ;; some symbols are 
> functions which aren't normal mode functions (ignore-errors 
> (funcall mode-symbol -1)))) minor-mode-list)) Found in 
> https://emacs.stackexchange.com/questions/42239/how-to-disable-all-the-minor-modes-when-a-specific-major-mode-is-enabled-with 
 
> 2. Or delete all the text-properties, by something like this 
> (let ((inhibit-read-only t)) (set-text-properties (point-min) 
> (point-max) nil)) 
 
> It did not work neither. 
 
> Any idea? 
 
> Thanks and regards 
 
> Uwe Brauer 
 
 
-- 
Sent from my GNU Emacs running on GNU/Linux

Re: problems with better-registers: turn-off-all-minor modes or remove all text-properties

[Michael Heerdegen]

Uwe Brauer <oub@mat.ucm.es> writes:

> Which in turn causes problems when loading a file with such saved
> resisters.

Could you please be more specific - what's the problem?  As Stefan said,
text properties are normally not a problem in this case.

Michael.

Re: problems with better-registers: turn-off-all-minor modes or remove all text-properties

[Michael Heerdegen]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Could you please be more specific - what's the problem?  As Stefan said,
> text properties are normally not a problem in this case.

Ok, after reading again what you had posted in emacs-dev, I saw your
string contained unreadable properties.  Your string contained a button,
for example.

What I would do is to advice `set-register' to strip unreadable
properties from any stringp value.  Or just strip text properties if you
don't want them anyway.  That's better than trying to work around that
problem.

Michael.

Re: problems with better-registers: turn-off-all-minor modes or remove all text-properties

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]

>>> "MH" == Michael Heerdegen <michael_heerdegen@web.de> writes:

> Michael Heerdegen <michael_heerdegen@web.de> writes:
>> Could you please be more specific - what's the problem?  As Stefan said,
>> text properties are normally not a problem in this case.

> Ok, after reading again what you had posted in emacs-dev, I saw your
> string contained unreadable properties.  Your string contained a button,
> for example.

> What I would do is to advice `set-register' to strip unreadable
> properties from any stringp value.  Or just strip text properties if you
> don't want them anyway.  That's better than trying to work around that
> problem.

Thanks, that did not occur to me. I tried to advice since a while since
it makes debugging difficult.

In any case, maybe because I have not used it for a while, my attempts
failed:

(defadvice set-property (before removeproperties activate)
  "Remove all text properties before setting the property"
  (let ((inhibit-read-only t))
    (set-text-properties (point-min) (point-max) nil)))


(defadvice set-property (after removeproperties activate)
  "Remove all text properties before setting the property"
  (let ((inhibit-read-only t))
    (set-text-properties (point-min) (point-max) nil)))

None of them worked

Any ideas?
thanks

Uwe Brauer 





-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

[SOLVED] (was: problems with better-registers: turn-off-all-minor modes or remove all text-properties)

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]





> Thanks, that did not occur to me. I tried to advice since a while since
> it makes debugging difficult.

> In any case, maybe because I have not used it for a while, my attempts
> failed:

> (defadvice set-property (before removeproperties activate)
>   "Remove all text properties before setting the property"
>   (let ((inhibit-read-only t))
>     (set-text-properties (point-min) (point-max) nil)))


> (defadvice set-property (after removeproperties activate)
>   "Remove all text properties before setting the property"
>   (let ((inhibit-read-only t))
>     (set-text-properties (point-min) (point-max) nil)))

> None of them worked

The magic seems to be

(defadvice copy-to-register (before removeproperties activate)
  "Remove all text properties before setting the property"
  (let ((inhibit-read-only t))
    (set-text-properties (point-min) (point-max) nil)))

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Michael Heerdegen]

Uwe Brauer <oub@mat.ucm.es> writes:

> Thanks, that did not occur to me. I tried to advice since a while
> since it makes debugging difficult.

Not much, IME.

> (defadvice copy-to-register (before removeproperties activate)
>   "Remove all text properties before setting the property"
>   (let ((inhibit-read-only t))
>     (set-text-properties (point-min) (point-max) nil)))

It would be better and cleaner to change the value that is saved in the
register instead of modifying the buffer.

Michael.

Re: [SOLVED]

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

>>> "MH" == Michael Heerdegen <michael_heerdegen@web.de> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> Thanks, that did not occur to me. I tried to advice since a while
>> since it makes debugging difficult.

> Not much, IME.

>> (defadvice copy-to-register (before removeproperties activate)
>> "Remove all text properties before setting the property"
>> (let ((inhibit-read-only t))
>> (set-text-properties (point-min) (point-max) nil)))

> It would be better and cleaner to change the value that is saved in the
> register instead of modifying the buffer.

Well I tried that, but I couldn't. As I said modify set-register did not
work for me.

I am not happy about my solution and would appreciate any suggestion.

Uwe 




-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

>>> "UB" == Uwe Brauer <oub@mat.ucm.es> writes:

>>> "MH" == Michael Heerdegen <michael_heerdegen@web.de> writes:
>> Uwe Brauer <oub@mat.ucm.es> writes:
>>> Thanks, that did not occur to me. I tried to advice since a while
>>> since it makes debugging difficult.

>> Not much, IME.

>>> (defadvice copy-to-register (before removeproperties activate)
>>> "Remove all text properties before setting the property"
>>> (let ((inhibit-read-only t))
>>> (set-text-properties (point-min) (point-max) nil)))

>> It would be better and cleaner to change the value that is saved in the
>> register instead of modifying the buffer.

I just realized that I did not read your message carefully enough.

It seems you suggest 

(defadvice copy-to-register (before removeproperties activate)
  "Remove all text properties before setting the property"
  (let ((inhibit-read-only t))
    (set-text-properties (region-beginning) (region-end) nil)))

Which is what I intended but copied the code incorrectly.

-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Stefan Monnier via Users list for the GNU Emacs text editor]

> It seems you suggest 
>
> (defadvice copy-to-register (before removeproperties activate)
>   "Remove all text properties before setting the property"
>   (let ((inhibit-read-only t))
>     (set-text-properties (region-beginning) (region-end) nil)))

No, that still modifies the buffer.  He suggests you apply
`set-text-properties` to the extracted string.


        Stefan

Re: [SOLVED]

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

>>> "SMvUlftGEte" == Stefan Monnier via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org> writes:

>> It seems you suggest 
>> 
>> (defadvice copy-to-register (before removeproperties activate)
>> "Remove all text properties before setting the property"
>> (let ((inhibit-read-only t))
>> (set-text-properties (region-beginning) (region-end) nil)))

> No, that still modifies the buffer.  He suggests you apply
> `set-text-properties` to the extracted string.


Well I tried 

(defadvice set-property (before removeproperties activate)
  "Remove all text properties before setting the property"
  (let ((inhibit-read-only t))
(set-text-properties (region-beginning) (region-end) nil)))

But it did not work

Uwe 




-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Michael Heerdegen]

Uwe Brauer <oub@mat.ucm.es> writes:

> Well I tried 
>
> (defadvice set-property (before removeproperties activate)
>   "Remove all text properties before setting the property"
>   (let ((inhibit-read-only t))
> (set-text-properties (region-beginning) (region-end) nil)))
>
> But it did not work

Wouldn't it be appropriate to refresh your knowledge about advices?

Michael.

Re: [SOLVED]

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 3123 bytes --]

>>> "MH" == Michael Heerdegen <michael_heerdegen@web.de> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> Well I tried 
>> 
>> (defadvice set-property (before removeproperties activate)
>> "Remove all text properties before setting the property"
>> (let ((inhibit-read-only t))
>> (set-text-properties (region-beginning) (region-end) nil)))
>> 
>> But it did not work

> Wouldn't it be appropriate to refresh your knowledge about advices?

Well I tried this as well, and tried out the new advice-add
functionality.

Here is what I tried 


(defun my-remove-all-text-properties-region ()
  (interactive) ;; that is not important
  (let ((inhibit-read-only t))
    (set-text-properties (region-beginning) (region-end) nil)))

Then 

(advice-add 'set-property :before #'my-remove-all-text-properties-region)

or 

(advice-add 'set-property :around #'my-remove-all-text-properties-region)

Result: no effect


I tried 

(advice-add 'copy-to-register :before  #'my-remove-all-text-properties-region)
or 
(advice-add 'copy-to-register :around  #'my-remove-all-text-properties-region)

Results in an  error:

,----
| Debugger entered--Lisp error: (wrong-number-of-arguments
|   #f(compiled-function () (interactive nil) #<bytecode
|   0x1f6825029d2a6658>) 1)
|   my-remove-all-text-properties-region(#f(compiled-function (register
|   start end &optional delete-flag region) "Copy region into register
|   REGISTER.\nWith prefix arg, delete as well.\nCalled from program,
|   takes five args: REGISTER, START, END, DELETE-FLAG,\nand REGION. START
|   and END are buffer positions indicating what to copy.\nThe optional
|   argument REGION if non-nil, indicates that we're not just\ncopying
|   some text between START and END, but we're copying the
|   region.\n\nInteractively, reads the register using
|   `register-read-with-preview'." (interactive #f(compiled-function ()
|   #<bytecode -0x19b31a6142e6ce87>)) #<bytecode 0x18af6be063d3e91b>))
|   apply(my-remove-all-text-properties-region #f(compiled-function
|   (register start end &optional delete-flag region) "Copy region into
|   register REGISTER.\nWith prefix arg, delete as well.\nCalled from
|   program, takes five args: REGISTER, START, END, DELETE-FLAG,\nand
|   REGION. START and END are buffer positions indicating what to
|   copy.\nThe optional argument REGION if non-nil, indicates that we're
|   not just\ncopying some text between START and END, but we're copying
|   the region.\n\nInteractively, reads the register using
|   `register-read-with-preview'." (interactive #f(compiled-function ()
|   #<bytecode -0x19b31a6142e6ce87>)) #<bytecode 0x18af6be063d3e91b>) nil)
|   copy-to-register() funcall-interactively(copy-to-register)
|   call-interactively(copy-to-register nil nil)
|   command-execute(copy-to-register)
`----

At this point I give up

Uwe 




-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Thorsten Bonow]

>>>>> Uwe Brauer <oub@mat.ucm.es> writes: 
 
[...] 
 
> At this point I give up 
 
> Uwe 

Don't loose heart...

(defun copy-to-register--no-properties (orig-fun &rest args) 
  "Remove properties of region when calling `copy-to-register'." 
  (let ((filter-buffer-substring-function (lambda (beg end 
  &optional delete) 
					    (if delete 
						(delete-and-extract-region 
						beg end) 
						(buffer-substring-no-properties 
						beg end))))) 
    (apply orig-fun args))) 
(advice-add 'copy-to-register :around 
#'copy-to-register--no-properties) 

Works for me, but the way I understand the manual, instead of 
advising a function, better-registers.el should just modify 
`filter-buffer-substring-function' for its needs.

Hope this helps.

Toto 

-- 
Sent from my GNU Emacs running on GNU/Linux

Re: [SOLVED]

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

>>> "TB" == Thorsten Bonow <thorsten.bonow@post.rwth-aachen.de> writes:

Hello Thorsten
>>>>>> Uwe Brauer <oub@mat.ucm.es> writes: 
> [...]  > At this point I give up  > Uwe Don't loose heart...

Ok I will not (and it seems I can count on «with a little help of my
friends 😉)

> (defun copy-to-register--no-properties (orig-fun &rest args)   "Remove
> properties of region when calling `copy-to-register'."   (let
> ((filter-buffer-substring-function (lambda (beg end   &optional
> delete) 					    (if delete
> (delete-and-extract-region
> beg end)
> (buffer-substring-no-properties
> beg end)))))     (apply orig-fun args))) (advice-add 'copy-to-register
> :around #'copy-to-register--no-properties) Works for me, but the way I
> understand the manual, instead of advising a function,
> better-registers.el should just modify
> `filter-buffer-substring-function' for its needs.



> Hope this helps.



It does very much so, that solution would not have occurred to me. So thanks for 
the code.


BTW, I found it strange that «vanilla» Emacs does not provide saving
registers, but then this is a question of demand, and it seems only a
few users use that functionality.

Uwe 




-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Yuri Khan]

On Tue, 26 Jul 2022 at 22:08, Uwe Brauer <oub@mat.ucm.es> wrote:

> BTW, I found it strange that «vanilla» Emacs does not provide saving
> registers, but then this is a question of demand, and it seems only a
> few users use that functionality.

I don’t remember who said it doesn’t but do we consider desktop.el
“vanilla” or some other flavor? My .emacs.desktop has a ‘(setq
register-alist '…)’ and it persists across Emacs sessions. (I have not
encountered unreadable properties in there, or maybe I did but did not
make the connection.)

Re: [SOLVED]

[Michael Heerdegen]

Yuri Khan <yuri.v.khan@gmail.com> writes:

> I don’t remember who said it doesn’t but do we consider desktop.el
> “vanilla” or some other flavor? My .emacs.desktop has a ‘(setq
> register-alist '…)’ and it persists across Emacs sessions. (I have not
> encountered unreadable properties in there, or maybe I did but did not
> make the connection.)

Seems it is silently stripping (all) properties when such a problem
appears - see `desktop--v2s'.

Michael.

Re: [SOLVED]

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

>>> "YK" == Yuri Khan <yuri.v.khan@gmail.com> writes:

> On Tue, 26 Jul 2022 at 22:08, Uwe Brauer <oub@mat.ucm.es> wrote:
>> BTW, I found it strange that «vanilla» Emacs does not provide saving
>> registers, but then this is a question of demand, and it seems only a
>> few users use that functionality.

> I don’t remember who said it doesn’t but do we consider desktop.el
> “vanilla” or some other flavor? 

Since desktop is part of Emacs it is vanilla.

> My .emacs.desktop has a ‘(setq
> register-alist '…)’ and it persists across Emacs sessions. (I have not
> encountered unreadable properties in there, or maybe I did but did not
> make the connection.)

Aha, thanks I did not know that, I really never used desktop that much, 
but can you use list-register and then edit the registers?
Ok I realized that list-register is not part of emacs vanilla neither.



-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Yuri Khan]

On Wed, 27 Jul 2022 at 17:51, Uwe Brauer <oub@mat.ucm.es> wrote:

> Since desktop is part of Emacs it is vanilla.

[…]

> Aha, thanks I did not know that, I really never used desktop that much,
> but can you use list-register and then edit the registers?
> Ok I realized that list-register is not part of emacs vanilla neither.

Is it not? Works for me and I do not remember doing anything for it to
work, and it lives in /usr/share/emacs/29.0.50/lisp/register.el.gz, so
I guess it’s also vanilla by your definition.

I cannot edit registers directly, but I can insert the text from a
register into a buffer, edit the text there, and copy it back to the
register, and it will be persisted the next time I restart Emacs.

Re: [SOLVED$

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

>>> "YK" == Yuri Khan <yuri.v.khan@gmail.com> writes:

> On Wed, 27 Jul 2022 at 17:51, Uwe Brauer <oub@mat.ucm.es> wrote:
>> Since desktop is part of Emacs it is vanilla.

> […$

>> Aha, thanks I did not know that, I really never used desktop that much,
>> but can you use list-register and then edit the registers?
>> Ok I realized that list-register is not part of emacs vanilla neither.

> Is it not? Works for me and I do not remember doing anything for it to
> work, and it lives in /usr/share/emacs/29.0.50/lisp/register.el.gz, so
> I guess it’s also vanilla by your definition.

> I cannot edit registers directly, but I can insert the text from a
> register into a buffer, edit the text there, and copy it back to the
> register, and it will be persisted the next time I restart Emacs.

May I suggest then list-register (found in the package system):
it lists registers and allows to edit them,

There is also register-list 
(remember Monty Python: 
«The People's Front of Judea»  vs «Judean People's Front» )



-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: [SOLVED]

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

>>> "EB" == Emanuel Berg <incal@dataswamp.org> writes:

> Uwe Brauer wrote:
>> a simple describe-variable suggests to use 
>> 
>> (defun my-changelog-date-format (&optional time zone)
>> (format-time-string "%Y-%m-%d %H:%M"))
>> 
>> Which indeed worked

> What time zone is that?

None, 

The code in add-log reads

(defun add-log-iso8601-time-zone (&optional time zone)
  (declare (obsolete nil "26.1"))
  (format-time-string "%:::z" time zone))

(defvar add-log-iso8601-with-time-zone nil)

(defun add-log-iso8601-time-string (&optional time zone)
  (format-time-string
   (if add-log-iso8601-with-time-zone "%Y-%m-%d %:::z" "%Y-%m-%d") time zone))

Since I don't think I will ever use time zones, I did not bother to set
this right up.

-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]