From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sebastien Vauban Newsgroups: gmane.emacs.help Subject: Re: Diff could also show the changes within lines Date: Thu, 20 Mar 2014 14:31:56 +0100 Organization: Sebastien Vauban Message-ID: <86r45x6lo3.fsf@somewhere.org> References: <86y51mx3x2.fsf@somewhere.org> <867g930xoz.fsf@somewhere.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1395322511 14811 80.91.229.3 (20 Mar 2014 13:35:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Mar 2014 13:35:11 +0000 (UTC) To: help-gnu-emacs-mXXj517/zsQ@public.gmane.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org-mXXj517/zsQ@public.gmane.org Thu Mar 20 14:35:20 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WQd7v-0005y2-DH for geh-help-gnu-emacs@m.gmane.org; Thu, 20 Mar 2014 14:35:19 +0100 Original-Received: from localhost ([::1]:47087 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQd7v-0006fT-2C for geh-help-gnu-emacs@m.gmane.org; Thu, 20 Mar 2014 09:35:19 -0400 Original-Path: usenet.stanford.edu!news.kjsl.com!feeder.erje.net!eu.feeder.erje.net!eternal-september.org!feeder.eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail Original-Newsgroups: gnu.emacs.help Original-Lines: 34 Injection-Info: mx05.eternal-september.org; posting-host="402b34550bd938aa98825778083dce0e"; logging-data="19654"; mail-complaints-to="abuse-VVbKFVtnif8H+i2N2EyTrmui9UKz+5OX@public.gmane.org"; posting-account="U2FsdGVkX19nQNNaUwPDdgGHkVk92SWr" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) X-Archive: encrypt Cancel-Lock: sha1:gQStOX8nxLNi80YdCRvVr/7lGyg= sha1:aa3WWyMiQj/g90q8XUHrFkVE4U4= X-Url: Under construction... Original-Xref: usenet.stanford.edu gnu.emacs.help:204371 X-BeenThere: help-gnu-emacs-mXXj517/zsQ@public.gmane.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org-mXXj517/zsQ@public.gmane.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org-mXXj517/zsQ@public.gmane.org Xref: news.gmane.org gmane.emacs.help:96643 Archived-At: Hello, Michael Heerdegen wrote: > My guess is that diff-mode-hook is not a good place to push your > function to. Maybe it is called too early, and the effect is somehow > reverted later. You may try something like > > (advice-add > 'vc-diff :after > (lambda (&rest _) > (my--diff-make-fine-diffs-if-necessary))) > > I wonder if that work's. That worked, as you already know. However, as the above code does not seem to run on slightly older Emacs versions, I tried to convert it to: --8<---------------cut here---------------start------------->8--- (defadvice vc-diff (after leuven-vc-diff activate) "Push the auto-refine function after `vc-diff'." (my--diff-make-fine-diffs-if-necessary))) --8<---------------cut here---------------end--------------->8--- ... which does not work. What am I missing? Best regards, Seb -- Sebastien Vauban