From: Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: help-gnu-emacs-mXXj517/zsQ@public.gmane.org
Subject: Re: Diff could also show the changes within lines
Date: Thu, 20 Mar 2014 14:31:56 +0100 [thread overview]
Message-ID: <86r45x6lo3.fsf@somewhere.org> (raw)
In-Reply-To: mailman.14857.1392204947.10748.help-gnu-emacs@gnu.org
Hello,
Michael Heerdegen wrote:
> My guess is that diff-mode-hook is not a good place to push your
> function to. Maybe it is called too early, and the effect is somehow
> reverted later. You may try something like
>
> (advice-add
> 'vc-diff :after
> (lambda (&rest _)
> (my--diff-make-fine-diffs-if-necessary)))
>
> I wonder if that work's.
That worked, as you already know.
However, as the above code does not seem to run on slightly older Emacs
versions, I tried to convert it to:
--8<---------------cut here---------------start------------->8---
(defadvice vc-diff (after leuven-vc-diff activate)
"Push the auto-refine function after `vc-diff'."
(my--diff-make-fine-diffs-if-necessary)))
--8<---------------cut here---------------end--------------->8---
... which does not work.
What am I missing?
Best regards,
Seb
--
Sebastien Vauban
next prev parent reply other threads:[~2014-03-20 13:31 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 16:50 Diff could also show the changes within lines Sebastien Vauban
2014-02-08 4:58 ` Michael Heerdegen
[not found] ` <mailman.14135.1391835521.10748.help-gnu-emacs@gnu.org>
2014-02-08 12:53 ` Sebastien Vauban
2014-02-10 15:55 ` Sebastien Vauban
2014-02-12 11:35 ` Michael Heerdegen
[not found] ` <mailman.14857.1392204947.10748.help-gnu-emacs@gnu.org>
2014-02-18 10:09 ` Sebastien Vauban
2014-02-18 11:01 ` Sebastien Vauban
2014-02-18 11:02 ` Sebastien Vauban
2014-02-18 16:07 ` Michael Heerdegen
[not found] ` <mailman.15440.1392739818.10748.help-gnu-emacs@gnu.org>
2014-02-18 19:01 ` Sebastien Vauban
2014-02-18 22:12 ` Michael Heerdegen
[not found] ` <mailman.15497.1392761564.10748.help-gnu-emacs@gnu.org>
2014-02-19 11:08 ` Sebastien Vauban
2014-02-19 17:54 ` Michael Heerdegen
2014-02-18 13:40 ` Stefan Monnier
2014-02-18 16:08 ` Michael Heerdegen
2014-02-18 16:04 ` Michael Heerdegen
2014-02-18 16:04 ` Michael Heerdegen
2014-02-18 16:05 ` Michael Heerdegen
2014-03-20 13:31 ` Sebastien Vauban [this message]
2014-03-21 11:46 ` Michael Heerdegen
-- strict thread matches above, loose matches on Subject: below --
2012-10-05 14:37 Tom
2012-10-05 14:39 ` Drew Adams
2012-10-05 14:47 ` Tom
2012-10-05 16:32 ` Doug Lewan
2012-10-05 15:09 ` chandan r
2012-10-05 14:57 ` Tom
2012-10-05 16:26 ` Tom
2012-10-05 18:11 ` Tom
[not found] ` <mailman.10388.1349460693.855.help-gnu-emacs@gnu.org>
2012-11-10 8:58 ` Sebastien Vauban
2012-11-10 15:30 ` Tom
2012-11-12 20:00 ` Oleksandr Gavenko
2012-11-13 8:45 ` Tom
[not found] ` <mailman.12687.1352561429.855.help-gnu-emacs@gnu.org>
2012-11-14 14:31 ` Sebastien Vauban
2012-11-14 18:03 ` Tom
[not found] ` <mailman.12981.1352916228.855.help-gnu-emacs@gnu.org>
2012-11-14 22:07 ` Sebastien Vauban
2012-11-15 6:36 ` Tom
[not found] ` <mailman.13015.1352961428.855.help-gnu-emacs@gnu.org>
2012-11-15 10:04 ` Sebastien Vauban
2012-11-15 10:15 ` Tom
[not found] ` <mailman.13023.1352974557.855.help-gnu-emacs@gnu.org>
2012-11-15 11:29 ` Sebastien Vauban
2012-11-15 12:30 ` Tom
[not found] ` <mailman.13025.1352982671.855.help-gnu-emacs@gnu.org>
2012-11-15 15:20 ` Sebastien Vauban
2012-11-15 16:32 ` Tom
2012-11-16 15:30 ` Stefan Monnier
2012-11-16 16:40 ` Tom
[not found] ` <mailman.13097.1353084086.855.help-gnu-emacs@gnu.org>
2012-11-19 14:48 ` Stefan Monnier
[not found] ` <mailman.13033.1352997200.855.help-gnu-emacs@gnu.org>
2012-11-15 18:17 ` Sebastien Vauban
2012-11-15 18:53 ` Tom
[not found] ` <mailman.13043.1353005666.855.help-gnu-emacs@gnu.org>
2012-11-15 21:34 ` Sebastien Vauban
2012-11-16 16:24 ` Tom
2012-11-19 12:51 ` Sebastien Vauban
2012-11-19 17:45 ` Tom
[not found] ` <mailman.10380.1349454390.855.help-gnu-emacs@gnu.org>
2012-10-06 13:10 ` Stefan Monnier
2012-10-07 14:10 ` Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r45x6lo3.fsf@somewhere.org \
--to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
--cc=help-gnu-emacs-mXXj517/zsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).