unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: What does "tag space" mean?
Date: Fri, 01 Mar 2013 16:19:06 +0200	[thread overview]
Message-ID: <83wqtrurs5.fsf@gnu.org> (raw)
In-Reply-To: <CA+5B0FP96_Os30SZ_U0Rxa=ZNghh6W84Xfsndp9t2wJyQ7P2AA@mail.gmail.com>

> Date: Fri, 1 Mar 2013 14:21:45 +0100
> From: Aurélien Aptel <aurelien.aptel+emacs@gmail.com>
> Cc: help-gnu-emacs@gnu.org
> 
> I've started to write a small guide to the C code on emacswiki [1].
> Any contribution welcome :)

Comments:

 . Unless you intend to cover non-Posix platforms, I suggest to remove
   from the "Build configuration" everything that is not applicable to
   Posix systems, like config.bat.

 . I suggest to show the relevant pieces of C code when you describe
   something like Lisp_Object or XVECTORP.  I think it will make the
   document much more self-contained, as anyone who reads it will need
   to consult the C code anyway.

 . Don't point to specific source line numbers, they change very
   frequently as part of development.  "Around line NNNN" is much
   better, and sometimes it is better to omit that entirely.

 . The part about 256MB limitation of buffers on 32-bit systems is
   incorrect: the max size is 512MB.  Your bit calculations are in
   error.  See VAL_MAX.

 . I question the usefulness of listing all of the Xfoo macros.  It
   should be enough to explain that Xfoo(x) returns a C object
   corresponding to a Lisp object of type foo.  Same goes for the fooP
   macros.

The document doesn't yet go too far to become interesting, so the
above are just small nits.

Thanks.




  parent reply	other threads:[~2013-03-01 14:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 12:39 What does "tag space" mean? Xue Fuqiao
2013-03-01 13:21 ` Aurélien Aptel
2013-03-01 13:39   ` Xue Fuqiao
2013-03-01 14:19   ` Eli Zaretskii [this message]
2013-03-01 14:40 ` Thien-Thi Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wqtrurs5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).