From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.help Subject: Re: Question about memory usage Date: Sat, 07 Apr 2018 16:26:54 +0300 Message-ID: <83woxjywo1.fsf@gnu.org> References: <83sh8c6byb.fsf@gnu.org> <690641bc-fc49-922a-26bd-6f92322d0cc0@zoho.com> <83po3g40c3.fsf@gnu.org> <83bmez4g0b.fsf@gnu.org> <36b25160-eef1-73cf-c585-f798a7cef44c@zoho.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1523107525 487 195.159.176.226 (7 Apr 2018 13:25:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Apr 2018 13:25:25 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sat Apr 07 15:25:20 2018 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4nqK-0008TQ-D2 for geh-help-gnu-emacs@m.gmane.org; Sat, 07 Apr 2018 15:25:20 +0200 Original-Received: from localhost ([::1]:57398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4nsP-00049r-V5 for geh-help-gnu-emacs@m.gmane.org; Sat, 07 Apr 2018 09:27:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4nrt-00049U-O0 for help-gnu-emacs@gnu.org; Sat, 07 Apr 2018 09:26:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4nrq-0008Ax-Kz for help-gnu-emacs@gnu.org; Sat, 07 Apr 2018 09:26:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4nrq-0008Ap-H9 for help-gnu-emacs@gnu.org; Sat, 07 Apr 2018 09:26:54 -0400 Original-Received: from [176.228.60.248] (port=4468 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f4nrp-0006kd-W5 for help-gnu-emacs@gnu.org; Sat, 07 Apr 2018 09:26:54 -0400 In-reply-to: (message from =?utf-8?Q?Micha=C5=82?= Kondraciuk on Sat, 7 Apr 2018 15:15:08 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:116393 Archived-At: > Cc: Eli Zaretskii , help-gnu-emacs@gnu.org > From: Michał Kondraciuk > Date: Sat, 7 Apr 2018 15:15:08 +0200 > > Can you take a look at the attached patch? > > diff --git a/lisp/simple.el b/lisp/simple.el > index aad8d3b..23f7c4f 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -3014,6 +3014,13 @@ undo-auto--undoably-changed-buffers > `undo-auto--boundaries' and can be affected by changes to their > default values.") > > +(defun undo-auto--remove-buffer-from-changed-list () > + "Remove current buffer from list of recently changed ones." > + (setq undo-auto--undoably-changed-buffers > + (delq (current-buffer) undo-auto--undoably-changed-buffers))) > + > +(add-hook 'kill-buffer-hook #'undo-auto--remove-buffer-from-changed-list) > + Thanks, but I'd be more comfortable with just doing this from kill-buffer itself. IMO, hooks are for users and Lisp applications; using them for internal bookkeeping purposes should be limited to the cases where there's no better alternative.