unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: Question about memory usage
Date: Sat, 07 Apr 2018 16:26:54 +0300	[thread overview]
Message-ID: <83woxjywo1.fsf@gnu.org> (raw)
In-Reply-To: <b58e335a-5f71-595a-4bd4-853df8a0e950@zoho.com> (message from Michał Kondraciuk on Sat, 7 Apr 2018 15:15:08 +0200)

> Cc: Eli Zaretskii <eliz@gnu.org>, help-gnu-emacs@gnu.org
> From: Michał Kondraciuk <k.michal@zoho.com>
> Date: Sat, 7 Apr 2018 15:15:08 +0200
> 
> Can you take a look at the attached patch?
> 
> diff --git a/lisp/simple.el b/lisp/simple.el
> index aad8d3b..23f7c4f 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -3014,6 +3014,13 @@ undo-auto--undoably-changed-buffers
>  `undo-auto--boundaries' and can be affected by changes to their
>  default values.")
>  
> +(defun undo-auto--remove-buffer-from-changed-list ()
> +  "Remove current buffer from list of recently changed ones."
> +  (setq undo-auto--undoably-changed-buffers
> +        (delq (current-buffer) undo-auto--undoably-changed-buffers)))
> +
> +(add-hook 'kill-buffer-hook #'undo-auto--remove-buffer-from-changed-list)
> +

Thanks, but I'd be more comfortable with just doing this from
kill-buffer itself.  IMO, hooks are for users and Lisp applications;
using them for internal bookkeeping purposes should be limited to the
cases where there's no better alternative.



  reply	other threads:[~2018-04-07 13:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02 11:57 Question about memory usage Michał Kondraciuk
2018-04-03  2:16 ` Óscar Fuentes
2018-04-03  6:28 ` Eli Zaretskii
2018-04-03 12:28   ` Stefan Monnier
2018-04-03 12:40     ` Eli Zaretskii
2018-04-03 12:51       ` Eli Zaretskii
2018-04-03 13:13       ` Stefan Monnier
2018-04-03 14:03         ` Eli Zaretskii
2018-04-03 14:27           ` Stefan Monnier
2018-04-03 15:16             ` Eli Zaretskii
2018-04-03 21:14               ` Stefan Monnier
2018-04-03 17:57   ` Michał Kondraciuk
2018-04-03 18:22     ` Eli Zaretskii
2018-04-03 19:16       ` Michał Kondraciuk
2018-04-04  6:55         ` Eli Zaretskii
2018-04-05 18:06           ` Michał Kondraciuk
2018-04-05 18:40             ` Eli Zaretskii
2018-04-05 18:54             ` Stefan Monnier
2018-04-07 13:15               ` Michał Kondraciuk
2018-04-07 13:26                 ` Eli Zaretskii [this message]
2018-04-07 15:22                   ` Stefan Monnier
2018-04-07 18:39                     ` Michał Kondraciuk
2018-04-03 21:18       ` Stefan Monnier
2018-04-04  6:08         ` Eli Zaretskii
2018-04-04 21:45           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83woxjywo1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).