My uncomment-region broke

My uncomment-region broke

[Ken Goldman]

(defun uncomment-region (b e)
   "Remove one level of comment around region."
   (interactive "r")
   (comment-region b e -1))

I've been using this for years.  I select a region with the
mouse and this uncomments it.  With new emacs, I get

comment-region-default-1: Wrong number of arguments: (lambda (b e) "Remove one level of comment around region." (interactive "r") (comment-region b e -1)), 3

I'm not an elisp programmer.  Can someone supply a replacement?

Re: My uncomment-region broke

[Eli Zaretskii]

> From: Ken Goldman <kgoldman@us.ibm.com>
> Date: Tue, 2 Nov 2021 10:18:08 -0400
> 
> (defun uncomment-region (b e)
>    "Remove one level of comment around region."
>    (interactive "r")
>    (comment-region b e -1))
> 
> I've been using this for years.  I select a region with the
> mouse and this uncomments it.  With new emacs, I get
> 
> comment-region-default-1: Wrong number of arguments: (lambda (b e) "Remove one level of comment around region." (interactive "r") (comment-region b e -1)), 3
> 
> I'm not an elisp programmer.  Can someone supply a replacement?

You want

  (comment-region b e '(4))

instead of the last line.

(Or just say "C-u M-x comment-region RET".)

Re: My uncomment-region broke

[Stefan Monnier via Users list for the GNU Emacs text editor]

Ken Goldman [2021-11-02 10:18:08] wrote:
> (defun uncomment-region (b e)
>   "Remove one level of comment around region."
>   (interactive "r")
>   (comment-region b e -1))

This redefines Emacs's built-in `uncomment-region`, and does it in an
incompatible way.

> I'm not an elisp programmer.  Can someone supply a replacement?

The empty string is a good replacement ;-)


        Stefan

Re: My uncomment-region broke

[Stephen Berman]

On Tue, 2 Nov 2021 10:18:08 -0400 Ken Goldman <kgoldman@us.ibm.com> wrote:

> (defun uncomment-region (b e)
>   "Remove one level of comment around region."
>   (interactive "r")
>   (comment-region b e -1))
>
> I've been using this for years.  I select a region with the
> mouse and this uncomments it.  With new emacs, I get
>
> comment-region-default-1: Wrong number of arguments: (lambda (b e) "Remove one
> level of comment around region." (interactive "r") (comment-region b e -1)), 3
>
> I'm not an elisp programmer.  Can someone supply a replacement?

Rename it to e.g. kg-uncomment-region.  (It raises an error because
comment-region-default-1 calls another emacs function uncomment-region
which takes an optional third argument, so it clashes with your
definition.)

Steve Berman

Re: My uncomment-region broke

[Ken Goldman]

On 11/2/2021 11:14 AM, Stefan Monnier via Users list for the GNU Emacs text editor wrote:
> Ken Goldman [2021-11-02 10:18:08] wrote:
>> (defun uncomment-region (b e)
>>    "Remove one level of comment around region."
>>    (interactive "r")
>>    (comment-region b e -1))
> 
> This redefines Emacs's built-in `uncomment-region`, and does it in an
> incompatible way.
> 

Thanks.  I think my function predates the built-in one.  I see
now that I no longer need it.