unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: ensure safe directory failing
Date: Sat, 19 Mar 2011 19:47:10 +0200	[thread overview]
Message-ID: <83r5a39f4x.fsf@gnu.org> (raw)
In-Reply-To: <DJGdnX5Xgvf3dxnQnZ2dnUVZ_r2dnZ2d@sysmatrix.net>

> Date: Sat, 19 Mar 2011 12:39:54 -0500
> From: "B. T. Raven" <nihil@nihilo.net>
> 
> > --- lisp/server.el	2011-01-02 23:50:46 +0000
> > +++ lisp/server.el	2011-03-11 12:19:08 +0000
> > @@ -474,7 +474,13 @@ See variable `server-auth-dir' for detai
> >  			      (file-name-as-directory dir))
> >  		      :warning)
> >  		     (throw :safe t))
> > -		   (unless (eql uid (user-uid)) ; is the dir ours?
> > +		   (unless (or (= uid (user-uid)) ; is the dir ours?
> > +			       (and w32
> > +				    ;; Files created on Windows by
> > +				    ;; Administrator (RID=500) have
> > +				    ;; the Administrators (RID=544)
> > +				    ;; group recorded as the owner.
> > +				    (= uid 544) (= (user-uid) 500)))
> >  		     (throw :safe nil))
> >  		   (when w32                    ; on NTFS?
> >  		     (throw :safe t))
> > 
> > 
> 
> I think so. I don't have or don't understand the source code maintenance
> tools

If you have a ported patch.exe, I can tell you the exact command to
invoke it, after you save the patch to a file.

> if I just delete lines 474-477 and add those starting with:
> (unless (or (= uid (user-uid)) ; is the dir ours?
> it should accomplish the same thing.

No.  You should delete the line prefixed with "-" and then add all the
lines prefixed with "+".  Then byte-compile the modified server.el,
restart Emacs, and see if the problem is gone.



  reply	other threads:[~2011-03-19 17:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18 22:44 ensure safe directory failing B. T. Raven
2011-03-19  7:50 ` Eli Zaretskii
     [not found] ` <mailman.8.1300521008.15172.help-gnu-emacs@gnu.org>
2011-03-19 12:44   ` B. T. Raven
2011-03-19 15:00     ` Eli Zaretskii
     [not found]     ` <mailman.3.1300546821.11495.help-gnu-emacs@gnu.org>
2011-03-19 17:39       ` B. T. Raven
2011-03-19 17:47         ` Eli Zaretskii [this message]
     [not found]         ` <mailman.9.1300556892.13615.help-gnu-emacs@gnu.org>
2011-03-20  1:36           ` B. T. Raven
2011-03-20  7:10             ` Eli Zaretskii
     [not found]             ` <mailman.13.1300605015.19367.help-gnu-emacs@gnu.org>
2011-03-20 16:23               ` B. T. Raven
2011-03-20 16:30                 ` B. T. Raven
2011-03-20 17:55                   ` Eli Zaretskii
     [not found]                   ` <mailman.3.1300643740.13228.help-gnu-emacs@gnu.org>
2011-03-20 19:06                     ` B. T. Raven
2011-03-20 20:35                       ` Eli Zaretskii
     [not found]                       ` <mailman.1.1300653326.12439.help-gnu-emacs@gnu.org>
2011-03-20 20:46                         ` B. T. Raven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r5a39f4x.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).