minor-mode hook not run

minor-mode hook not run

[Andreas Röhler]

Hi,

writing a minor-mode, whose hook should do some setup

(define-minor-mode foo
   "Do something" nil " FOO"}
   :keymap foo-map
   (cond
    ((eq major-mode 'abc)
     (add-hook 'foo-mode-hook 'foo-load-abc nil t)
     ;; (funcall 'foo-load-abc)
)
...

Unfortunately, while the function ‘foo-load-abc-mode’ is present in the 
hook, it is not called.

While uncommenting the funcall shown would set up the vars.

Any idea, while this as a hook has no effect?

Thanks,

Andreas

Re: minor-mode hook not run

[John Shahid]

i think the hook will be called `foo-hook' not `foo-mode-hook'

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

> Hi,
>
> writing a minor-mode, whose hook should do some setup
>
> (define-minor-mode foo
>   "Do something" nil " FOO"}
>   :keymap foo-map
>   (cond
>    ((eq major-mode 'abc)
>     (add-hook 'foo-mode-hook 'foo-load-abc nil t)
>     ;; (funcall 'foo-load-abc)
> )
> ...
>
> Unfortunately, while the function ‘foo-load-abc-mode’ is present in the hook,
> it is not called.
>
> While uncommenting the funcall shown would set up the vars.
>
> Any idea, while this as a hook has no effect?
>
> Thanks,
>
> Andreas

Re: minor-mode hook not run

[Stefan Monnier]

> (define-minor-mode foo
                     ^^^
This should likely be `foo-mode`.

>   "Do something" nil " FOO"}

Is the above } intended?

>   :keymap foo-map

[ I strongly recommend not to use :keymap argument and just name your
  minor mode map `<MINORMODE>-map`.  ]

>   (cond
>    ((eq major-mode 'abc)

It's usually better to test (derived-mode-p 'abc).

>     (add-hook 'foo-mode-hook 'foo-load-abc nil t)

Adding elements to one's own hook here definitely deserve a "bug ugly
hack" comment explaining why you'd want to do it that way.

In any case, the minor mode `foo` will run `foo-hook` but not
`foo-mode-hook` (which would be run by the `foo-mode` minor mode).


        Stefan

Re: minor-mode hook not run

[Emanuel Berg]

Stefan Monnier wrote:

> Adding elements to one's own hook here
> definitely deserve a "bug ugly hack" comment
> explaining why you'd want to do it that way.
>
> In any case, the minor mode `foo` will run
> `foo-hook` but not `foo-mode-hook` (which
> would be run by the `foo-mode` minor mode).

Callings things foo isn't encouraged BTW.
It finds its way into "production code" soon
enough. If it is just a joke intended for
personal computer exploration, instead make
something up: make it replace the char at point
by the next char in the English alphabet, and
call it "abc-mode", or whatever, just not foo,
bar, foobar, main, or anything like that.

-- 
underground experts united
http://user.it.uu.se/~embe8573

Re: minor-mode hook not run

[Andreas Röhler]

On 20.03.2018 21:31, Stefan Monnier wrote:
>> (define-minor-mode foo
>                       ^^^
> This should likely be `foo-mode`.
> 
>>    "Do something" nil " FOO"}
> 
> Is the above } intended?

No, it's a typo, sorry.

> 
>>    :keymap foo-map
> 
> [ I strongly recommend not to use :keymap argument and just name your
>    minor mode map `<MINORMODE>-map`.  ]
> 
>>    (cond
>>     ((eq major-mode 'abc)
> 
> It's usually better to test (derived-mode-p 'abc).

Okay, done.


> 
>>      (add-hook 'foo-mode-hook 'foo-load-abc nil t)
> 
> Adding elements to one's own hook here definitely deserve a "bug ugly
> hack" comment explaining why you'd want to do it that way.

Hmm, not sure if I understand that part.

Purpose is a generic key for related commands:
For example to start a REPL, haskell-mode calls
‘haskell-interactive-switch’, python.el calls ‘run-python’,
python-mode.el ‘py-shell’ etc.

Instead of remembering different keys and change them maybe at several
locations, a unified command ‘gk-repl’ is provided, whose key-binding
should DTRT in all modes.

For the audacious:
https://github.com/andreas-roehler/general-key

> 
> In any case, the minor mode `foo` will run `foo-hook` but not
> `foo-mode-hook` (which would be run by the `foo-mode` minor mode).
> 

That solved it, thanks all,

Andreas

Re: minor-mode hook not run

[Stefan Monnier]

>>>      (add-hook 'foo-mode-hook 'foo-load-abc nil t)
>> Adding elements to one's own hook here definitely deserve a "bug ugly
>> hack" comment explaining why you'd want to do it that way.
> Hmm, not sure if I understand that part.

I'm saying that adding to <FOO>-mode-hook from within the body of
<FOO>-mode is weird.

Instead of

    (define-minor-mode foo-mode
      ...
      (add-hook 'foo-mode-hook #'blabla nil t)
      ...)

why not do the more natural:

    (define-minor-mode foo-mode
      ...
      (blabla)
      ...)

The "big ugly hack" comment should explain why the `add-hook` version
is needed.

> Purpose is a generic key for related commands:
> For example to start a REPL, haskell-mode calls
> ‘haskell-interactive-switch’, python.el calls ‘run-python’,
> python-mode.el ‘py-shell’ etc.
>
> Instead of remembering different keys and change them maybe at several
> locations, a unified command ‘gk-repl’ is provided, whose key-binding
> should DTRT in all modes.

I don't see how this explains why you need to go through foo-mode-hook
rather than calling the function directly.


        Stefan

Re: minor-mode hook not run

[Andreas Röhler]

On 22.03.2018 14:52, Stefan Monnier wrote:
>>>>       (add-hook 'foo-mode-hook 'foo-load-abc nil t)
>>> Adding elements to one's own hook here definitely deserve a "bug ugly
>>> hack" comment explaining why you'd want to do it that way.
>> Hmm, not sure if I understand that part.
> 
> I'm saying that adding to <FOO>-mode-hook from within the body of
> <FOO>-mode is weird.
> 
> Instead of
> 
>      (define-minor-mode foo-mode
>        ...
>        (add-hook 'foo-mode-hook #'blabla nil t)
>        ...)
> 
> why not do the more natural:
> 
>      (define-minor-mode foo-mode
>        ...
>        (blabla)
>        ...)
> 
> The "big ugly hack" comment should explain why the `add-hook` version
> is needed.
> 
>> Purpose is a generic key for related commands:
>> For example to start a REPL, haskell-mode calls
>> ‘haskell-interactive-switch’, python.el calls ‘run-python’,
>> python-mode.el ‘py-shell’ etc.
>>
>> Instead of remembering different keys and change them maybe at several
>> locations, a unified command ‘gk-repl’ is provided, whose key-binding
>> should DTRT in all modes.
> 
> I don't see how this explains why you need to go through foo-mode-hook
> rather than calling the function directly.
> 

Okay, got it, thanks,

Andreas