unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: [solved]: Re: Finding last *Async Shell Command* buffer?
Date: Fri, 26 Mar 2021 10:56:51 +0300	[thread overview]
Message-ID: <8335wiqrek.fsf@gnu.org> (raw)
In-Reply-To: <YF2MVnK9k/rvePs9@protected.localdomain> (message from Jean Louis on Fri, 26 Mar 2021 10:25:10 +0300)

> Date: Fri, 26 Mar 2021 10:25:10 +0300
> From: Jean Louis <bugs@gnu.support>
> Cc: help-gnu-emacs@gnu.org
> 
> > Emacs told you what's wrong: "Wrong number of arguments".  What isn't
> > clear about that error message?
> 
> It is confusing as I was thinking I gave it enough arguments, but it
> requires `interactive' so I copied it from original function.

Command invocation doesn't give _any_ arguments at all.  The arguments
in that case must be provided by the 'interactive' form.  And in your
original code the 'interactive' form returned an empty list.

> Now it is solved intermittently:
> 
> (defun rcd-async-shell-command (&rest args)
>   "Remembers last async shell command on `C-c l'"
>   (interactive
>    (list
>     (read-shell-command (if shell-command-prompt-show-cwd
>                             (format-message "Async shell command in `%s': "
>                                             (abbreviate-file-name
>                                              default-directory))
>                           "Async shell command: ")
>                         nil nil
> 			(let ((filename
> 			       (cond
> 				(buffer-file-name)
> 				((eq major-mode 'dired-mode)
> 				 (dired-get-filename nil t)))))
> 			  (and filename (file-relative-name filename))))
>     current-prefix-arg
>     shell-command-default-error-buffer))
>   (let* ((shell-command-buffer-name-async (concat "RCD Async: " (format-time-string "%Y%m%d%H%M%S")))
> 	 (last-buffer shell-command-buffer-name-async))
>     (global-set-key (kbd "C-c l") `(lambda () 
> 				     (interactive)
> 				     (switch-to-buffer ,last-buffer)))
>     (apply #'async-shell-command args)))
> 
> Now I can bind it:
> 
> (global-set-key (kbd "M-&") 'rcd-async-shell-command) 
> 
> And now it works, when I wish to get the last async buffer I just
> press `C-c l'.

What happens if that buffer was meanwhile killed?

Personally, I find it un-Emacsy to write a wrapper command each time
you want to manipulate the results of an existing command.  Emacs
provides hooks for that very purpose, so it's best to use those
instead of inventing a new command each time you need something like
that.  Redefining a key binding each time you run an async command is
also ... inelegant.

But that's me.



  parent reply	other threads:[~2021-03-26  7:56 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 14:33 Finding last *Async Shell Command* buffer? Jean Louis
2021-03-25 15:03 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-25 15:08   ` Jean Louis
2021-03-25 20:27     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-25 20:36       ` Jean Louis
2021-03-25 20:50         ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-25 20:59           ` Jean Louis
2021-03-25 21:08             ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-25 21:12               ` Jean Louis
2021-03-26  5:52                 ` Robert Thorpe
2021-03-26  6:47                   ` Eli Zaretskii
2021-03-26  7:04                     ` Jean Louis
2021-03-26  7:18                       ` Eli Zaretskii
2021-03-26  7:28                       ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26  7:38                         ` Jean Louis
2021-03-26  7:52                           ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26  8:43                             ` Jean Louis
2021-03-26 13:37                               ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26 20:08                                 ` Jean Louis
2021-03-26 21:59                                   ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26  7:17                     ` Jean Louis
2021-03-26  7:47                       ` Eli Zaretskii
2021-03-26  7:54                         ` Jean Louis
2021-03-26 11:31                           ` Eli Zaretskii
2021-03-26 14:02                           ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26 20:11                             ` Jean Louis
2021-03-26 22:00                               ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26 23:28                                 ` Jean Louis
2021-03-26 23:39                                   ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26  7:01                   ` Jean Louis
2021-03-26  7:09                     ` Eli Zaretskii
2021-03-26  7:25                       ` [solved]: " Jean Louis
2021-03-26  7:31                         ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26  7:40                           ` Jean Louis
2021-03-26  7:56                         ` Eli Zaretskii [this message]
2021-03-26  8:55                           ` Jean Louis
2021-03-26 11:18                             ` Eli Zaretskii
2021-03-26 11:26                               ` Jean Louis
2021-03-26 11:33                                 ` Eli Zaretskii
2021-03-26 11:48                                   ` Jean Louis
2021-03-26 12:37                                     ` Eli Zaretskii
2021-03-26 20:05                                       ` Jean Louis
2021-03-26 22:02                                         ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26 23:29                                           ` Jean Louis
2021-03-26 23:41                                             ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26 13:49                                     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26 10:34                           ` Jean Louis
2021-03-26 11:30                             ` Eli Zaretskii
2021-03-25 15:18   ` Jean Louis
2021-03-25 15:54     ` Skip Montanaro
2021-03-25 19:31       ` Jean Louis
2021-03-25 18:10 ` Filipp Gunbin
2021-03-25 19:40   ` Jean Louis
2021-03-26 13:09     ` Filipp Gunbin
2021-03-26 13:40       ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-26 20:06       ` Jean Louis
2021-03-26 21:17         ` Filipp Gunbin
2021-03-25 20:05   ` Jean Louis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8335wiqrek.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).