Problem with Emacs 28.1 and dired on Windows

Problem with Emacs 28.1 and dired on Windows

[Pascal Quesseveur]

Hello,

I am encountering a problem with dired using emacs 28.1 on Windows 10.

I open a dired buffer on a dir named "C:/Users/Public/Applis"
containing a symbolic link named "Dir01" (the link has been created on
Windows 10 with command mklink /D). In dired Dir01 is followed by ->
and the name of the real directory.

In 27.1 when I hit i (dired-maybe-insert-subdir) on Dir01, it opens
content of Dir01 in the current dired buffer. In 28.1, emacs displays
an error message:

C:/Users/Public/Applis/Dir01 not in this directory tree

There is a change in (dired-insert-subdir-validate). To verify the
directory emacs now calls (file-in-directory-p) instead of
(dired-in-this-tree-p). And:

(dired-in-this-tree-p "C:/Users/Public/Applis/Dir01/" "C:/Users/Public/")
-> 0

(file-in-directory-p "C:/Users/Public/Applis/Dir01/" "C:/Users/Public/")
-> nil


-- 
Pascal Quesseveur
pquessev@gmail.com

Re: Problem with Emacs 28.1 and dired on Windows

[Michael Heerdegen]

Pascal Quesseveur <pquessev@gmail.com> writes:

> In 27.1 when I hit i (dired-maybe-insert-subdir) on Dir01, it opens
> content of Dir01 in the current dired buffer. In 28.1, emacs displays
> an error message:
>
> C:/Users/Public/Applis/Dir01 not in this directory tree
>
> There is a change in (dired-insert-subdir-validate). To verify the
> directory emacs now calls (file-in-directory-p) instead of
> (dired-in-this-tree-p). And:
>
> (dired-in-this-tree-p "C:/Users/Public/Applis/Dir01/" "C:/Users/Public/")
> -> 0
>
> (file-in-directory-p "C:/Users/Public/Applis/Dir01/" "C:/Users/Public/")
> -> nil

Let's then CC the author of this change, Tassilo Horn.

Michael.

Re: Problem with Emacs 28.1 and dired on Windows

[Tassilo Horn]

Pascal Quesseveur <pquessev@gmail.com> writes:

Hi Pascal,

> I am encountering a problem with dired using emacs 28.1 on Windows 10.
>
> I open a dired buffer on a dir named "C:/Users/Public/Applis"
> containing a symbolic link named "Dir01" (the link has been created on
> Windows 10 with command mklink /D). In dired Dir01 is followed by ->
> and the name of the real directory.
>
> In 27.1 when I hit i (dired-maybe-insert-subdir) on Dir01, it opens
> content of Dir01 in the current dired buffer. In 28.1, emacs displays
> an error message:
>
> C:/Users/Public/Applis/Dir01 not in this directory tree
>
> There is a change in (dired-insert-subdir-validate). To verify the
> directory emacs now calls (file-in-directory-p) instead of
> (dired-in-this-tree-p). And:
>
> (dired-in-this-tree-p "C:/Users/Public/Applis/Dir01/" "C:/Users/Public/")
> -> 0
>
> (file-in-directory-p "C:/Users/Public/Applis/Dir01/" "C:/Users/Public/")
> -> nil

Sorry, this is my fault.  Could you please file a bug report with M-x
report-emacs-bug and add me to the Cc, please?

Bye,
Tassilo

Re: Problem with Emacs 28.1 and dired on Windows

[Pascal Quesseveur]

>"TH" == Tassilo Horn <tsdh@gnu.org> writes:

  Hi Tassilo,
  
  TH> Sorry, this is my fault.  Could you please file a bug report
  TH> with M-x report-emacs-bug and add me to the Cc, please?

  It's done.


-- 
Pascal Quesseveur
pquessev@gmail.com

Re: Problem with Emacs 28.1 and dired on Windows

[Tassilo Horn]

Pascal Quesseveur <pquessev@gmail.com> writes:

Hi Pascal,

>   TH> Sorry, this is my fault.  Could you please file a bug report
>   TH> with M-x report-emacs-bug and add me to the Cc, please?
>
>   It's done.

And it's fixed already in the emacs-28 branch so will be in a
hypothetical but likely emacs 28.2 release.

Thank you,
Tassilo