defface not defining a face?

defface not defining a face?

[lee]

Hi,

what´s wrong with


[...]
(defgroup lsl-faces nil
  "Faces for lsl-mode."
  :group 'lsl-faces
  :group 'faces)


(defface lsl-global-variable
  '((((background dark)) (:background "pink" :foreground "black"))
    (t (:background "pink")))
  "Face to highlight global variables"
  :group 'lsl-faces)


(defun lsl-hi-lock-global-variable ()
  "add a hi-lock-mode pattern to highlight something that is a
global variable"
  (interactive)
  (lsl-hi-lock-add lsl-global-variable))
[...]


That gives me "reference to free variable `lsl-global-variable'" when
byte-compiling, and "lsl-hi-lock-global-variable: Symbol's value as
variable is void: lsl-global-variable" when calling
(lsl-hi-lock-global-variable).

Apparently the face is not defined.  How come?

See https://github.com/Ratany/lsl-repo/tree/master/emacs --- I´m trying
to add some face definitions.


-- 
Knowledge is volatile and fluid.  Software is power.

Re: defface not defining a face?

[Juanma Barranquero]

On Sun, Mar 9, 2014 at 7:08 PM, lee <lee@yun.yagibdah.de> wrote:

> (defface lsl-global-variable
>   '((((background dark)) (:background "pink" :foreground "black"))
>     (t (:background "pink")))
>   "Face to highlight global variables"
>   :group 'lsl-faces)

> Apparently the face is not defined.  How come?

Oh, yes, it is defined. Try (facep 'lsl-global-variable)

But a face is not a variable, so (boundp 'lsl-global-variable) is nil.

    J

RE: defface not defining a face?

[Drew Adams]

> > Apparently the face is not defined.  How come?
> 
> Oh, yes, it is defined. Try (facep 'lsl-global-variable)
> But a face is not a variable, so (boundp 'lsl-global-variable) is nil.

In addition, do not use the group you are defining as a parent group:

(defgroup lsl-faces nil
  "Faces for lsl-mode."
  :group 'lsl-faces ; <=========== REMOVE THIS
  :group 'faces)

Re: defface not defining a face?

[lee]

Drew Adams <drew.adams@oracle.com> writes:

>> > Apparently the face is not defined.  How come?
>> 
>> Oh, yes, it is defined. Try (facep 'lsl-global-variable)
>> But a face is not a variable, so (boundp 'lsl-global-variable) is nil.
>
> In addition, do not use the group you are defining as a parent group:
>
> (defgroup lsl-faces nil
>   "Faces for lsl-mode."
>   :group 'lsl-faces ; <=========== REMOVE THIS
>   :group 'faces)

Thank you, I didn´t notice ...  It seems I´ll have to look into setting
up a group for the mode, since there are more things that can be
customized ...


-- 
Knowledge is volatile and fluid.  Software is power.

Re: defface not defining a face?

[lee]

Juanma Barranquero <lekktu@gmail.com> writes:

> On Sun, Mar 9, 2014 at 7:08 PM, lee <lee@yun.yagibdah.de> wrote:
>
>> (defface lsl-global-variable
>>   '((((background dark)) (:background "pink" :foreground "black"))
>>     (t (:background "pink")))
>>   "Face to highlight global variables"
>>   :group 'lsl-faces)
>
>> Apparently the face is not defined.  How come?
>
> Oh, yes, it is defined. Try (facep 'lsl-global-variable)
>
> But a face is not a variable, so (boundp 'lsl-global-variable) is nil.

So I would need to define a variable like it is done in font-lock.el?
Because those work --- and font-lock.el says I shouldn´t define a
variable for it ...  But using 'lsl-global-variable instead of
lsl-global-variable works fine :)


-- 
Knowledge is volatile and fluid.  Software is power.

Re: defface not defining a face?

[Michael Heerdegen]

lee <lee@yun.yagibdah.de> writes:

> So I would need to define a variable like it is done in font-lock.el?
> Because those work --- and font-lock.el says I shouldn´t define a
> variable for it ...  But using 'lsl-global-variable instead of
> lsl-global-variable works fine :)

No, that's perfectly fine.  The error was just the missing quote - which
caused Emacs to interpret and evaluate it as a variable (which it isn't,
the symbol isn't bound to a value, it's just the name of a face).

Michael.

Re: defface not defining a face?

[Jambunathan K]

This one is right from my .emacs.  The default values of highlight faces
is not to my taste.  I have some 8-9 faces which are defined like this.

(defface highlight-1
  '((((min-colors 88) (background dark))
     (:background "yellow1" :foreground "black"))
    (((background dark)) (:background "yellow" :foreground "black"))
    (((min-colors 88)) (:background "yellow1"))
    (t (:background "yellow")))
  "Default face for hi-lock mode."
  :group 'highlight-faces)

(defface highlight-2
  '((((background dark)) (:background "pink" :foreground "black"))
    (t (:background "pink")))
  "Face for hi-lock mode."
  :group 'highlight-faces)

(defface highlight-3
  '((((min-colors 88) (background dark))
     (:background "green1" :foreground "black"))
    (((background dark)) (:background "green" :foreground "black"))
    (((min-colors 88)) (:background "green1"))
    (t (:background "green")))
  "Face for hi-lock mode."
  :group 'highlight-faces)

(defvar hi-lock-face-regexp "\\`highlight-.*")

(setq hi-lock-face-defaults
      ((lambda (regexp)
	 "List of faces that match REGEXP."
	 (delq nil
	       (mapcar (lambda (f)
			 (let ((s (symbol-name f)))
			   (when (string-match regexp s) s)))
		       (reverse (face-list)))))
       hi-lock-face-regexp))