unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
* dabbrev hang
@ 2003-05-27 18:05 Kin Cho
  2003-05-28 13:29 ` Klaus Zeitler
  0 siblings, 1 reply; 3+ messages in thread
From: Kin Cho @ 2003-05-27 18:05 UTC (permalink / raw)


Hi,

I call dabbrev-expand while the minibuffer is active (e.g.,
interactively calling eval-expression), it dabbrev hangs in
dabbrev--goto-start-of-abbrev.

The reason is that (bobp) is false and (forward-char -1)
can't backup into the prompt.

I'm thinking advicing bobp to cope with this, but is there a
better fix?

I'm using emacs 21.3.

Thanks.

-kin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: dabbrev hang
  2003-05-27 18:05 dabbrev hang Kin Cho
@ 2003-05-28 13:29 ` Klaus Zeitler
  2003-05-28 17:02   ` Kin Cho
  0 siblings, 1 reply; 3+ messages in thread
From: Klaus Zeitler @ 2003-05-28 13:29 UTC (permalink / raw)


>>>>> "Kin" == Kin Cho <kin@neoscale.com> writes:
    Kin> 
    Kin> I call dabbrev-expand while the minibuffer is active (e.g.,
    Kin> interactively calling eval-expression), it dabbrev hangs in
    Kin> dabbrev--goto-start-of-abbrev.
    Kin> 
    Kin> The reason is that (bobp) is false and (forward-char -1)
    Kin> can't backup into the prompt.
    Kin> 
    Kin> I'm thinking advicing bobp to cope with this, but is there a
    Kin> better fix?
    Kin> 
    Kin> I'm using emacs 21.3.

I tried to follow up on this on gnu.emacs.bug, but my last replies there
haven't shown up. Thus I'll repost it here.

that is probably the bug I reported last year, RMS sent me a patch
for this problem. Please try:

--- snip ---
*** /vol/freeware/SunOS-5.8/emacs/21.3/share/emacs/21.3/lisp/dabbrev.el	Thu Jun 21 09:40:45 2001
--- /vol/freeware/SunOS-5.8/emacs/21.3/share/emacs/21.3/site-lisp/patch/dabbrev.el	Mon Apr  7 15:42:57 2003
***************
*** 599,605 ****
  	(progn
  	  (forward-char -1)
  	  (while (and (looking-at dabbrev--abbrev-char-regexp)
! 		      (not (bobp)))
  	    (forward-char -1))
  	  (or (looking-at dabbrev--abbrev-char-regexp)
  	      (forward-char 1))))
--- 599,605 ----
  	(progn
  	  (forward-char -1)
  	  (while (and (looking-at dabbrev--abbrev-char-regexp)
! 		      (not (= (point) (field-beginning (point)))))
  	    (forward-char -1))
  	  (or (looking-at dabbrev--abbrev-char-regexp)
  	      (forward-char 1))))
***************
*** 948,953 ****
--- 948,954 ----
  			    "\\(" dabbrev--abbrev-char-regexp "\\)"))
  	  (pattern2 (concat (regexp-quote abbrev)
  			   "\\(\\(" dabbrev--abbrev-char-regexp "\\)+\\)"))
+ 	  (inhibit-point-motion-hooks t)
  	  (found-string nil))
        ;; Limited search.
        (save-restriction
--- snip ---

This patch didn't make it into 21.3, I'll check if it's in CVS.

Klaus

-- 
 ------------------------------------------
|  Klaus Zeitler      Lucent Technologies  |
 ------------------------------------------
---
Whenever anyone says, "theoretically", they
really mean, "not really".   -- Dave Parnas

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: dabbrev hang
  2003-05-28 13:29 ` Klaus Zeitler
@ 2003-05-28 17:02   ` Kin Cho
  0 siblings, 0 replies; 3+ messages in thread
From: Kin Cho @ 2003-05-28 17:02 UTC (permalink / raw)


Klaus Zeitler <kzeitler+usenet@gsm-mailhost.de.lucent.com> writes:

> that is probably the bug I reported last year, RMS sent me a patch
> for this problem. Please try:

You're right, this patch fixes my problem as well.

Thanks.

-kin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-05-28 17:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-27 18:05 dabbrev hang Kin Cho
2003-05-28 13:29 ` Klaus Zeitler
2003-05-28 17:02   ` Kin Cho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).