From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.help Subject: RE: Can't add bookmarks for help pages Date: Mon, 11 Jun 2012 14:00:40 -0700 Message-ID: <785789BA0DFD4763A756A8FA4961AE7E@us.oracle.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_00D5_01CD47DA.96011B70" X-Trace: dough.gmane.org 1339448458 28589 80.91.229.3 (11 Jun 2012 21:00:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2012 21:00:58 +0000 (UTC) To: "'Stefan Monnier'" , Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Jun 11 23:00:57 2012 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SeBjK-00081w-Vt for geh-help-gnu-emacs@m.gmane.org; Mon, 11 Jun 2012 23:00:55 +0200 Original-Received: from localhost ([::1]:34048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeBjK-0000wo-U5 for geh-help-gnu-emacs@m.gmane.org; Mon, 11 Jun 2012 17:00:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeBjF-0000wg-Dh for help-gnu-emacs@gnu.org; Mon, 11 Jun 2012 17:00:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeBjD-0006JY-Dp for help-gnu-emacs@gnu.org; Mon, 11 Jun 2012 17:00:48 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:39120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeBjD-0006I4-5w for help-gnu-emacs@gnu.org; Mon, 11 Jun 2012 17:00:47 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q5BL0gWd010692 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Jun 2012 21:00:42 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q5BL0frM029446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 11 Jun 2012 21:00:42 GMT Original-Received: from abhmt101.oracle.com (abhmt101.oracle.com [141.146.116.53]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q5BL0fu9029992; Mon, 11 Jun 2012 16:00:41 -0500 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 11 Jun 2012 14:00:41 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac1H1wfr15r6NUz6TY6aq1827mcdCgAD2YWg In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 141.146.126.227 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:85211 Archived-At: This is a multi-part message in MIME format. ------=_NextPart_000_00D5_01CD47DA.96011B70 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > > Not letting me bookmark help pages isn't user-friendly. > > Agreed. Patches to add bookmark support to help buffers would > be welcome. Attached. How about a patch to upgrade bookmark.el to Bookmark+? ;-) ------=_NextPart_000_00D5_01CD47DA.96011B70 Content-Type: application/octet-stream; name="help-mode-2012-06-11.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="help-mode-2012-06-11.patch" diff -c help-mode-patched-2012-06-11.el help-mode.el=0A= *** help-mode-patched-2012-06-11.el Mon Jun 11 13:49:28 2012=0A= --- help-mode.el Mon Jun 11 11:27:18 2012=0A= ***************=0A= *** 274,282 ****=0A= Commands:=0A= \\{help-mode-map}"=0A= (set (make-local-variable 'revert-buffer-function)=0A= ! 'help-mode-revert-buffer)=0A= ! (set (make-local-variable 'bookmark-make-record-function)=0A= ! 'help-bookmark-make-record))=0A= =0A= ;;;###autoload=0A= (defun help-mode-setup ()=0A= --- 274,280 ----=0A= Commands:=0A= \\{help-mode-map}"=0A= (set (make-local-variable 'revert-buffer-function)=0A= ! 'help-mode-revert-buffer))=0A= =0A= ;;;###autoload=0A= (defun help-mode-setup ()=0A= ***************=0A= *** 793,830 ****=0A= (with-output-to-temp-buffer (help-buffer)=0A= (insert string)))=0A= =0A= - =0C=0A= - ;; Bookmark support=0A= - =0A= - (defvar bookmark-make-record-function)=0A= - =0A= - (declare-function bookmark-prop-get "bookmark" (bookmark prop))=0A= - =0A= - (defun help-bookmark-make-record ()=0A= - "Create and return a help-mode bookmark record.=0A= - Implements `bookmark-make-record-function' for help-mode buffers."=0A= - (unless (car help-xref-stack-item)=0A= - (error "Cannot create bookmark - help command not known"))=0A= - `(,@(bookmark-make-record-default 'NO-FILE 'NO-CONTEXT)=0A= - (buffer-name . "*Help*")=0A= - (help-fn . ,(car help-xref-stack-item))=0A= - (help-arg . ,(cadr help-xref-stack-item))=0A= - (position . ,(point))=0A= - (handler . help-bookmark-jump)))=0A= - =0A= - ;;;###autoload=0A= - (defun help-bookmark-jump (bookmark)=0A= - "Jump to help-mode bookmark BOOKMARK.=0A= - Handler function for record returned by `help-bookmark-make-record'.=0A= - BOOKMARK is a bookmark name or a bookmark record."=0A= - (let ((help-fn (bookmark-prop-get bookmark 'help-fn))=0A= - (help-arg (bookmark-prop-get bookmark 'help-arg))=0A= - (position (bookmark-prop-get bookmark 'position)))=0A= - (funcall help-fn help-arg)=0A= - (pop-to-buffer "*Help*")=0A= - (goto-char position)))=0A= - =0A= - =0A= (provide 'help-mode)=0A= =0A= ;;; help-mode.el ends here=0A= --- 791,796 ----=0A= =0A= Diff finished. Mon Jun 11 13:53:50 2012=0A= ------=_NextPart_000_00D5_01CD47DA.96011B70--