unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>, <help-gnu-emacs@gnu.org>
Subject: RE: read-from-minibuffer & match data
Date: Tue, 18 Dec 2012 19:07:08 -0800	[thread overview]
Message-ID: <6FC453A30838455C846EC483B2EB382B@us.oracle.com> (raw)
In-Reply-To: <jwvsj72x40d.fsf-monnier+gmane.emacs.help@gnu.org>

> > I've put a save-match-data into the function to solve the 
> > issue, but I'd just like to make sure this isn't a bug in emacs.
> 
> No, you've just been lucky until now.  The general rule is that any
> function is liable to thrash the match-data, except for some 
> exceptions, most of which are primitives such as car/cdr/aset/aref,
> match-string, etc...

That is the general rule, yes, and it is appropriate.

But is it a reason that `read-from-minibuffer' should start thrashing the
match-data, if it has not done so in the past?

That was the point, I think: to make sure that Emacs Dev is aware of this
change.  If it is intentional, that's one thing; if not, perhaps it
represents/indicates a bug somewhere.

But I guess you are implicitly confirming that you have checked and the
thrashing is necessary or at least intentional.




  reply	other threads:[~2012-12-19  3:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18 20:06 read-from-minibuffer & match data Joost Kremers
2012-12-19  0:05 ` Drew Adams
2012-12-19  0:48 ` Stefan Monnier
2012-12-19  3:07   ` Drew Adams [this message]
2012-12-19  5:05     ` Stefan Monnier
2012-12-19  5:18       ` Drew Adams
     [not found] ` <mailman.15639.1355876062.855.help-gnu-emacs@gnu.org>
2012-12-19 12:26   ` Joost Kremers
2012-12-19 15:56     ` Barry Margolin
2012-12-19 20:43       ` Joost Kremers
2012-12-20  6:01         ` Barry Margolin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6FC453A30838455C846EC483B2EB382B@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).