unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Perry Smith <pedzsan@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Help needed with defadvice
Date: Sat, 23 Nov 2013 09:22:35 -0600	[thread overview]
Message-ID: <6F68AA38-BFEF-4B6B-BE9B-105A22359891@gmail.com> (raw)
In-Reply-To: <jwv8uwfxjhy.fsf-monnier+gmane.emacs.help@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]


On Nov 23, 2013, at 8:48 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> 	  (,(or parent 'kill-all-local-variables))   <<<<<<<<<
> [...]
>> Does anyone know why this is there?
> 
> Read the Elisp manual's description of what a major mode should do.
> Buffer-local variables are (in their majority) specific a particular
> major mode, hence they are reset when the major mode changes.

Ok.  Alex suggested a bug report.  I guess I will hold off on that.  I have it
written up ready to send.  Let me know if you would prefer it sent or not.

I got around the issue with:

(defadvice kill-all-local-variables (around inherit activate)
  "We want inherited variables to survive a call to this function"
  (let* ((set-list (mapcar (lambda ( v )
			     (cons v (symbol-value v)))
			   inherited-alist)))
    ad-do-it
    (mapcar (lambda ( c )
	      (set (car c) (cdr c)))
	    set-list)))

How about an extra blurb in the documentation for make-variable-buffer-local
(and / or) make-local-variable that notes that they are usually killed when
entering a new mode?  It was clear that someone was killing the variables
but it was hard for me to track down who it was.

Thank you again to all who helped me out.

Perry


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

  reply	other threads:[~2013-11-23 15:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22  2:45 Help needed with defadvice Perry Smith
2013-11-22  6:27 ` Eric Abrahamsen
2013-11-22  7:09 ` Alex Kost
2013-11-22 15:50   ` Perry Smith
2013-11-22 21:56     ` Alex Kost
2013-11-23  1:41       ` Perry Smith
2013-11-23  7:00         ` Alex Kost
2013-11-23 14:48         ` Stefan Monnier
2013-11-23 15:22           ` Perry Smith [this message]
2013-11-23 15:38             ` Stefan Monnier
2013-11-23 16:24               ` Perry Smith
2013-11-24 18:21                 ` Stefan Monnier
2013-11-23 15:43           ` Alex Kost
     [not found]   ` <mailman.6834.1385135422.10748.help-gnu-emacs@gnu.org>
2013-11-23  8:35     ` jack-mac
2013-11-22 14:44 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6F68AA38-BFEF-4B6B-BE9B-105A22359891@gmail.com \
    --to=pedzsan@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).