From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: "Stefan Monnier <foo@acm.com>" <monnier+gnu.emacs.help/news/@flint.cs.yale.edu>
Newsgroups: gmane.emacs.help
Subject: Re: update date in diary
Date: 16 Sep 2002 09:38:27 -0400
Organization: Yale University
Sender: help-gnu-emacs-admin@gnu.org
Message-ID: <5l1y7uqcks.fsf@rum.cs.yale.edu>
References: <mailman.1031939415.20318.help-gnu-emacs@gnu.org> <3D82F1B2.8020505@fit-zones.NO-SPAM.com> <851y7wq7x9.fsf@emr.cs.iit.edu> <3D8499A8.5000007@fit-zones.NO-SPAM.com>
NNTP-Posting-Host: localhost.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1032184577 20706 127.0.0.1 (16 Sep 2002 13:56:17 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 16 Sep 2002 13:56:17 +0000 (UTC)
Return-path: <help-gnu-emacs-admin@gnu.org>
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 17qwMJ-0005Nq-00
	for <gnu-help-gnu-emacs@m.gmane.org>; Mon, 16 Sep 2002 15:56:16 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 17qwMY-0007lg-00; Mon, 16 Sep 2002 09:56:30 -0400
Original-Path: shelby.stanford.edu!nntp.stanford.edu!newsfeed.stanford.edu!logbridge.uoregon.edu!news.ycc.yale.edu!rum.cs.yale.edu!rum.cs.yale.edu
Original-Newsgroups: gnu.emacs.help
Original-Lines: 12
Original-NNTP-Posting-Host: rum.cs.yale.edu
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
X-Original-NNTP-Posting-Host: rum.cs.yale.edu
X-Original-Trace: 16 Sep 2002 09:38:27 -0400, rum.cs.yale.edu
Original-Xref: nntp.stanford.edu gnu.emacs.help:104942
Original-To: help-gnu-emacs@gnu.org
Errors-To: help-gnu-emacs-admin@gnu.org
X-BeenThere: help-gnu-emacs@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:help-gnu-emacs-request@gnu.org?subject=help>
List-Post: <mailto:help-gnu-emacs@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/help-gnu-emacs>,
	<mailto:help-gnu-emacs-request@gnu.org?subject=subscribe>
List-Id: Users list for the GNU Emacs text editor <help-gnu-emacs.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/help-gnu-emacs>,
	<mailto:help-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/help-gnu-emacs/>
Xref: main.gmane.org gmane.emacs.help:1497
X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:1497

> (defconst diary-display-hook 'fancy-diary-display)

- the value of `diary-display-hook' is clearly not meant to be cast in
  stone, so why do you declare it as a constant ?

- `defconst' and `defvar' should only be used to define the variable
  in its home package.  So `defconst' is wrong here.

- hooks should only be manipulated via add-hook/remove-hook.


        Stefan