unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Debugging SMIE for sh-script.el
Date: Mon, 6 Sep 2021 15:47:47 +0300	[thread overview]
Message-ID: <5542c259-2e3d-ce97-12ea-5e03d5c150a5@gmail.com> (raw)
In-Reply-To: <jwvsfyiab7d.fsf-monnier+emacs@gnu.org>

> indent the subsequent lines at a fixed offset from the first line
The key question here is how do we calculate that offset. Currently it 
is the offset to the start of the second token of the parent line. Kevin 
wants to change it, so that it would be the start of the first token of 
the parent non-continuation line + sh-basic-offset.

There are two sane ways of accomplishing that:

1. Implementing that logic inside sh-smie--indent-continuation. Just so 
we're clear, when I said "the default (smie-indent-calculation) cycle", 
I meant the default smie-indent-functions. There's generally no reason 
to introduce a new function (sh-smie--indent-continuation) into 
smie-indent-functions if the default ones are adequate for the 
job(indenting continuation lines), so that's why I've assumed that the 
default functions are not adequate for the general use case.

2. Getting rid of sh-smie--indent-continuation and implementing its 
logic and the new fixed logic within sh-smie-sh-rules. Maybe this can be 
done without opening any Pandora's boxes.




  reply	other threads:[~2021-09-06 12:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 10:49 Debugging SMIE for sh-script.el Kévin Le Gouguec
2021-09-02 12:07 ` Nikolay Kudryavtsev
2021-09-02 17:19   ` Kévin Le Gouguec
2021-09-02 18:09     ` Nikolay Kudryavtsev
2021-09-02 20:29       ` Kévin Le Gouguec
2021-09-02 19:50   ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-02 21:37     ` Kévin Le Gouguec
2021-09-02 23:54       ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-03  7:09         ` Kévin Le Gouguec
2021-09-03 12:12           ` Stefan Monnier
2021-09-05 15:48       ` Nikolay Kudryavtsev
2021-09-05 16:27         ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-05 16:41           ` Nikolay Kudryavtsev
2021-09-05 17:23             ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-05 18:01               ` Nikolay Kudryavtsev
2021-09-05 23:02                 ` Stefan Monnier
2021-09-06 12:47                   ` Nikolay Kudryavtsev [this message]
2021-09-06 14:01                     ` Stefan Monnier
2021-09-06 17:24                       ` Nikolay Kudryavtsev
2021-09-06 20:23                         ` Stefan Monnier
2021-09-12 17:40                         ` Kévin Le Gouguec
2021-09-02 19:47 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-02 20:39   ` Kévin Le Gouguec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5542c259-2e3d-ce97-12ea-5e03d5c150a5@gmail.com \
    --to=nikolay.kudryavtsev@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).