From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.help Subject: Re: xref in GNU ELPA broken on Emacs 26 Date: Tue, 19 Oct 2021 17:23:27 +0300 Message-ID: <52322bdc-ddea-2ca2-9391-dc58e42b57de@yandex.ru> References: <19d4409e-c0c5-06a9-ba43-a58d220ec5a2@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28926"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: Stefan Monnier , help-gnu-emacs@gnu.org, Yuri Khan Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 16:39:30 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcqH4-0007KL-QV for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 16:39:30 +0200 Original-Received: from localhost ([::1]:48244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcqH3-0001iT-Ro for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 10:39:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcq1c-0004MU-Tu for help-gnu-emacs@gnu.org; Tue, 19 Oct 2021 10:23:32 -0400 Original-Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:45820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcq1a-0001eQ-Qd for help-gnu-emacs@gnu.org; Tue, 19 Oct 2021 10:23:32 -0400 Original-Received: by mail-lj1-x236.google.com with SMTP id e19so6443163ljk.12 for ; Tue, 19 Oct 2021 07:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MR0KpdKBYrURCm7SvsDn8snmHpaaoncOd4+A9TlrMi0=; b=Xri+CrosD+xQOdDQNk13gS1jgdDNJ9Q8PKTbEASXHV/x5qTZQvsNgnzUBPuo4DK8bu JI70+b4HaeXSy28VAC+aaCf3fhgJvxqOm0qbD6p04MOR6hlFVNBkf5jzuIiBczqTheer iB1+sdTzxVwiJuy3O9O0XV8smqr/bsTTdbnXwzzkJhDS02jYW2aUKJyjO3G9Dq9EFio0 v+ICnlQg9okBzyPafBH1F5IKlYkTrTKzw3EhSosObUD7HMlHrSV4HlLhTEGh03jpxder BJRUqUeg1JGF8yqBql99JRNjqk+ukehl2kOVyHWCvaK2TPOBOm+icE9D+O2HhDP+/qdF MnWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MR0KpdKBYrURCm7SvsDn8snmHpaaoncOd4+A9TlrMi0=; b=Vle9SAeBleli//5qtDf6zKlBtPqNz1fl0CVfp1l1ceCwMhwMlHyPkvbXSy963CqfaF 863u1JcSrYht7fcffXFB9GtDjWC13yKWifV3maIcWtKdQNvvkFWiITqND7khdIGB+c6O NUZ1oOwGv+8fRvDTHSG639S1EzOVCfQRdAJKdazY4YBlf09yFpqPM4kJtogjo5x2eCOi Muf9QbZor3ByrzROGXrkvalQ6NExqGYR2FNfVL3ZCIV3n+LkWMHQEirdmQJH4TZqSd1w 22vXrdQrrw5d39VegQ2PRrLQZeukKPwn05Nv4IJYj+w39bX/4ROuDCk4VZb69GW4gc9f xY0w== X-Gm-Message-State: AOAM531uQ2W+qIHcVTUfkUbp+wj2Cit5lmlx1P8nnSWwujTlo/yVsumu l7PqkvsoGoaPC+CkiHesFQg= X-Google-Smtp-Source: ABdhPJzPUx5wR/tgEK0GpACMZxbJGeF0FqHCf2L3m7m9om5xGlcJhaAu3IDR4LIh/BiFRggq2bH7Zw== X-Received: by 2002:a2e:9cc9:: with SMTP id g9mr6703040ljj.57.1634653408887; Tue, 19 Oct 2021 07:23:28 -0700 (PDT) Original-Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id a5sm1777759lff.300.2021.10.19.07.23.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Oct 2021 07:23:28 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::236; envelope-from=raaahh@gmail.com; helo=mail-lj1-x236.google.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-2.074, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:133887 Archived-At: On 19.10.2021 16:27, Stefan Monnier via Users list for the GNU Emacs text editor wrote: > I suspect that you can get the same without `eval` with something like: > > (defmacro xref--defstruct (name &rest fields) > (declare (indent 1)) > `(cl-defstruct ,(if (>= 27 emacs-major-version) name > (remq (assq :noinline name) name)) > ,@fields)) > > (xref--defstruct (xref-item > (:noinline t) > (:constructor xref-make (summary location))) > "An xref item describes a reference to a location somewhere." > summary location) > > (xref--defstruct (xref-match-item > (:noinline t) > (:include xref-item) > (:constructor xref-make-match (summary location length))) > "A match xref item describes a search result." > length)))) Nice! Thanks, Stefan. Yuri, I'm going to push this change now (with a couple of tweaks), to get the fix out sooner. But let me know if the soon-to-be-released version 1.3.1 still has problems.