bs-show breaks and get confused about the minibuffer

bs-show breaks and get confused about the minibuffer

[Alex Bennee]

Hi,

I'm not sure what causes it but once it breaks it makes my current emacs
session very hard to use as I can't switch buffers. Basically once it
starts any attempt to execute:

(bs-show "all")

Causes emacs to complain that I "Cannot switch buffers in minibuffer
window" despite not being in the minibuffer. Has anyone ever come across
this sticky minibuffer behaviour and how to get out of it?

-- 
Alex Bennee, Software Engineer
Wow, I'm being shot at from both sides. That means I *must* be
right. :-) -- Larry Wall in <199710211959.MAA18990@wall.org>

Re: bs-show breaks and get confused about the minibuffer

[martin rudalics]

> I'm not sure what causes it but once it breaks it makes my current emacs
> session very hard to use as I can't switch buffers. Basically once it
> starts any attempt to execute:
>
> (bs-show "all")
>
> Causes emacs to complain that I "Cannot switch buffers in minibuffer
> window" despite not being in the minibuffer. Has anyone ever come across
> this sticky minibuffer behaviour and how to get out of it?

Good catch, I suppose.  I've eliminated this stuff in my Emacs for some
time.  Basically, the function no_switch_window defined in buffer.c has

if (EQ (minibuf_window, window))
     return "Cannot switch buffers in minibuffer window";

which prints the error message.  Surprisingly no_switch_window is called
by `switch-to-buffer' as

   err = no_switch_window (selected_window);
   if (err)
     /* If can't display in current window, let pop-to-buffer
        try some other window. */
     return call3 (intern ("pop-to-buffer"), buffer, Qnil, norecord);

so Emacs should ignore this but God knows what really happens.

Please file a bug report and we will (hopefully) take care of it.

martin

Re: bs-show breaks and get confused about the minibuffer

[Nikolaj Schumacher]

martin rudalics <rudalics@gmx.at> wrote:

>   err = no_switch_window (selected_window);
>   if (err)
>     /* If can't display in current window, let pop-to-buffer
>        try some other window. */
>     return call3 (intern ("pop-to-buffer"), buffer, Qnil, norecord);
>
> so Emacs should ignore this but God knows what really happens.

Hmm.  Doesn't `pop-to-buffer' use `display-buffer'?  Maybe the error is
caused in there.  My `display-buffer' starts like this:

(defun my-display-buffer (buffer &optional not-this-window)
  (if (minibufferp)
      (with-selected-window (minibuffer-selected-window)
        (my-display-buffer buffer nil))
    ...))

So it's conceivable I've worked around the same error, once.


regards,
Nikolaj Schumacher

Re: bs-show breaks and get confused about the minibuffer

[martin rudalics]

 >>   err = no_switch_window (selected_window);
 >>   if (err)
 >>     /* If can't display in current window, let pop-to-buffer
 >>        try some other window. */
 >>     return call3 (intern ("pop-to-buffer"), buffer, Qnil, norecord);
 >>
 >> so Emacs should ignore this but God knows what really happens.
 >
 > Hmm.  Doesn't `pop-to-buffer' use `display-buffer'?  Maybe the error is
 > caused in there.  My `display-buffer' starts like this:
 >
 > (defun my-display-buffer (buffer &optional not-this-window)
 >   (if (minibufferp)
 >       (with-selected-window (minibuffer-selected-window)
 >         (my-display-buffer buffer nil))
 >     ...))

Do you use this as `display-buffer-function'?

 > So it's conceivable I've worked around the same error, once.

Maybe.  I forgot that the C version of `display-buffer' used to call
no_switch_window.  Hence the error might result from there since
`bs-tmp-select-other-window' calls `display-buffer'.  With Emacs 23
no_switch_window is exclusively called by `switch-to-buffer' which is
still in C (I moved mine to Elisp and don't have no_switch_window any
more).

In any case signalling that bug in no_switch_window doesn't make sense
IMHO since thereafter `pop-to-buffer' is called anyway.

martin

Re: bs-show breaks and get confused about the minibuffer

[Nikolaj Schumacher]

martin rudalics <rudalics@gmx.at> wrote:

> Do you use this as `display-buffer-function'?

Yes, that's what I meant to type...


regards,
Nikolaj Schumacher

Re: bs-show breaks and get confused about the minibuffer

[martin rudalics]

 >> Do you use this as `display-buffer-function'?
 >
 > Yes, that's what I meant to type...

If you use Emacs 23 then please try without that workaround.  If, as a
consequence, you get an error let's try to fix it.

martin