From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.help Subject: Re: MY window tree! Date: Mon, 15 Jan 2007 21:26:47 +0100 Message-ID: <45ABE387.9010306@gmail.com> References: <45A8B034.8020301@gmx.at> <45AA17CE.9050009@gmail.com> <45AA6B59.30203@gmx.at> <45AAA21C.6090505@gmail.com> <45AAB98F.8060404@gmail.com> <45AB2CDB.1040207@gmx.at> <45AB7C99.6050002@gmail.com> <45AB8B1F.7010408@gmail.com> <45AB92A8.7030300@gmail.com> <45ABB942.9070407@gmx.at> <45ABC474.3010208@gmail.com> <45ABD474.9040206@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1168894282 10185 80.91.229.12 (15 Jan 2007 20:51:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 15 Jan 2007 20:51:22 +0000 (UTC) Cc: help-gnu-emacs@gnu.org, michael@cadilhac.name Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Jan 15 21:51:17 2007 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H6YQO-0002Ut-0h for geh-help-gnu-emacs@m.gmane.org; Mon, 15 Jan 2007 21:27:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H6YQN-00020D-Qb for geh-help-gnu-emacs@m.gmane.org; Mon, 15 Jan 2007 15:27:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H6YPn-0001d5-Ef for help-gnu-emacs@gnu.org; Mon, 15 Jan 2007 15:26:47 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H6YPl-0001cO-Pl for help-gnu-emacs@gnu.org; Mon, 15 Jan 2007 15:26:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H6YPl-0001cH-LW for help-gnu-emacs@gnu.org; Mon, 15 Jan 2007 15:26:45 -0500 Original-Received: from [80.76.149.212] (helo=ch-smtp01.sth.basefarm.net) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1H6YPl-0005V2-2U for help-gnu-emacs@gnu.org; Mon, 15 Jan 2007 15:26:45 -0500 Original-Received: from c83-254-145-24.bredband.comhem.se ([83.254.145.24]:62217 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.63) (envelope-from ) id 1H6YPi-00056r-6P; Mon, 15 Jan 2007 21:26:43 +0100 User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) Original-To: martin rudalics In-Reply-To: <45ABD474.9040206@gmx.at> X-Antivirus: avast! (VPS 0703-1, 2007-01-15), Outbound message X-Antivirus-Status: Clean X-Scan-Result: No virus found in message 1H6YPi-00056r-6P. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1H6YPi-00056r-6P 1ef5bcd56652dc71e7683f7746e70da1 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:40335 Archived-At: martin rudalics wrote: > > I have tried to add the hooks on reasonable places. I would be glad for > > some comments on that. > > `winsav-after-get' and `winsav-after-put' should be defvard and the args > documented. I'd also rename them to `before-winsav-functions' and > `after-winsav-functions' (compare `before-revert-hook' and > `after-revert-hook'), Juanma knows the naming conventions better. Thanks. I think hooks ending in "-hook" by convention is called with no arguments. "-hooks" seems good here. I like to have the library name in the beginning of the name. I have changed the names and defvared them. > But I notice that you still make overlays. I thought we convinced you > they are not needed. Believe me: The only case you should care about is > when an overlay has a 'window property referencing a window that has an > ovlwin-window association. Investigating _all_ overlays in _all_ live > buffers is overkill and would make this very slow. No, you have not convinced me - I do not believe we have disagreed ;-) In the normal use case no overlays should be made (see the beginning of the file). However I think my check for if the old window is still a window on a frame was wrong. I checked only window-live-p. I have added a check of window-frame now. But I do not understand what you and Juanma tries to say. Is there perhaps another way to find the overlays than using overlays-in? I am not aware of any other way, but perhaps you are? If not so, then do I not have to look at all overlays in all buffers? I do not know if this is actually a problem, but if it is then it is a good point in favor for a solution in C. However I do not expect the functions in winsav.el to be called very frequently.