From: "Jérôme Haguet" <jeje66@despammed.com>
Subject: Re: [PCL-CVS] Interactive diff on a utf-8 encoded file
Date: Thu, 11 Sep 2003 09:54:31 +0200 [thread overview]
Message-ID: <3f6029e4$0$13274$626a54ce@news.free.fr> (raw)
In-Reply-To: 3F5F9F54.4080401@yahoo.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3407 bytes --]
Just a last remark :
I had to modify
> (t (find-operation-coding-system
> 'insert-file-contents
> file)))))
to
< (t (car (find-operation-coding-system
< 'insert-file-contents
< file))))))
to make it work ...
Jérôme
"Kevin Rodgers" <ihs_4664@yahoo.com> a écrit dans le message de
news:3F5F9F54.4080401@yahoo.com...
> [Followup-To: gnu.emacs.bug]
>
> Jérôme Haguet wrote:
>
> > Hello
> > It does not seems to work.
> > The following line
> > (cvs-coding-system buffer-file-coding-system)
> > return the coding-system of *cvs* buffer.
>
>
> Yes, I was afraid it might.
>
>
> > I replace it with
> > (cvs-coding-system (find-operation-coding-system 'insert-file-contents
> > file)))
> > and it give me so far a good result ...
>
>
> Great!
>
> > But I do not know if it is the correct way to do it.
>
>
> I think it might be more reliable to use buffer-file-coding-system if
> the file is being visited in a buffer (which it ought to be), and only
> fall back on find-operation-coding-system otherwise. Also, that
> function may return "a coding system, a cons of coding systems, or a
> function symbol to call".
>
> So I went looking through the sources to see how it's result is used.
> Unfortunately, it's not very consistent, but there's a great example
> for us to follow (which supports both points above):
vc-coding-system-for-diff
>
> Here's my latest version, based on that:
>
>
> (defun cvs-retrieve-revision (fileinfo rev)
> "Retrieve the given REVision of the file in FILEINFO into a new buffer."
> (let* ((file (cvs-fileinfo->full-path fileinfo))
> (rev-file (concat file "." rev)))
> (or (find-buffer-visiting rev-file)
> (let* ((buffer (find-buffer-visiting file))
> (coding-system (cond ((eq buffer (current-buffer))
> buffer-file-coding-system)
> (buffer (with-current-buffer buffer
> buffer-file-coding-system))
> (t (find-operation-coding-system
> 'insert-file-contents
> file)))))
> (with-current-buffer (create-file-buffer rev-file)
> (message "Retrieving revision %s..." rev)
> (let* ((coding-system-for-read coding-system)
> (res (call-process cvs-program nil t nil
> "-q" "update" "-p" "-r" rev file)))
> (when (and res (not (and (equal 0 res))))
> (error "Something went wrong retrieving revision %s: %s"
> rev res))
> (set-buffer-modified-p nil)
> (let ((buffer-file-name (expand-file-name file)))
> (after-find-file))
> (toggle-read-only 1)
> (message "Retrieving revision %s... Done" rev)
> (current-buffer)))))))
>
> > Last detail, the coding-system is still not correctly displayed at the
> > lower-left corner of the window.
>
> Hmmm, I'll forward that to gnu.emacs.bug along with our
cvs-retrieve-revision.
>
> --
> Kevin Rodgers
>
prev parent reply other threads:[~2003-09-11 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-09 16:37 [PCL-CVS] Interactive diff on a utf-8 encoded file Jérôme Haguet
2003-09-09 17:56 ` Kevin Rodgers
2003-09-09 18:55 ` Kevin Rodgers
2003-09-10 8:22 ` Jérôme Haguet
2003-09-10 22:01 ` Kevin Rodgers
2003-09-11 7:54 ` Jérôme Haguet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='3f6029e4$0$13274$626a54ce@news.free.fr' \
--to=jeje66@despammed.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).