From: Ergus <spacibba@aol.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: help-gnu-emacs@gnu.org
Subject: Re: New line and trailing whitespaces
Date: Wed, 24 Apr 2024 16:48:06 +0200 [thread overview]
Message-ID: <3akqf6us7npz7vrsfqd3aiic5w2ubfad7ugpgwq5nsc7lqwhao@2thip6bzmera> (raw)
In-Reply-To: <86v8472qb0.fsf@gnu.org>
On Wed, Apr 24, 2024 at 10:05:55AM GMT, Eli Zaretskii wrote:
>> Date: Wed, 24 Apr 2024 04:41:26 +0200
>> From: Ergus <spacibba@aol.com>
>> Cc: help-gnu-emacs@gnu.org
>>
>> I tried this.
>>
>> (with-eval-after-load 'whitespace
>> (setq whitespace-style '(faces tab-mark)
>> whitespace-display-mappings `((tab-mark ?\t [,(make-glyph-code ?� 'whitespace-tab) ?\t] ))
>> ))
>> (whitespace-mode 1)
>>
>> But I only get the error:
>>
>> wrong-type-argument number-or-marker-p (187 . 235)
>>
>> Some idea what I am doing wrong?
>
>It's a bug in whitespace.el, which I just fixed on the master branch:
>it didn't work correctly with glyph codes. You seem to have a lot of
>faces defined (more than 64 of them), so you bumped into this corner
>case.
>
Thank you very much. It works now. I don't actually add any new face if
they exist is because the were added by packages.
About the user friendly interface you mentioned previously.
I may be wrong, but I think it doesn't need a new face and custom
option, we just need to use the same whitespace-tab face for
tab-mark. It will be more coherent because the tabs (space highlight)
only uses the :background and the tab-mark will use only the
:foreground. Simpler and with all the flexibility. WDYT?
Thanks again,
Best,
Ergus
next prev parent reply other threads:[~2024-04-24 14:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <kcaicxrup2f3usy37v4aupgu7uvmifnxkeyc2hx5n5qpqnuj7b.ref@okar6momrmhs>
2024-04-20 12:10 ` New line and trailing whitespaces Ergus
2024-04-20 13:50 ` Eli Zaretskii
2024-04-20 14:16 ` Eli Zaretskii
2024-04-21 1:12 ` Ergus
2024-04-21 5:23 ` Eli Zaretskii
2024-04-21 21:05 ` Ergus
2024-04-22 5:39 ` Eli Zaretskii
2024-04-22 12:22 ` Ergus
2024-04-23 8:06 ` Eli Zaretskii
2024-04-23 15:38 ` Ergus
2024-04-23 16:19 ` Eli Zaretskii
2024-04-24 2:41 ` Ergus
2024-04-24 7:05 ` Eli Zaretskii
2024-04-24 14:48 ` Ergus [this message]
2024-04-24 15:45 ` Eli Zaretskii
2024-04-22 12:34 ` Ergus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3akqf6us7npz7vrsfqd3aiic5w2ubfad7ugpgwq5nsc7lqwhao@2thip6bzmera \
--to=spacibba@aol.com \
--cc=eliz@gnu.org \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).