From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.help Subject: Re: [PCL-CVS] Interactive diff on a utf-8 encoded file Date: Tue, 09 Sep 2003 12:55:57 -0600 Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Message-ID: <3F5E223D.6020108@yahoo.com> References: <3f5e0162$0$20183$626a54ce@news.free.fr> <3F5E1438.8060804@yahoo.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1063135412 24971 80.91.224.253 (9 Sep 2003 19:23:32 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Sep 2003 19:23:32 +0000 (UTC) Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Sep 09 21:23:30 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19wo5K-0006Xf-00 for ; Tue, 09 Sep 2003 21:23:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.22) id 19wo1l-0003jv-Es for geh-help-gnu-emacs@m.gmane.org; Tue, 09 Sep 2003 15:19:49 -0400 Original-Path: shelby.stanford.edu!newsfeed.stanford.edu!headwall.stanford.edu!fu-berlin.de!uni-berlin.de!170.207.51.80!not-for-mail Original-Newsgroups: gnu.emacs.help Original-Lines: 57 Original-NNTP-Posting-Host: 170.207.51.80 Original-X-Trace: news.uni-berlin.de 1063133754 21363769 170.207.51.80 (16 [82742]) User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:0.9.4.1) Gecko/20020406 Netscape6/6.2.2 X-Accept-Language: en-us Original-Xref: shelby.stanford.edu gnu.emacs.help:116481 Original-To: help-gnu-emacs@gnu.org X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.help:12401 X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:12401 Kevin Rodgers wrote: > From pcvs.el: > > > ;;; Bugs: > > ;; - Extracting an old version seems not to recognize encoding correctly. > ;; That's probably because it's done via a process rather than a file. > > > > Any idea how to fix this ? > > Maybe cvs-retrieve-revision can be hacked. Does this *untested* patch > work? Here's a better patch, that tries to take into account the fact that buffer-file-coding-system is buffer local: *** emacs-21.3/lisp/pcvs.el.orig Sat Sep 22 14:23:16 2001 --- emacs-21.3/lisp/pcvs.el Tue Sep 9 12:54:51 2003 *************** *** 1515,1526 **** (defun cvs-retrieve-revision (fileinfo rev) "Retrieve the given REVision of the file in FILEINFO into a new buffer." (let* ((file (cvs-fileinfo->full-path fileinfo)) ! (buffile (concat file "." rev))) (or (find-buffer-visiting buffile) (with-current-buffer (create-file-buffer buffile) (message "Retrieving revision %s..." rev) ! (let ((res (call-process cvs-program nil t nil ! "-q" "update" "-p" "-r" rev file))) (when (and res (not (and (equal 0 res)))) (error "Something went wrong retrieving revision %s: %s" rev res)) (set-buffer-modified-p nil) --- 1515,1529 ---- (defun cvs-retrieve-revision (fileinfo rev) "Retrieve the given REVision of the file in FILEINFO into a new buffer." (let* ((file (cvs-fileinfo->full-path fileinfo)) ! (buffile (concat file "." rev)) ! (cvs-coding-system buffer-file-coding-system)) (or (find-buffer-visiting buffile) (with-current-buffer (create-file-buffer buffile) (message "Retrieving revision %s..." rev) ! (let* ((process-coding-system-alist ! (list (cons (regexp-quote cvs-program) cvs-coding-system))) ! (res (call-process cvs-program nil t nil ! "-q" "update" "-p" "-r" rev file))) (when (and res (not (and (equal 0 res)))) (error "Something went wrong retrieving revision %s: %s" rev res)) (set-buffer-modified-p nil) -- Kevin Rodgers