Best practice for overriding keybinding of a minor mode?

Best practice for overriding keybinding of a minor mode?

[Stefan Kamphausen]

Dear all,

whenever you use a minor mode it may come with its own set of
keybinding.  Just as an example take the keymap of the fine
flyspell-mode.  It binds C-. and C-, which I find particularly annoying
since I got those bound to some personal functions globally for years.  

Now, my question is: what is the best/most effective/easiest/suggested
way to remove those bindings?  Shall I re-create that keymap after
loading flyspell?  Or override those binding explicitly in all hooks
where I enable flyspell (mainly nxml and message-mode, that is)?

How would you do this?

Kind regards,
Stefan
-- 
Stefan Kamphausen --- http://www.skamphausen.de
a blessed +42 regexp of confusion (weapon in hand)
You hit. The format string crumbles and turns to dust.

Re: Best practice for overriding keybinding of a minor mode?

[Pascal J. Bourguignon]

Stefan Kamphausen <skampi@gmx.net> writes:

> Dear all,
>
> whenever you use a minor mode it may come with its own set of
> keybinding.  Just as an example take the keymap of the fine
> flyspell-mode.  It binds C-. and C-, which I find particularly annoying
> since I got those bound to some personal functions globally for years.  
>
> Now, my question is: what is the best/most effective/easiest/suggested
> way to remove those bindings?  Shall I re-create that keymap after
> loading flyspell?  Or override those binding explicitly in all hooks
> where I enable flyspell (mainly nxml and message-mode, that is)?
>
> How would you do this?

There should be a hook run when the minor mode is activated.  You can
put there a function to reinstall your bindings.

In the case of flyspell-mode there is no hook, so you would have to
define an advice on flyspell-mode itself.


-- 
__Pascal Bourguignon__

Re: Best practice for overriding keybinding of a minor mode?

[Tassilo Horn]

pjb@informatimago.com (Pascal J. Bourguignon) writes:

Hi!

> In the case of flyspell-mode there is no hook, so you would have to
> define an advice on flyspell-mode itself.

Or simply add your bindings to the mode-map.

--8<---------------cut here---------------start------------->8---
;; Unset the default keys
(define-key flyspell-mode-map (kbd "C-.") nil)
(define-key flyspell-mode-map (kbd "C-,") nil)
;; Add the commands to new keys
(define-key flyspell-mode-map (kbd "C-c f .")
            'flyspell-goto-next-error)
(define-key flyspell-mode-map (kbd "C-c f ,")
            'flyspell-auto-correct-word)
--8<---------------cut here---------------end--------------->8---

Bye,
Tassilo

Re: Best practice for overriding keybinding of a minor mode?

[Samuel Wales]

local-unset-key

-- 
Myalgic encephalomyelitis causes death (Jason et al. 2006)
and severe suffering.  Conflicts of interest are destroying
research.  What people "know" is wrong.  Silence = death.
http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

Re: Best practice for overriding keybinding of a minor mode?

[jpkotta]

On Sep 28, 4:54 pm, Samuel Wales <samolog...@gmail.com> wrote:
> local-unset-key
>
> --
> Myalgic encephalomyelitis causes death (Jason et al. 2006)
> and severe suffering.  Conflicts of interest are destroying
> research.  What people "know" is wrong.  Silence = death.http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

I hope I'm not hijacking this thread, but I want to do the same thing
for ido.  I recently started using it and I don't like how C-
<backspace> works when completing files and directories.  I tried to
set the keybind via local-set-key, define-key (on ido-competion-map),
and local-unset-key; I used these methods after loading ido and in ido-
setup-hook.  Nothing worked.  Then I looked at ido.el and saw that it
does [remap backward-kill-word], which is what I have C-<backspace>
bound to globally.  After reading the manual, it seems like there is
no way to recover a remapped command.  Is this true or am I
overlooking something?  Is ido being heavy-handed here, and should not
be using remap?

Thanks,

jpkotta

Re: Best practice for overriding keybinding of a minor mode?

[Andreas Politz]

jpkotta <jpkotta@gmail.com> writes:

> On Sep 28, 4:54 pm, Samuel Wales <samolog...@gmail.com> wrote:
>> local-unset-key
>>
>> --
>> Myalgic encephalomyelitis causes death (Jason et al. 2006)
>> and severe suffering.  Conflicts of interest are destroying
>> research.  What people "know" is wrong.  Silence = death.http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm
[...]
> After reading the manual, it seems like there is
> no way to recover a remapped command.  Is this true or am I
> overlooking something?  Is ido being heavy-handed here, and should not
> be using remap?
>
(define-key keymap [remap command-name] nil)

or

(define-key keymap [remap command-name] command-name)

Both seem to do the trick.

-ap

> Thanks,
>
> jpkotta

Re: Best practice for overriding keybinding of a minor mode?

[jpkotta]

On Sep 30, 4:42 pm, Andreas Politz <poli...@fh-trier.de> wrote:
> jpkotta <jpko...@gmail.com> writes:
> > On Sep 28, 4:54 pm, Samuel Wales <samolog...@gmail.com> wrote:
> >> local-unset-key
>
> >> --
> >> Myalgic encephalomyelitis causes death (Jason et al. 2006)
> >> and severe suffering.  Conflicts of interest are destroying
> >> research.  What people "know" is wrong.  Silence = death.http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm
> [...]
> > After reading the manual, it seems like there is
> > no way to recover a remapped command.  Is this true or am I
> > overlooking something?  Is ido being heavy-handed here, and should not
> > be using remap?
>
> (define-key keymap [remap command-name] nil)
>
> or
>
> (define-key keymap [remap command-name] command-name)
>
> Both seem to do the trick.
>

Thanks, I needed to remap to nil _and_ redefine the key.