unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: "James K. Lowden" <jklowden@speakeasy.net>
To: help-gnu-emacs@gnu.org
Subject: Re: critique: my-first-function
Date: Tue, 14 Jun 2016 21:47:34 -0400	[thread overview]
Message-ID: <20160614214734.128b4c55eaf6b66a7b3ef537@speakeasy.net> (raw)
In-Reply-To: mailman.1403.1465780144.1216.help-gnu-emacs@gnu.org

On Mon, 13 Jun 2016 03:08:47 +0200
Emanuel Berg <embe8573@student.uu.se> wrote:

My thanks to both you and Stefan.  

> `let' should be `let*' since "frame-parameters"
> are used inside the same `let'.

It's a good thing you mentioned that!  The next morning, I had to
restart emacs (because ssh mumble something timeout) and my function
failed.  It had worked the day before because 

>   (let ( (frame-parameters 

frame-parameters happened to have been defined globally during
testing.  Adding the "*" fixed it instantly.  

Is the "*" a convention of some kind that I should be aware of?  

> Instead of "frame1" "frame2", name them after
> some property.

Well, one day the whole thing will be a recursive call over a list of
coordinates.  The frames don't deserve names, but I couldn't see my way
to creating the list.  

Thanks again.  

--jkl


  parent reply	other threads:[~2016-06-15  1:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12 22:39 critique: my-first-function James K. Lowden
2016-06-13  1:04 ` Stefan Monnier
2016-06-13  1:08 ` Emanuel Berg
     [not found] ` <mailman.1403.1465780144.1216.help-gnu-emacs@gnu.org>
2016-06-15  1:47   ` James K. Lowden [this message]
2016-06-15  4:43     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160614214734.128b4c55eaf6b66a7b3ef537@speakeasy.net \
    --to=jklowden@speakeasy.net \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).