unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: "Ernest Adrogué" <nfdisco@gmail.com>
To: help-gnu-emacs@gnu.org
Subject: Re: python-shell-send-region uses wrong encoding?
Date: Thu, 31 Oct 2013 15:30:12 +0100	[thread overview]
Message-ID: <20131031143012.GA4300@doriath.local> (raw)
In-Reply-To: <jwvtxfzvvqw.fsf-monnier+gmane.emacs.help@gnu.org>

30-10-2013, 07:37 (-0400); Stefan Monnier escriu:
> This function is used to send a string (typically extracted from the
> region) not a file, so the offsets have always been wrong anyway (except
> when the region happens to start on the first line).

The line number is right, because the temp file is filled with empty lines
so that the line numbers match.  Because of the extra line, it's one line
off. This fixes it:

--- python.el.orig   2013-10-31 15:21:26.000000000 +0100
+++ python.el	     2013-10-31 15:19:03.673891453 +0100
@@ -2154,7 +2146,7 @@
   3. Wraps indented regions under an \"if True:\" block so the
      interpreter evaluates them correctly."
   (let ((substring (buffer-substring-no-properties start end))
-        (fillstr (make-string (1- (line-number-at-pos start)) ?\n))
+        (fillstr (make-string (- (line-number-at-pos start) 2) ?\n))
         (toplevel-block-p (save-excursion
                             (goto-char start)
                             (or (zerop (line-number-at-pos start))




  parent reply	other threads:[~2013-10-31 14:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 11:30 python-shell-send-region uses wrong encoding? Ernest Adrogué
2013-10-29 14:24 ` Drew Adams
2013-10-29 14:37   ` Ernest Adrogué
2013-10-29 16:00     ` Drew Adams
2013-10-29 16:54       ` Ernest Adrogué
2013-10-29 17:11       ` Eli Zaretskii
2013-10-29 14:26 ` Andreas Röhler
2013-10-29 14:55   ` Ernest Adrogué
2013-10-29 15:29     ` Andreas Röhler
2013-10-29 15:34     ` Peter Dyballa
2013-10-29 16:34       ` Ernest Adrogué
2013-10-29 17:15         ` Eli Zaretskii
2013-10-29 17:53           ` Ernest Adrogué
2013-10-29 19:10             ` Eli Zaretskii
2013-10-29 20:48               ` Ernest Adrogué
2013-10-29 18:07         ` Peter Dyballa
2013-10-29 20:37           ` Ernest Adrogué
2013-10-29 17:28 ` Stefan Monnier
2013-10-30  3:20   ` Stefan Monnier
2013-10-30  6:45     ` Andreas Röhler
2013-10-30 11:37       ` Stefan Monnier
2013-10-30 12:08         ` Yuri Khan
2013-10-30 12:45           ` Andreas Röhler
2013-10-31 14:30         ` Ernest Adrogué [this message]
2013-10-31 14:31     ` Ernest Adrogué
2013-10-31 17:54     ` Ernest Adrogué
2013-10-31 20:35       ` Stefan Monnier
2013-11-04 19:15       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131031143012.GA4300@doriath.local \
    --to=nfdisco@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).