From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.help Subject: Re: defmacro is worse than my neighbours cat Date: Fri, 12 Sep 2008 23:10:49 +0000 Message-ID: <20080912231049.GB1075@muc.de> References: <48CADB66.3030807@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1221260771 25333 80.91.229.12 (12 Sep 2008 23:06:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Sep 2008 23:06:11 +0000 (UTC) Cc: "help-gnu-emacs@gnu.org" To: "Lennart Borgman \(gmail\)" Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sat Sep 13 01:07:07 2008 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KeHjA-0007A4-Pv for geh-help-gnu-emacs@m.gmane.org; Sat, 13 Sep 2008 01:07:01 +0200 Original-Received: from localhost ([127.0.0.1]:55736 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KeHiA-00040s-8e for geh-help-gnu-emacs@m.gmane.org; Fri, 12 Sep 2008 19:05:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KeHhq-00040n-Vr for help-gnu-emacs@gnu.org; Fri, 12 Sep 2008 19:05:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KeHho-00040b-Hu for help-gnu-emacs@gnu.org; Fri, 12 Sep 2008 19:05:37 -0400 Original-Received: from [199.232.76.173] (port=59743 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KeHho-00040Y-Ca for help-gnu-emacs@gnu.org; Fri, 12 Sep 2008 19:05:36 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:2755 helo=mail.muc.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KeHhn-0002Kf-Md for help-gnu-emacs@gnu.org; Fri, 12 Sep 2008 19:05:36 -0400 Original-Received: (qmail 50663 invoked by uid 3782); 12 Sep 2008 23:05:30 -0000 Original-Received: from acm.muc.de (pD9E50E64.dip.t-dialin.net [217.229.14.100]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Sat, 13 Sep 2008 01:05:28 +0200 Original-Received: (qmail 2452 invoked by uid 1000); 12 Sep 2008 23:10:49 -0000 Content-Disposition: inline In-Reply-To: <48CADB66.3030807@gmail.com> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) X-Primary-Address: acm@muc.de X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:57501 Archived-At: 'Morning, Lennart! On Fri, Sep 12, 2008 at 11:13:10PM +0200, Lennart Borgman (gmail) wrote: > defmacro is worse than my neighbour's cat. Miaow!!! > When I think I everything is fine and I calm down they bite. > I have a defmacro where I define a function and I want to build the doc > string for this function in a certain way. This works fine - until I > byte compile it. Can someone please try to explain to me how I can do > what I want? > Below is the defmacro. Look for "fix-me". > (defmacro define-mumamo-multi-major-mode (fun-sym spec-doc chunks) > "Define a function that turn on support for multiple major modes." > (let* ((mumamo-describe-chunks (make-symbol "mumamo-describe-chunks")) OK, here's a problem. You have _two_ symbols called "mumamo-describe-chunks" here. One (uninterned) is the value of the other. Why do this? Why not just declare the symbol directly inside the let* form and use it? You really don't need to use make-symbol at all, unless you deliberately want it uninterned, or you're making up the name as you go along. You can simply write (let* mumamo-describe-chunks > (turn-on-fun (if (symbolp fun-sym) > (symbol-value > (intern > (symbol-name (quote fun-sym)))) This bit seems crazy. (symbol-name (quote fun-sym)) is easier to read as (symbol-name 'fun-sym) which is "fun-sym". You then "intern" it (i.e. get the (existing) 'fun-sym) and then take the value of 'fun-sym with `symbol-value'. You don't need this. You know that (the value of) fun-sym is a symbol, so these three lines are entirely equivalent to fun-sym . ;-) > (error "Parameter FUN-SYM must be a symbol"))) > (turn-on-fun-alias (intern > (concat "mumamo-alias-" > (symbol-name > (symbol-value > (intern > (symbol-name (quote fun-sym)))))))) Here you've got one sensible use of intern, and one silly one. This should just say: (turn-on-fun-alias (intern (concat "mumamo-alias-" fun-sym))) . At least I think it should - it's a bit early at the moment. ;-) I've got to get to bed, so I can't look at the rest right now. > (turn-on-hook (intern (concat (symbol-name turn-on-fun) "-hook"))) > (turn-on-map (intern (concat (symbol-name turn-on-fun) "-map"))) > (turn-on-hook-doc (concat "Hook run at the very end of `" > (symbol-name turn-on-fun) "'.")) > (chunks2 (if (symbolp chunks) > (symbol-value chunks) > chunks)) > (docstring > (concat > spec-doc > " > This function is called a multi major mode. The main use for it > is in `auto-mode-alist' to have Emacs do this setup whenever you > open a file named in a certain way. \(You can of course call > this function directly yourself too.) > It sets up for multiple mode in the following way: > " > ;; Fix-me: During byte compilation the next line is not > ;; expanded as I thought because the functions in CHUNK is > ;; not defined. How do I fix this? > (funcall 'mumamo-describe-chunks chunks2) > " > At the very end this multi major mode function runs first the hook > `mumamo-turn-on-hook' and then `" (symbol-name turn-on-hook) "'. > There is a keymap specific to this multi major mode, but it is > not returned by `current-local-map' which returns the chunk's > major mode's local keymap. > The keymap is named `" (symbol-name turn-on-map) "'. > This major mode has an alias `mumamo-alias-" > (symbol-name turn-on-fun) "'. > For more information see `define-mumamo-multi-major-mode'." > ))) > `(progn > (add-to-list 'mumamo-defined-turn-on-functions (cons (car > ',chunks2) ',turn-on-fun)) > (defvar ,turn-on-hook nil ,turn-on-hook-doc) > (defvar ,turn-on-map (make-sparse-keymap) > ,(concat "Keymap for multi major mode function `" > (symbol-name turn-on-fun) "'")) > (defvar ,turn-on-fun nil) > (make-variable-buffer-local ',turn-on-fun) > (put ',turn-on-fun 'permanent-local t) > (defun ,turn-on-fun nil ,docstring > (interactive) > (let ((old-major-mode (or mumamo-major-mode > major-mode))) > (kill-all-local-variables) > (run-hooks 'change-major-mode-hook) > (setq mumamo-multi-major-mode ',turn-on-fun) > (setq ,turn-on-fun t) > (mumamo-add-multi-keymap ',turn-on-fun ,turn-on-map) > (setq mumamo-current-chunk-family (copy-tree ',chunks2)) > (mumamo-turn-on-actions old-major-mode) > (run-hooks ',turn-on-hook))) > (defalias ',turn-on-fun-alias ',turn-on-fun) > ))) -- Alan Mackenzie (Nuremberg, Germany).