unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Sebastian Wiesner <swiesner@lunaryorn.com>
To: help-gnu-emacs@gnu.org
Cc: Michael Heerdegen <michael_heerdegen@web.de>
Subject: Re: Menu on minor mode lighter
Date: Mon, 04 Aug 2014 08:54:15 +0200	[thread overview]
Message-ID: <1941405.TxWBKa76P1@lunaryorn> (raw)
In-Reply-To: <87r40xa228.fsf@web.de>

Am Sonntag, 3. August 2014, 19:57:35 schrieb Michael Heerdegen:
> Sebastian Wiesner <swiesner@lunaryorn.com> writes:
> > So how do I do that?  How do I “define a menu for a minor mode”?
> 
> As you like, e.g. with "easymenu".  Here is an example of how you could
> do it:
> 
> --8<---------------cut here---------------start------------->8---
> (require 'easymenu)
> 
> (defvar my-mode-line-menus '()
>   "My alist of menus for the mode-line.")
> 
> (defun my-add-menu-to-mode-line (mode menu)
>   "Add MENU as mode-line indicator menu for MODE."
>   (unless (assoc mode my-mode-line-menus)
>     (push (cons mode menu)
>           my-mode-line-menus)))
> 
> (defadvice minor-mode-menu-from-indicator
>            (around add-my-stuff activate)
>   (let* ((mode (lookup-minor-mode-from-indicator (ad-get-arg 0)))
>          (my-menu (cdr (assoc mode my-mode-line-menus))))
>     (if my-menu
>         (popup-menu my-menu)
>       ad-do-it)))
> 
> 
> ;; Example: add menu for ispell
> 
> (my-add-menu-to-mode-line
>  'ispell-minor-mode
>  (easy-menu-create-menu
>   "Ispell"
>   '(["Spell word"   ispell-word]
>     ["Spell buffer" ispell-buffer])))
> --8<---------------cut here---------------end--------------->8---
> 
> Does that do what you want?

Yes, it looks like it, but I'd rather go without an advice.  This feature 
isn't intended for my own customization, but rather for a package that I 
maintain (see [1]), and I am under the impression that advices in packages are 
really bad style.

Couldn't I just add my own menu to the 'local-map property of the mode line 
lighter text?

[1]: https://github.com/flycheck/flycheck/issues/365



  reply	other threads:[~2014-08-04  6:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 16:09 Menu on minor mode lighter Sebastian Wiesner
2014-08-01 17:18 ` Michael Heerdegen
2014-08-02 13:12   ` Sebastian Wiesner
2014-08-02 13:42     ` Sebastian Wiesner
2014-08-03 17:57     ` Michael Heerdegen
2014-08-04  6:54       ` Sebastian Wiesner [this message]
2014-08-04 13:52         ` Michael Heerdegen
2014-08-07 11:11           ` Sebastian Wiesner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1941405.TxWBKa76P1@lunaryorn \
    --to=swiesner@lunaryorn.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).