From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.help Subject: Re: image-dired shows images as text Date: Fri, 28 Dec 2007 21:15:24 +1300 Message-ID: <18292.45212.36619.850080@kahikatea.snap.net.nz> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1198829788 20209 80.91.229.12 (28 Dec 2007 08:16:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Dec 2007 08:16:28 +0000 (UTC) Cc: help-gnu-emacs@gnu.org To: Allan Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Dec 28 09:16:42 2007 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J8AOX-0004dc-DI for geh-help-gnu-emacs@m.gmane.org; Fri, 28 Dec 2007 09:16:41 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J8AOC-0006Iy-2f for geh-help-gnu-emacs@m.gmane.org; Fri, 28 Dec 2007 03:16:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J8ANk-0006I5-Q2 for help-gnu-emacs@gnu.org; Fri, 28 Dec 2007 03:15:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J8ANi-0006GZ-Fs for help-gnu-emacs@gnu.org; Fri, 28 Dec 2007 03:15:51 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J8ANi-0006GP-3L for help-gnu-emacs@gnu.org; Fri, 28 Dec 2007 03:15:50 -0500 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J8ANh-0008RK-Dl for help-gnu-emacs@gnu.org; Fri, 28 Dec 2007 03:15:49 -0500 Original-Received: from kahikatea.snap.net.nz (106.62.255.123.dynamic.snap.net.nz [123.255.62.106]) by viper.snap.net.nz (Postfix) with ESMTP id 16F463D9DD4; Fri, 28 Dec 2007 21:15:37 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id C53CC8FC6D; Fri, 28 Dec 2007 21:15:25 +1300 (NZDT) Original-Newsgroups: gnu.emacs.help In-Reply-To: X-Mailer: VM 7.19 under Emacs 23.0.50.17 X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:50360 Archived-At: > I am using Emacs 22.1 on Windows XP like the OP. When I type M-x > thumbs-dired-show-marked I just get empty squares displayed four rows > wide. I marked six images and I got one row of four squares and a second row > of two squares, all blank. I have tried M-x thumbs before and got similar > results (namely, a block of sixteen empty boxes). I have also added the > ImageMagick directory to the exec-path variable via a customization window, > but unfortunately it did not help. I've checked the change below into CVS. If Emacs can't find convert it should now say so with this patch. Can you please try to apply it and then post what Emacs says to the mailing list. -- Nick http://www.inet.net.nz/~nickrob *** thumbs.el.~1.35.~ 2007-07-27 09:22:25.000000000 +1200 --- thumbs.el 2007-12-28 21:01:18.000000000 +1300 *************** ARG any arguments to the ACTION command, *** 248,262 **** OUTPUT-FORMAT is the file format to output (default is jpeg), ACTION-PREFIX is the symbol to place before the ACTION command (defaults to '-' but can sometimes be '+')." ! (let ((command (format "%s %s%s %s \"%s\" \"%s:%s\"" ! thumbs-conversion-program ! (or action-prefix "-") ! action ! (or arg "") ! filein ! (or output-format "jpeg") ! fileout))) ! (call-process shell-file-name nil nil nil shell-command-switch command))) (defun thumbs-new-image-size (s increment) "New image (a cons of width x height)." --- 248,259 ---- OUTPUT-FORMAT is the file format to output (default is jpeg), ACTION-PREFIX is the symbol to place before the ACTION command (defaults to '-' but can sometimes be '+')." ! (call-process thumbs-conversion-program nil nil nil ! (or action-prefix "-") ! action ! (or arg "") ! filein ! (format "%s:%s" (or output-format "jpeg") fileout))) (defun thumbs-new-image-size (s increment) "New image (a cons of width x height)."