unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Sebastian Wiesner <swiesner@lunaryorn.com>
To: help-gnu-emacs@gnu.org
Cc: Michael Heerdegen <michael_heerdegen@web.de>
Subject: Re: Menu on minor mode lighter
Date: Thu, 07 Aug 2014 13:11:37 +0200	[thread overview]
Message-ID: <12241137.Xj2nKZaNqX@lunaryorn> (raw)
In-Reply-To: <87zjfk8iqh.fsf@web.de>

Am Montag, 4. August 2014, 15:52:38 schrieb Michael Heerdegen:
> Sebastian Wiesner <swiesner@lunaryorn.com> writes:
> > Yes, it looks like it, but I'd rather go without an advice.  This
> > feature isn't intended for my own customization, but rather for a
> > package that I maintain (see [1]), and I am under the impression that
> > advices in packages are really bad style.
> 
> Indeed.
> 
> > Couldn't I just add my own menu to the 'local-map property of the mode
> > line lighter text?
> 
> That could work, but i'm not sure if that would be of better style.  You
> would circumvent built in code and hardcode a certain (generally
> configurable) mouse key.
> 
> > [1]: https://github.com/flycheck/flycheck/issues/365
> 
> I see.  Note that the situation for ispell is similar: It has a menu bar
> menu under Tools, but this menu isn't present in the mode-line, because
> the code doesn't capture that case.
> 
> There's probably no nice solution for your problem.

Turns out that there is.  After careful reading of the Elisp reference and 
"mouse.el", and some experiments, I figured out that it's just a matter of 
defining the menu in a special way.

The top menu bar will only show items that have no special key attached to the 
"[menu-bar]" binding, whereas the minor mode lighter simply shows the entire 
menu in the minor mode map.

Hence, creating a menu with "easy-menu-create-menu", and binding it as "[menu-
bar flycheck]" in the mode map does the job.

https://github.com/flycheck/flycheck/commit/b727e98fcbdfd27f4dc2ebe0777ec888192973d0 
has the corresponding change, for reference.

Many many thanks for your help.  Without your pointer to "mouse-minor-mode-
menu" and "minor-mode-menu-from-indicator" I'd never have been able to figure 
it out.



      reply	other threads:[~2014-08-07 11:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 16:09 Menu on minor mode lighter Sebastian Wiesner
2014-08-01 17:18 ` Michael Heerdegen
2014-08-02 13:12   ` Sebastian Wiesner
2014-08-02 13:42     ` Sebastian Wiesner
2014-08-03 17:57     ` Michael Heerdegen
2014-08-04  6:54       ` Sebastian Wiesner
2014-08-04 13:52         ` Michael Heerdegen
2014-08-07 11:11           ` Sebastian Wiesner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12241137.Xj2nKZaNqX@lunaryorn \
    --to=swiesner@lunaryorn.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).