From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.help Subject: RE: Emacs pretest: highlight line number in display-line-numbers-mode? Date: Thu, 19 Oct 2017 13:43:06 -0700 (PDT) Message-ID: <0da3bf1b-7d66-4462-8097-e9afe759e99d@default> References: <> <<87a80ntah3.fsf@gmail.com> <25a064f1-c267-49f7-a8de-b28baee928ac@default>> <<834lquew6p.fsf@gnu.org>> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1508445830 28646 195.159.176.226 (19 Oct 2017 20:43:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 19 Oct 2017 20:43:50 +0000 (UTC) To: Eli Zaretskii , help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Thu Oct 19 22:43:40 2017 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5HfD-0005fC-Gi for geh-help-gnu-emacs@m.gmane.org; Thu, 19 Oct 2017 22:43:35 +0200 Original-Received: from localhost ([::1]:51181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5HfK-0004p1-VK for geh-help-gnu-emacs@m.gmane.org; Thu, 19 Oct 2017 16:43:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5Hev-0004oX-S2 for help-gnu-emacs@gnu.org; Thu, 19 Oct 2017 16:43:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5Hev-0007wj-4W for help-gnu-emacs@gnu.org; Thu, 19 Oct 2017 16:43:17 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:16459) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5Hep-0007sp-GG; Thu, 19 Oct 2017 16:43:11 -0400 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v9JKh8jJ011605 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Oct 2017 20:43:09 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v9JKh8tm018800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Oct 2017 20:43:08 GMT Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v9JKh7Ze023258; Thu, 19 Oct 2017 20:43:08 GMT In-Reply-To: <<834lquew6p.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4600.0 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-Received-From: 156.151.31.81 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:114583 Archived-At: > This face is by default the same as line-number because of 2 reasons: >=20 > . linum-mode did the same ...chasing that rabbit: Why did `linum-mode' do that? Two wrongs don't necessarily make a right. > . using a different face makes redisplay slightly slower > (because it disallows some redisplay optimizations) Would those optimizations still be available if a user chose the same face for both (but the faces were different by default)? If so, I'd suggest making the faces different by default. And if the performance difference is important then perhaps mention it in the doc, so users who want that optimization at the cost of not highlighting the current line number can get it. IOW, opt-in for the loss of a difference. > > To find the face used, I use `list-faces-display' and look > > for either a face name that is a likely candidate > > (`line-number' is pretty obvious, in this case) or a face > > appearance that matches what I see. >=20 > There are other places where this doesn't work, e.g. on the > mode line. What do you mean by "this"? Using `list-faces-display' or the fact that you can't use `C-u C-x =3D' to learn the face? You gave that reply after my mention of the former.=20 Aren't all of the faces used in the mode line shown in `list-faces-display'? At least all faces with "mode-line" in their name are listed there. There are certainly several places where you cannot use `C-u C-x =3D' to see what the face is. (In particular, places where there is no cursor/buffer position.)