unofficial mirror of emacs-tangents@gnu.org
 help / color / mirror / Atom feed
From: Peter Mao <peter.mao@gmail.com>
To: emacs-tangents@gnu.org, orzodk@fastmail.com, rahguzar@zohomail.eu
Cc: Dmitry M <dmitrym@gmail.com>
Subject: Re: Continuous scroll for pdf-tools
Date: Tue, 4 Jul 2023 22:59:45 -0700	[thread overview]
Message-ID: <CAEK3s1Ph9c5aaRonUhoF6MbV9Yx471f1yLJ3kjqvhHtbqQr4sg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1698 bytes --]

>
> Rahguzar <rahguzar@zohomail.eu> writes:
>
> > If you have wanted this functionality, please try the my fork of
> > image-roll which is hosted at,
> >
> > https://github.com/aikrahguzar/image-roll.el
> >
> > together with the continuous scroll branch of my pdf-tools fork
> >
> > https://github.com/aikrahguzar/pdf-tools/tree/continuous-scroll
> >
> > and report back your experience and even better fixes for any problems
> > you encountered.
>
> Thanks for this! One of my pet peeves with pdf-tools (+ org-noter) on a
> smaller screen was accidentally scrolling just a bit too far and having
> it replace the page. Your packages so far have solved this problem for
> me.
>
> I'll be using these packages from now on and I'll be sure to report back
> if I run into any problems.
>

Dmitry and I are maintainers of org-noter.  I haven't tried your code yet,
but I think the feature is important for pdf-tools and if it gets
integrated into pdf-tools, I'd like to ensure that org-noter works well
with it.

Rahguzar -- are you going to be making pull-requests to the upstream
repos?  I notice that you are a fork of a fork of the "official" pdf-tools
repo (vedang/pdf-tools), and your code has diverged significantly from
vedang/pdf-tools (96 ahead/44 behind).  Since vedang/pdf-tools is under
active maintainership, I think the best course of action is to make a PR
(or a series of PRs, as it looks like you've done a **lot** of work on this
feature).

Orzodk -- Please consider opening an issue at
https://github.com/org-noter/org-noter/issues to communicate/log what you
find with these packages.

Although this looks very interesting to me, I don't have the bandwidth to
dive into it.

Peter

[-- Attachment #2: Type: text/html, Size: 2319 bytes --]

             reply	other threads:[~2023-07-05  5:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05  5:59 Peter Mao [this message]
2023-07-05 19:10 ` Continuous scroll for pdf-tools Rahguzar
2023-07-12 13:58   ` Rahguzar
2023-07-14  2:23     ` Peter Mao
  -- strict thread matches above, loose matches on Subject: below --
2023-06-28 16:45 Rahguzar
2023-06-30 16:46 ` orzodk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEK3s1Ph9c5aaRonUhoF6MbV9Yx471f1yLJ3kjqvhHtbqQr4sg@mail.gmail.com \
    --to=peter.mao@gmail.com \
    --cc=dmitrym@gmail.com \
    --cc=emacs-tangents@gnu.org \
    --cc=orzodk@fastmail.com \
    --cc=rahguzar@zohomail.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).