From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Peter Mao Newsgroups: gmane.emacs.tangents Subject: Re: Continuous scroll for pdf-tools Date: Thu, 13 Jul 2023 19:23:45 -0700 Message-ID: References: <87o7kq2lti.fsf@zohomail.eu> <87jzv52po1.fsf@zohomail.eu> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000001a26b106006924d3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36714"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-tangents@gnu.org, orzodk@fastmail.com, Dmitry M To: Rahguzar Original-X-From: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Fri Jul 14 06:49:17 2023 Return-path: Envelope-to: get-emacs-tangents@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKAk0-0009JC-I9 for get-emacs-tangents@m.gmane-mx.org; Fri, 14 Jul 2023 06:49:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKAjg-0004jZ-Pl; Fri, 14 Jul 2023 00:48:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK8TT-0005SG-2g for emacs-tangents@gnu.org; Thu, 13 Jul 2023 22:24:03 -0400 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qK8TR-0000Ae-1g for emacs-tangents@gnu.org; Thu, 13 Jul 2023 22:24:02 -0400 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4f122ff663eso2404018e87.2 for ; Thu, 13 Jul 2023 19:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689301438; x=1691893438; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FYAndViNchkjGNKBl8Cv14PIovCdTclDHdfNUWhGtpw=; b=ijY3hKL1gLvaDX7wgarjCyq+c4ZcHh4xtgnzukj4N+l1X9h73nafkjEI4nVWoFF1Uj 6/pcqUxx8xx9Xz8Zcl4oJZ/xTgoMav624K9jA7FNIAfXl9DbEuL91tBJdTfSqVa4EQag T+WY5PzB0OUBdT9e0awMZ/yw1TmCckuMslpBcTelFktLq2XxfRqfiENbN9q2F6bwBMJv AmdiwCx7gAW/YjE2YVRz0uRY/bpi0TPfK7vd7bE5EHivqbHsc7af/au7YbT4ecKNaQMf ypkrt+XMoJ/m76CAhOWPaFq9eEhe5oJ96jQMdBBShWiS26/Y/hlt4x5PdUgNcLjXb0c9 ORiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689301438; x=1691893438; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FYAndViNchkjGNKBl8Cv14PIovCdTclDHdfNUWhGtpw=; b=RgftPcQZp4OfkStoi0UV5AwQbEJhWq74Mh0LvQ0OzGtyjLm6Fi04TE2y90uKdoGCc4 l5KIYXXwCUK1pLEKpWgpSxYB3nm3HfkjvKM1rYIajbaL+gVg3Ym6xWie8KE/uKdWLgLl SybZjKb2w4a7BOe9Yj6tgNXKq/nviFqu6sB8xtFEvEUwOeSJ67NkazfaWOS/la2bSQ17 /m23CSGtrr5o1DOuoWD4KyVZfPvahGgakUOxZu/W/ZLmhuLtOqBZvL2EOWEp4f0NzFqT +lm0b235NHaST9nRCKKbd3IjiIyJ+mE3gv7zqk3qgP7Q7AGLvLkZNPZXJ8f1ocr24cPZ C+xQ== X-Gm-Message-State: ABy/qLZz8S/fGWprGGqC5xvOb/33u0f3IZFP+H546C6VnH6eO7DcO7H7 GWf5A5jLIAqTnTRVYUcmjHe7VpatjMIYYgJfRAA= X-Google-Smtp-Source: APBJJlFkvTBh6xkKssl8NZDLnJroEYGWuNIQD9mbQ2f0RGm3fhYY+zSI57htC8rCRqF+r35Zce+uiYGkLvWG4mDC4OE= X-Received: by 2002:ac2:4da3:0:b0:4f8:6e52:68ae with SMTP id h3-20020ac24da3000000b004f86e5268aemr2419580lfe.31.1689301437521; Thu, 13 Jul 2023 19:23:57 -0700 (PDT) In-Reply-To: <87jzv52po1.fsf@zohomail.eu> Received-SPF: pass client-ip=2a00:1450:4864:20::12a; envelope-from=peter.mao@gmail.com; helo=mail-lf1-x12a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 14 Jul 2023 00:48:53 -0400 X-BeenThere: emacs-tangents@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Emacs news and miscellaneous discussions outside the scope of other Emacs mailing lists List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Original-Sender: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.tangents:1035 Archived-At: --0000000000001a26b106006924d3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, Rahguzar, It's good to see that you put in the PR and the pdf-tools maintainer (vedang) has engaged you on it. I'll keep an eye on it and test the code when it gets closer to release. Peter On Wed, Jul 12, 2023 at 7:03=E2=80=AFAM Rahguzar wro= te: > An update: I created a new branch named `upstream-pdf-roll` which is base= d > on > `vedang/pdf-tools` and made a draft pull request too, > > https://github.com/vedang/pdf-tools/pull/224 > > So if you have been using this please try the `upstream-pdf-roll` branch > and > report back if something got broken, although since I was able to > cherry-pick > commits cleanly I feel it is unlikely (but I don't git so my feelings mig= ht > be very off the mark) and cursory usage by me suggests that everything is > fine. > > Rahguzar > > Rahguzar writes: > > > Hi Peter, > > > > Peter Mao writes: > > > >> Rahguzar -- are you going to be making pull-requests to the upstream > >> repos? I notice that you are a fork of a fork of the "official" > >> pdf-tools repo (vedang/pdf-tools), and your code has diverged > >> significantly from vedang/pdf-tools (96 ahead/44 behind). Since > >> vedang/pdf-tools is under active maintainership, I think the best > >> course of action is to make a PR (or a series of PRs, as it looks like > >> you've done a **lot** of work on this feature). > > > > The reason that it is a fork of a fork is that once upon a time I > > was using a feature from that fork which has a pull-request waiting to > > be merged into vedang/pdf-tools. When I switched to Daniel Nicolai's > > fork, I just rebased on top of that which looking back now is > > unfortunate. You can probably tell I am not too familiar with git and > > also not a software developer by trade. I have made changes to quite > > a few places in the pdf-tools repo but what you see at first glance > > vastly overstates them. By my estimation the changes for this feature > > come to about 700 lines and probably a majority of them were by Daniel > > Nicolai. In fact, although I fixed issues I had with pdf-tools when > > using continuous scroll, I think I made more extensive changes to > > image-roll than to pdf-tools. > > > > For that reason I will like Daniel Nicolai to chime in about PR to > > pdf-tools first and I opened an issue about changes to image-roll on hi= s > > repository. In any case the changes to pdf-tools are extensive but stil= l > > probably incomplete. Most likely there are features that break but I > > haven't come across. As a result I think a pr to pdf-tools will take a > > long time to review and merge. For a short term solution I think it > > might be worthwhile to package the changes to pdf-tools as advices, thi= s > > will duplicate quite a lot of code but will allow people to test this > > feature more easily with upstream pdf-tools. I don't have bandwidth to > > take this on but if someone wants to try this, they are welcome. > > > > Rahguzar > --0000000000001a26b106006924d3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, Rahguzar,

It's g= ood to see that you put in the PR and the pdf-tools maintainer (vedang) has= engaged you on it.=C2=A0 I'll keep an eye on it and test the code when= it gets closer to release.

Peter
<= br>
On Wed,= Jul 12, 2023 at 7:03=E2=80=AFAM Rahguzar <rahguzar@zohomail.eu> wrote:
An update: I created a new branch named `u= pstream-pdf-roll` which is based on
`vedang/pdf-tools` and made a draft pull request too,

https://github.com/vedang/pdf-tools/pull/224

So if you have been using this please try the `upstream-pdf-roll` branch an= d
report back if something got broken, although since I was able to cherry-pi= ck
commits cleanly I feel it is unlikely (but I don't git so my feelings m= ight
be very off the mark) and cursory usage by me suggests that everything is fine.

Rahguzar

Rahguzar <rahg= uzar@zohomail.eu> writes:

> Hi Peter,
>
> Peter Mao <peter.mao@gmail.com> writes:
>
>> Rahguzar -- are you going to be making pull-requests to the upstre= am
>> repos? I notice that you are a fork of a fork of the "officia= l"
>> pdf-tools repo (vedang/pdf-tools), and your code has diverged
>> significantly from vedang/pdf-tools (96 ahead/44 behind). Since >> vedang/pdf-tools is under active maintainership, I think the best<= br> >> course of action is to make a PR (or a series of PRs, as it looks = like
>> you've done a **lot** of work on this feature).
>
> The reason that it is a fork of a fork is that once upon a time I
> was using a feature from that fork which has a pull-request waiting to=
> be merged into vedang/pdf-tools. When I switched to Daniel Nicolai'= ;s
> fork, I just rebased on top of that which looking back now is
> unfortunate. You can probably tell I am not too familiar with git and<= br> > also not a software developer by trade. I have made changes to quite > a few places in the pdf-tools repo but what you see at first glance > vastly overstates them. By my estimation the changes for this feature<= br> > come to about 700 lines and probably a majority of them were by Daniel=
> Nicolai. In fact, although I fixed issues I had with pdf-tools when > using continuous scroll, I think I made more extensive changes to
> image-roll than to pdf-tools.
>
> For that reason I will like Daniel Nicolai to chime in about PR to
> pdf-tools first and I opened an issue about changes to image-roll on h= is
> repository. In any case the changes to pdf-tools are extensive but sti= ll
> probably incomplete. Most likely there are features that break but I > haven't come across. As a result I think a pr to pdf-tools will ta= ke a
> long time to review and merge. For a short term solution I think it > might be worthwhile to package the changes to pdf-tools as advices, th= is
> will duplicate quite a lot of code but will allow people to test this<= br> > feature more easily with upstream pdf-tools. I don't have bandwidt= h to
> take this on but if someone wants to try this, they are welcome.
>
> Rahguzar
--0000000000001a26b106006924d3--