From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rahguzar Newsgroups: gmane.emacs.tangents Subject: Re: Continuous scroll for pdf-tools Date: Wed, 12 Jul 2023 15:58:42 +0200 Message-ID: <87jzv52po1.fsf@zohomail.eu> References: <87o7kq2lti.fsf@zohomail.eu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7595"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.4; emacs 29.0.92 Cc: Peter Mao , emacs-tangents@gnu.org, orzodk@fastmail.com, Dmitry M To: Rahguzar Original-X-From: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Wed Jul 12 23:17:09 2023 Return-path: Envelope-to: get-emacs-tangents@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJhCv-0001mP-Mr for get-emacs-tangents@m.gmane-mx.org; Wed, 12 Jul 2023 23:17:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJhCf-00022I-E1; Wed, 12 Jul 2023 17:16:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJaQx-0008QB-VM for emacs-tangents@gnu.org; Wed, 12 Jul 2023 10:03:11 -0400 Original-Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJaQs-0006nY-CA for emacs-tangents@gnu.org; Wed, 12 Jul 2023 10:03:08 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1689170579; cv=none; d=zohomail.eu; s=zohoarc; b=Grnnjs+XzjehdJK5/hI4y9wCm0PzZmyiN0sbHGx1RIY3GmVhWepnd2RQY+znxzLAzsmBraQ+7fKrrO0HVaDE30hd107kBl1LTDur9ewawRwt2Ru8Gcl09M1lj5XauGQ4WLtbt4AlQLqMavscL4PyAxteG9KIqL1EOXv77Qv6/ug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1689170579; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=OwCCoxY2ob57FbK3A4AR7Xfjpm2I82wziQl98BZ/au0=; b=fDsk7Ng2BYLjM8Z9hUNqWU0UPQDK7GeFzZf1weSkyGBoaK9tuEaDa7xOcuqpM83bQlnAuCIMF4TyH2pojBjz/K2lFg5i08D/71oNWlO672gZcpk7qDD/xreeWgs0OKT0ZwpWOZ3DcIaKCqiJ/C72t/ohTS8yPuJ7RIXyJEo+UNc= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1689170579; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=OwCCoxY2ob57FbK3A4AR7Xfjpm2I82wziQl98BZ/au0=; b=Iz7TJClLSV+IG4KNbMgB+31oVnfu+9U7iLXvD8anx6hguw0PTtmH4oyv8B9emJ23 s/BclZpNJ+W9PMVLlyZErTL4mLsnxP9G4e6zRO+bSA26GxzcUXnMDv7SmZ3zZWsszIY +8WFfgd/s21N5Zm2z0+d4qsLGH1uuE8DRsD/t0Z0= Original-Received: from localhost (emp-234-237.eduroam.uu.se [130.238.234.237]) by mx.zoho.eu with SMTPS id 168917057641579.1789336779375; Wed, 12 Jul 2023 16:02:56 +0200 (CEST) In-reply-to: <87o7kq2lti.fsf@zohomail.eu> X-ZohoMailClient: External Received-SPF: pass client-ip=31.186.226.249; envelope-from=rahguzar@zohomail.eu; helo=sender11-pp-o91.zoho.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 12 Jul 2023 17:16:50 -0400 X-BeenThere: emacs-tangents@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Emacs news and miscellaneous discussions outside the scope of other Emacs mailing lists List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Original-Sender: emacs-tangents-bounces+get-emacs-tangents=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.tangents:1034 Archived-At: An update: I created a new branch named `upstream-pdf-roll` which is based on `vedang/pdf-tools` and made a draft pull request too, https://github.com/vedang/pdf-tools/pull/224 So if you have been using this please try the `upstream-pdf-roll` branch and report back if something got broken, although since I was able to cherry-pick commits cleanly I feel it is unlikely (but I don't git so my feelings might be very off the mark) and cursory usage by me suggests that everything is fine. Rahguzar Rahguzar writes: > Hi Peter, > > Peter Mao writes: > >> Rahguzar -- are you going to be making pull-requests to the upstream >> repos? I notice that you are a fork of a fork of the "official" >> pdf-tools repo (vedang/pdf-tools), and your code has diverged >> significantly from vedang/pdf-tools (96 ahead/44 behind). Since >> vedang/pdf-tools is under active maintainership, I think the best >> course of action is to make a PR (or a series of PRs, as it looks like >> you've done a **lot** of work on this feature). > > The reason that it is a fork of a fork is that once upon a time I > was using a feature from that fork which has a pull-request waiting to > be merged into vedang/pdf-tools. When I switched to Daniel Nicolai's > fork, I just rebased on top of that which looking back now is > unfortunate. You can probably tell I am not too familiar with git and > also not a software developer by trade. I have made changes to quite > a few places in the pdf-tools repo but what you see at first glance > vastly overstates them. By my estimation the changes for this feature > come to about 700 lines and probably a majority of them were by Daniel > Nicolai. In fact, although I fixed issues I had with pdf-tools when > using continuous scroll, I think I made more extensive changes to > image-roll than to pdf-tools. > > For that reason I will like Daniel Nicolai to chime in about PR to > pdf-tools first and I opened an issue about changes to image-roll on his > repository. In any case the changes to pdf-tools are extensive but still > probably incomplete. Most likely there are features that break but I > haven't come across. As a result I think a pr to pdf-tools will take a > long time to review and merge. For a short term solution I think it > might be worthwhile to package the changes to pdf-tools as advices, this > will duplicate quite a lot of code but will allow people to test this > feature more easily with upstream pdf-tools. I don't have bandwidth to > take this on but if someone wants to try this, they are welcome. > > Rahguzar