From: Dan Nicolaescu <dann@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: EMACS_GET_TTY_PGRP vs. emacs_get_tty_pgrp
Date: Wed, 20 Oct 2010 14:59:12 -0400 [thread overview]
Message-ID: <yxqy69soflr.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <4CBEFB15.5050303@cornell.edu> (Ken Brown's message of "Wed\, 20 Oct 2010 10\:22\:13 -0400")
Ken Brown <kbrown@cornell.edu> writes:
> The macro EMACS_GET_TTY_PGRP defined in src/systty.h uses either
> tcgetpgrp or TIOCGPGRP to get the PGID of a terminal's foreground
It does not:
#ifndef DOS_NT
#define EMACS_GET_TTY_PGRP(fd, pgid) (*(pgid) = tcgetpgrp ((fd)))
#define EMACS_SET_TTY_PGRP(fd, pgid) (tcsetpgrp ((fd), *(pgid)))
#endif /* not DOS_NT */
also, I have a patch to remove this, it's only used in two places, so
it's not very useful as an abstraction.
> process group. But src/process.c defines and uses its own
> emacs_get_tty_pgrp that only works on systems that have TIOCGPGRP. Is
> there a good reason for this? If not, I would like to try to prepare
> a patch to change process.c to use the macro instead. This would
> simplify the code and would also extend some of the functionality in
> process.c to systems that have tcgetpgrp but not TIOCGPGRP.
>
> Ken
next prev parent reply other threads:[~2010-10-20 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 14:22 EMACS_GET_TTY_PGRP vs. emacs_get_tty_pgrp Ken Brown
2010-10-20 15:14 ` Andreas Schwab
2010-10-20 18:39 ` Ken Brown
2010-10-20 18:59 ` Dan Nicolaescu [this message]
2010-10-20 20:01 ` Ken Brown
2010-10-20 20:21 ` Eli Zaretskii
2010-10-20 20:28 ` Dan Nicolaescu
2010-10-20 21:28 ` Ken Brown
2010-10-20 21:36 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxqy69soflr.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).