From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Eliminating a couple of independent face definitions Date: Thu, 03 Feb 2011 11:14:03 -0500 Message-ID: References: <87oc6vm67v.fsf@stupidchicken.com> <87vd12z77n.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1296749706 11808 80.91.229.12 (3 Feb 2011 16:15:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 3 Feb 2011 16:15:06 +0000 (UTC) Cc: Tim Cross , Lennart Borgman , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 03 17:15:01 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pl1pl-00074s-Be for ged-emacs-devel@m.gmane.org; Thu, 03 Feb 2011 17:15:01 +0100 Original-Received: from localhost ([127.0.0.1]:33017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pl1pk-0000oi-QI for ged-emacs-devel@m.gmane.org; Thu, 03 Feb 2011 11:15:00 -0500 Original-Received: from [140.186.70.92] (port=58439 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pl1or-0000Qm-3I for emacs-devel@gnu.org; Thu, 03 Feb 2011 11:14:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pl1oq-0002D0-0x for emacs-devel@gnu.org; Thu, 03 Feb 2011 11:14:04 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:36841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pl1op-0002Cp-VG for emacs-devel@gnu.org; Thu, 03 Feb 2011 11:14:03 -0500 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Pl1op-0007ry-Jb; Thu, 03 Feb 2011 11:14:03 -0500 In-Reply-To: <87vd12z77n.fsf@stupidchicken.com> (Chong Yidong's message of "Wed, 02 Feb 2011 12:17:48 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135505 Archived-At: Chong Yidong writes: > Tim Cross writes: > >> My only concern is how you define what to inherit from. For example, >> in your suggestion of compiler warnings inheriting form >> =C2=A0font-lock-comment-face I immediately wondered why you would not >> inherit from font-lock-warning face? > > font-lock-warning-face is already used for compilation errors, which are > more serious than warnings. That is an annoyance. It seems that adding a font-lock-error-face and make all the current users of font-lock-warning-face use that one is the right thing to do. How about changing M-x list-faces-display to mark the faces that just inherit from other faces with a special tag? That way when people look to customize their theme it's easy to spot the base faces.