From: Dan Nicolaescu <dann@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: split up process.c [was: Re: Changes in process.c]
Date: Thu, 08 Jul 2010 14:52:39 -0400 [thread overview]
Message-ID: <yxqwrt5q008.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83d3ux7ris.fsf@gnu.org> (Eli Zaretskii's message of "Thu\, 08 Jul 2010 21\:33\:15 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> People who make changes in process.c related to keyboard input and
> wait_reading_process_output, please remember that there are two
> branches in process.c, one for systems that support async
> subprocesses, the other for those which don't (only MS-DOS in the
> latter class). Making changes only in one of them is going to break
> something.
This points to the ugliness of the situation.
Why don't we split the part for supporting MS-DOS into a different
file: process-no-subprocesses.c (or some better name)
That makes the file easier to read, less clunky, and problems easier
to catch with a simple grep.
next prev parent reply other threads:[~2010-07-08 18:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 18:33 Changes in process.c Eli Zaretskii
2010-07-08 18:52 ` Dan Nicolaescu [this message]
2010-07-08 20:35 ` split up process.c [was: Re: Changes in process.c] Eli Zaretskii
2010-07-08 23:05 ` Dan Nicolaescu
2010-07-09 23:01 ` split up process.c Glenn Morris
2010-07-10 1:35 ` Dan Nicolaescu
2010-07-10 13:43 ` split up process.c [was: Re: Changes in process.c] Eli Zaretskii
2010-07-11 3:40 ` split up process.c Dan Nicolaescu
2010-07-11 6:10 ` Eli Zaretskii
2010-07-11 14:48 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxqwrt5q008.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).