From: Dan Nicolaescu <dann@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: vc-update for bzr etc.
Date: Tue, 23 Nov 2010 17:34:31 -0500 [thread overview]
Message-ID: <yxqvd3nzn2g.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87d3pvalem.fsf@stupidchicken.com> (Chong Yidong's message of "Tue\, 23 Nov 2010 14\:29\:37 -0500")
Chong Yidong <cyd@stupidchicken.com> writes:
> Dan Nicolaescu <dann@gnu.org> writes:
>
>> I have an implementation of `pull' that also takes a `revision' argument.
>> And in the *vc-incoming* buffer there's a binding for vc-pull to pull
>> up to the revision at point (use pull --revision=ARG).
>
> Good.
BTW, I have no plans to merge that.
>
>>> Also, do I need to do anything special to update VC-dir buffers after
>>> merging or pulling?
>>
>> Not only VC-dir buffers, but all buffers containing files in the
>> target directory. See for example the vc-resynch-buffer in the
>> vc-retrieve-tag (which could use a better name).
>
> OK, I've got some code working that makes vc-bzr-merge/update call or
> refresh VC-dir after finishing, e.g. it shows "updated" files after a
> bzr update. But the interface feels flimsy, somehow.
It seems that you are putting too much code in the vc-bzr, not in vc
itself. Better pass the buffer to the command, instead of creating it
locally in each VC backend.
>
> The VC-dir buffer displays no indication while the merge/pull is
> running. Afterwards, there is no sign that the operation has completed,
> other than an echo area message (easily overwritten by other Emacs
> commands) and some changes in file status (easily overlooked).
>
> For example, if you do an update operation that completes without doing
> anything, it's easy to miss when the update finishes. In contrast, when
> the VCS messages are put into a compilation-like buffer, it's always
> clear what has taken place.
>
> So it seems like there needs to be some kind of status message display
> in the VC-dir buffer, showing (at least) the most recent VCS operation
> and its status. WDYT?
In the buffer? The way pcl-cvs does it is a bad idea, I am completely against it.
Putting something in the modeline, like the rest of the vc
asynchronous commands do would be better.
next prev parent reply other threads:[~2010-11-23 22:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 15:43 vc-update for bzr etc Chong Yidong
2010-11-21 17:00 ` Andreas Schwab
2010-11-21 17:09 ` Dan Nicolaescu
2010-11-21 17:33 ` Chong Yidong
2010-11-21 20:20 ` Stefan Monnier
2010-11-21 21:08 ` Chong Yidong
2010-11-22 2:04 ` Stefan Monnier
2010-11-22 4:31 ` Stephen J. Turnbull
2010-11-22 8:40 ` Thien-Thi Nguyen
2010-11-22 11:04 ` Stephen J. Turnbull
2010-11-22 14:39 ` Stefan Monnier
2010-11-22 17:29 ` Chong Yidong
2010-11-23 15:37 ` Stephen J. Turnbull
2010-11-23 16:20 ` Stefan Monnier
2010-11-22 4:35 ` Chong Yidong
2010-11-22 6:52 ` Dan Nicolaescu
2010-11-22 14:42 ` Stefan Monnier
2010-11-22 10:54 ` Eli Zaretskii
2010-11-22 14:41 ` Stefan Monnier
2010-11-23 1:40 ` Chong Yidong
2010-11-23 14:27 ` Stefan Monnier
2010-11-23 16:08 ` Chong Yidong
2010-11-23 17:03 ` Dan Nicolaescu
2010-11-23 17:02 ` Dan Nicolaescu
2010-11-23 19:29 ` Chong Yidong
2010-11-23 22:05 ` Stefan Monnier
2010-11-23 22:34 ` Dan Nicolaescu [this message]
2010-11-24 17:19 ` Chong Yidong
2010-11-22 16:57 ` Chong Yidong
2010-11-22 17:59 ` Eli Zaretskii
2010-11-21 19:03 ` Stefan Monnier
2010-11-21 19:34 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxqvd3nzn2g.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).