From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc. Date: Mon, 25 Oct 2010 10:51:57 -0400 Message-ID: References: <19651.37838.815906.240014@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1288018815 32210 80.91.229.12 (25 Oct 2010 15:00:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Oct 2010 15:00:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 25 17:00:13 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PAOWw-0005UI-Ih for ged-emacs-devel@m.gmane.org; Mon, 25 Oct 2010 17:00:10 +0200 Original-Received: from localhost ([127.0.0.1]:40979 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAOP9-0007il-EW for ged-emacs-devel@m.gmane.org; Mon, 25 Oct 2010 10:52:07 -0400 Original-Received: from [140.186.70.92] (port=43716 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAOP1-0007iW-Kl for emacs-devel@gnu.org; Mon, 25 Oct 2010 10:52:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAOP0-0003VJ-D0 for emacs-devel@gnu.org; Mon, 25 Oct 2010 10:51:59 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:45745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAOP0-0003V3-Bg for emacs-devel@gnu.org; Mon, 25 Oct 2010 10:51:58 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PAOOz-0006Sy-Qv; Mon, 25 Oct 2010 10:51:57 -0400 In-Reply-To: (Adrian Robert's message of "Mon\, 25 Oct 2010 13\:25\:53 +0000 \(UTC\)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132090 Archived-At: Adrian Robert writes: > Glenn Morris gnu.org> writes: > >> >> Dan Nicolaescu wrote: >> >> > Last I looked ns-win doesn't have any good reason not to use common-win. >> > >> > It duplicates functions (under new names), the only change is using >> > ns-invocation-args instead of x-invocation-args. >> >> I saw that too. It is all very messy. > > ns-win was merged before common-win existed, but when the latter was created, > only x-win and w32-win were modified to use it. I think, Dan, this was because > ns-win was still being cleaned up (partly by me) to better match the other > terms, is that correct? So it was just bad timing. Quite likely. Or more like the ns cleanup was never completely finished. > I haven't looked at the ns-win code in a while so I'm a little hesitant to > attempt the cleanup now, but if someone wants to try I'm happy to answer > questions about "why the heck is this thing in there?" etc. and test the > resulting changes. You are probably more qualified to do this that anyone else, and have the advantage of being able to test the changes. A related cleanup is to merge `command-line-ns-option-alist' in `command-line-x-option-alist'.