From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: running ./temacs Date: Sat, 20 Nov 2010 02:28:15 -0500 Message-ID: References: <83wro9bvjj.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1290238111 1722 80.91.229.12 (20 Nov 2010 07:28:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 20 Nov 2010 07:28:31 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 20 08:28:27 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PJhs2-0000qY-CM for ged-emacs-devel@m.gmane.org; Sat, 20 Nov 2010 08:28:26 +0100 Original-Received: from localhost ([127.0.0.1]:60071 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJhs1-0000xI-NL for ged-emacs-devel@m.gmane.org; Sat, 20 Nov 2010 02:28:25 -0500 Original-Received: from [140.186.70.92] (port=52459 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJhrw-0000xC-0Q for emacs-devel@gnu.org; Sat, 20 Nov 2010 02:28:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJhru-00005a-UU for emacs-devel@gnu.org; Sat, 20 Nov 2010 02:28:19 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:33524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJhru-00005V-PP for emacs-devel@gnu.org; Sat, 20 Nov 2010 02:28:18 -0500 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PJhrs-0003Uy-3k; Sat, 20 Nov 2010 02:28:16 -0500 In-Reply-To: <83wro9bvjj.fsf@gnu.org> (Eli Zaretskii's message of "Fri\, 19 Nov 2010 09\:51\:44 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132887 Archived-At: Eli Zaretskii writes: >> From: Dan Nicolaescu >> Date: Thu, 18 Nov 2010 17:19:13 -0500 >> Cc: emacs-devel@gnu.org >> >> Stefan Monnier writes: >> >> >>>>> [Hacking around this so that Vprocess_environment is initialized when >> >>>>> not dumping makes ./temacs work correctly] >> >>>> In case anyone wants to see the difference in behavior, here's the >> >>>> ugly hack: >> >>> Could you explain your code (i.e. why you need those strcmp hacks, why >> >>> you need to set&unset initialized, ...)? >> >> set_initial_environment only initializes Vprocess_environment if >> >> `initialized' is set. >> > >> > Do you happen to know why? >> >> No idea. I'd speculate that it's undesirable to initialize it when dumping... > > Yes, probably. > > I'd think it's cleaner to add an argument to set_initial_environment, > which then could tell it whether to initialize Vprocess_environment, > instead of intuiting that inside the function by looking at > `initialized' and CANNOT_DUMP. We could then set that argument > non-zero when temacs is run with arguments other than "dump" or > "bootstrap". Agreed. Also, if we get ./temacs to work correctly then a lot of #ifdef CANNOT_DUMP code can be reconsidered. After all running just ./temacs is very close to running with CANNOT_DUMP defined. Things like: if (1 #ifndef CANNOT_DUMP && initialized #endif ) might not be needed at all...