From: Dan Nicolaescu <dann@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: running ./temacs
Date: Sat, 20 Nov 2010 02:28:15 -0500 [thread overview]
Message-ID: <yxqipzsbgj4.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83wro9bvjj.fsf@gnu.org> (Eli Zaretskii's message of "Fri\, 19 Nov 2010 09\:51\:44 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Dan Nicolaescu <dann@gnu.org>
>> Date: Thu, 18 Nov 2010 17:19:13 -0500
>> Cc: emacs-devel@gnu.org
>>
>> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>>
>> >>>>> [Hacking around this so that Vprocess_environment is initialized when
>> >>>>> not dumping makes ./temacs work correctly]
>> >>>> In case anyone wants to see the difference in behavior, here's the
>> >>>> ugly hack:
>> >>> Could you explain your code (i.e. why you need those strcmp hacks, why
>> >>> you need to set&unset initialized, ...)?
>> >> set_initial_environment only initializes Vprocess_environment if
>> >> `initialized' is set.
>> >
>> > Do you happen to know why?
>>
>> No idea. I'd speculate that it's undesirable to initialize it when dumping...
>
> Yes, probably.
>
> I'd think it's cleaner to add an argument to set_initial_environment,
> which then could tell it whether to initialize Vprocess_environment,
> instead of intuiting that inside the function by looking at
> `initialized' and CANNOT_DUMP. We could then set that argument
> non-zero when temacs is run with arguments other than "dump" or
> "bootstrap".
Agreed.
Also, if we get ./temacs to work correctly then a lot of #ifdef
CANNOT_DUMP code can be reconsidered. After all running just ./temacs
is very close to running with CANNOT_DUMP defined.
Things like:
if (1
#ifndef CANNOT_DUMP
&& initialized
#endif
)
might not be needed at all...
next prev parent reply other threads:[~2010-11-20 7:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 6:57 running ./temacs Dan Nicolaescu
2010-11-17 7:43 ` Óscar Fuentes
2010-11-18 4:44 ` Dan Nicolaescu
2010-11-18 14:26 ` Stefan Monnier
2010-11-18 21:20 ` Dan Nicolaescu
2010-11-18 22:17 ` Stefan Monnier
2010-11-18 22:19 ` Dan Nicolaescu
2010-11-19 7:51 ` Eli Zaretskii
2010-11-20 7:28 ` Dan Nicolaescu [this message]
2010-11-21 5:48 ` Stefan Monnier
2011-05-31 5:19 ` Dan Nicolaescu
2011-05-31 6:36 ` Dan Nicolaescu
2011-05-31 6:47 ` Eli Zaretskii
2011-05-31 6:55 ` Dan Nicolaescu
2011-05-31 8:44 ` Eli Zaretskii
2011-05-31 14:53 ` Dan Nicolaescu
2011-05-31 6:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxqipzsbgj4.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).