unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@gnu.org>
To: Sascha Wilde <wilde@sha-bang.de>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] vc-hg keep working when hg emits warnings
Date: Wed, 04 Aug 2010 13:02:28 -0400	[thread overview]
Message-ID: <yxqd3tycnvf.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <m2fwyymgt0.fsf@kenny.lan.sha-bang.de> (Sascha Wilde's message of "Sun\, 01 Aug 2010 18\:35\:55 +0200")

Sascha Wilde <wilde@sha-bang.de> writes:

> Hi *,
>
> related to my latest post (regarding hgrc handling):

BTW, better send patches to bug-gnu-emacs, they won't get lost that way.

> When one works on an hg repository with an .hg/hgrc owned by someone
> else, hg emits a warning like:
>
> Not trusting file /home/foo/argh/.hg/hgrc from untrusted user foo, group foo
>
> on stderr.[1]
>
> Despite the warning hg still works as expected (ignoring the
> repositories hgrc).  So ignoring the warning is TRTTD for Emacs.
> Currently the warning text confuses vc, so that certain commands and the
> revision display in the status bare don't work correctly.
>
> The following patch achieves this by simply ignoring all output on
> stderr for vc-hg-state and vc-hg-working-revision.
>
> This might seem a little brute force, but its the most simple solution
> and I believe it should be free of unwanted side effects:

IMHO this is not good, there might be other reasons for hg to give
warnings, and the user would have no way to find out about it.

Is there a command line flag to turn off this warning?

A more robust option would be to change the parser to deal with the warning...



  reply	other threads:[~2010-08-04 17:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-01 16:35 [PATCH] vc-hg keep working when hg emits warnings Sascha Wilde
2010-08-04 17:02 ` Dan Nicolaescu [this message]
2010-08-04 17:16   ` Sascha Wilde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yxqd3tycnvf.fsf@fencepost.gnu.org \
    --to=dann@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=wilde@sha-bang.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).