From: Dan Nicolaescu <dann@gnu.org>
To: Juri Linkov <juri@jurta.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: support for git commit --amend/--signoff
Date: Fri, 11 Jun 2010 16:16:18 -0400 [thread overview]
Message-ID: <yxq1vcd72b1.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87iq5ptu73.fsf@mail.jurta.org> (Juri Linkov's message of "Fri\, 11 Jun 2010 22\:27\:57 +0300")
Juri Linkov <juri@jurta.org> writes:
>> If we only consider Git's and DaRCS's forms of amend, I'd say that the
>> "Amend:" header might be a good approach, and that it should specify the
>> revision/patch that's amended. So for Git, you could have a command
>> that inserts "Amend: <SHA-1>" and then the backend could check that the
>> SHA-1 is the right one (which would avoid accidental use).
>
> A more general variant would be a header that allows to specify
> command line arguments like
>
> Arguments: --amend --signoff
>
> This will provide interchangeability: the user will be able to copy
> arguments from the *VC-log* buffer to the external command line and
> back to the *VC-log* buffer to construct the necessary command line.
That's very ugly from the UI point of view, it's not better than doing
the same thing from the command line directly.
More, for --amend it's desirable to copy the contents of the original
log in the *VC-log* buffer, so that the user can edit it, and check in
the modified version.
next prev parent reply other threads:[~2010-06-11 20:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 6:19 support for git commit --amend/--signoff Dan Nicolaescu
2010-06-11 8:09 ` Juri Linkov
2010-06-11 13:23 ` Dan Nicolaescu
2010-06-11 14:18 ` Stefan Monnier
2010-06-11 16:14 ` Štěpán Němec
2010-06-11 20:26 ` Stefan Monnier
2010-06-12 2:19 ` Dan Nicolaescu
2010-06-12 19:59 ` Juri Linkov
2010-06-12 20:19 ` Stefan Monnier
2010-06-19 6:38 ` Dan Nicolaescu
2010-06-23 7:17 ` Stefan Monnier
2010-06-23 7:45 ` David Kastrup
2010-06-23 9:00 ` Miles Bader
2010-06-23 18:55 ` Dan Nicolaescu
2010-06-23 18:45 ` Dan Nicolaescu
2010-06-23 22:04 ` Stefan Monnier
2010-06-23 23:23 ` Dan Nicolaescu
2010-06-24 21:03 ` Stefan Monnier
2010-06-24 21:18 ` Dan Nicolaescu
2010-06-24 22:25 ` Stefan Monnier
2010-06-24 23:14 ` Dan Nicolaescu
2010-06-25 1:16 ` Stefan Monnier
2010-06-25 2:27 ` Dan Nicolaescu
2010-06-25 11:44 ` Miles Bader
2010-06-26 5:09 ` Dan Nicolaescu
2010-07-01 0:01 ` Stefan Monnier
2010-06-26 10:11 ` David Kastrup
2010-06-28 21:04 ` Juri Linkov
2010-06-11 17:34 ` Dan Nicolaescu
2010-06-11 19:27 ` Juri Linkov
2010-06-11 20:16 ` Dan Nicolaescu [this message]
2010-06-11 20:38 ` Juri Linkov
2010-06-11 23:48 ` W Dan Meyer
2010-06-12 20:23 ` Juri Linkov
2010-06-12 2:21 ` Dan Nicolaescu
2010-06-11 23:44 ` Thien-Thi Nguyen
2010-06-12 20:15 ` Stefan Monnier
2010-06-11 20:35 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxq1vcd72b1.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).