From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Marco Munari 16479.36044 Newsgroups: gmane.emacs.devel Subject: Re: More enhancements to fringe bitmaps. Date: Tue, 23 Mar 2004 03:27:39 +0100 Organization: MARco GNU/FSF contributes Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1080009036 9381 80.91.224.253 (23 Mar 2004 02:30:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 23 Mar 2004 02:30:36 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Mar 23 03:30:22 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B5bgM-0005I7-00 for ; Tue, 23 Mar 2004 03:30:22 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B5bgM-0001u8-00 for ; Tue, 23 Mar 2004 03:30:22 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B5be8-0001hR-J5 for emacs-devel@quimby.gnus.org; Mon, 22 Mar 2004 21:28:04 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B5be4-0001h8-00 for emacs-devel@gnu.org; Mon, 22 Mar 2004 21:28:00 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B5bdX-0001fG-0F for emacs-devel@gnu.org; Mon, 22 Mar 2004 21:27:59 -0500 Original-Received: from [193.70.193.55] (helo=mail1a.webmessenger.it) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B5bdW-0001f9-GR for emacs-devel@gnu.org; Mon, 22 Mar 2004 21:27:26 -0500 Original-Received: from fast (151.38.74.253) by mail1a.webmessenger.it (7.0.020) (authenticated as mar@allerta.it) id 40581DCA000ACC54; Tue, 23 Mar 2004 03:27:21 +0100 Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "22 Mar 2004 11:59:04 +0100") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20757 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20757 ~\/~ "Kim" == Kim F Storm writes: Kim> Marco Munari writes: ... Kim> What about a name which says that this has to do with size of the Kim> standard bitmaps, e.g. Kim> fringe-standard-bitmap-size Ok, as you prefer (i was in dubt, in the beginning in fact i call it locally similarly with "-size" insted of "-group", i changed to group because i thought that it was not precisely a size, than when i change all image in order of size, "-size" is again apropriate) > > +(defvar fringe-bitmap-group nil) > > +(setq fringe-bitmap-group nil) ;orrible, but a way to avoid undefined in conditions Kim> I don't see how that is necessary. me too, but i in the original fringe.el we can see: (defvar fringe-mode) ... (defcustom fringe-mode nil ... i don't see necessity of the first existing definition i just removed my absurd setq statement, it was an experiment because i misunderstend an error on fringe-standard-bitmap-size comparison Don't consider my patch virtual commit intention for all file, fringe.el section was uncleaned, with evidence ) > > + ((and (eq nil value) > > + ;;(not (eq fringe-bitmap-group value)) ;how to compare to previous Kim> use = or equal > > + (setq fringe-bitmap-group value)) ;how to use symbol? Kim> (set symbol value) -- but don't do that ... see my comment below > > + > > +;;;###autoload > > +(defcustom fringe-bitmap-group nil > > +"*Specify the bitmap set (related to size) of fringe bitmaps > > +nil is the default bitpapset (quit big) > > +0 (tiny) for smallest bitmap as possible" > > + :type '(choice (const :tag "Default size" nil) > > + (const :tag "tiny" 0) > + (const :tag "small" 1) > > +(const :tag "medium" 2)) > + :group 'frames :require 'fringe > > + :set 'set-fringe-bitmap-group) > > + > > +;;The following part close to the end is not well done and > > +;;not necessary so commented as it can be removed Kim> I think that set-fringe-standard-bitmap-size should be Kim> interactive. M-x customize-variable fringe-standard-bitmap-size is an alternative interactive way i didn't introduce too much new interactive user ways to set it's value because existing set-fringe-style could even automatically set new fringe-standard-bitmaps-size to a proper value, depending on the fringe width (the default bitmap size for example is too much big for size less then half). Kim> You can then use a lambda form in the :set of the above defcustom Kim> to call it with the required parameters, something like. Kim> :set (lambda (symbol value) Kim> (set-fringe-standard-bitmap-size value)) > > +;;;;###autoload > > +;(defun set-fringe-style (&optional mode) > > +; "...Set the default appearance of fringes on the selected > > +;frame. Kim> Why is this function removed ? justification endpoint: Not removed, but precisely copyed from above and commented out for future renaming and changing or remove.. use), i know it's a bad way to write code but i used it as a template (in my -work in progress- point of view, there was similarity on handling fringe-mode and the new variable). In that time... before to go to sleep and send the mail, i commented all the rest to keep some changes. I will send a better cleanup remake of fringe.el in next days Saluti, MARco -- x(t),y(t) = th(3t-34.5)*e^[-(3t-34.5)^2]/2-4.3+e^(-1.8/t^2)/(.8*atg(t- 3)+2)(t-1.8)-.3th(5t-42.5),(1.4e^[-(3t-34.5)^2]+1-sgn[|t-8.5|-.5]*1.5* |sin(pi*t)|^[2e^(-(t-11.5)^2)+.5+e^(-(.6t-3.3)^2)])/(.5+t)+1 ; 0