From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential'. Date: Wed, 21 Aug 2013 11:46:38 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1377078414 13170 80.91.229.3 (21 Aug 2013 09:46:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Aug 2013 09:46:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 21 11:46:57 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VC50C-0008DP-W7 for ged-emacs-devel@m.gmane.org; Wed, 21 Aug 2013 11:46:57 +0200 Original-Received: from localhost ([::1]:52483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC50C-0007CR-IC for ged-emacs-devel@m.gmane.org; Wed, 21 Aug 2013 05:46:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC505-0007BY-9Y for emacs-devel@gnu.org; Wed, 21 Aug 2013 05:46:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VC500-00087C-4C for emacs-devel@gnu.org; Wed, 21 Aug 2013 05:46:49 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:57796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC4zz-00086t-R7 for emacs-devel@gnu.org; Wed, 21 Aug 2013 05:46:44 -0400 Original-Received: from uw001237 ([79.193.176.49]) by mail.gmx.com (mrgmx003) with ESMTPA (Nemesis) id 0M3AWN-1W2X1c0F6N-00srH1 for ; Wed, 21 Aug 2013 11:46:39 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 20 Aug 2013 16:35:44 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:u5o8Pg6sbqhwO+kRzM5NaPHc21DF5EoKJfyLAVrygKgizDNlurL 74hAUgvkrNLVlRm75+WV5AkwtzA+kSBobC6JeejBKq0tA2Ggid2z2ytKrJsPMqYaAg6MLwh 2Nb3pXN45KgJlJe0vPx0Lu9cb0I8i2H9Zl0K1j9S1t6MfLRVSclsSUPFJOprkWXyofz8afu go4taTM85+2zQ09C+qSiQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162953 Archived-At: Stefan Monnier writes: Hi Stefan, >> Honestly, I don't know too much about the completion code in >> minibuffer.el. The OP has reported the following backtrace (shortened by >> me): > > My point is simply that the backtrace you show does not seem to perform > non-essential work, so binding non-essential is not right. It is > computing the completion of /ssh:vagrant@192.168.10.2:/ (not quite sure > why, since the backtrace doesn't go further up). The whole backtrace is in (the second backtrace in this message). >> Sadly, I cannot reproduce this scenario locally. And I have no idea, why >> completion--sifn-requote(27 "/ssh:vagrant@192.168.10.2:/") >> calls >> substitute-in-file-name("/ssh:vagrant@192.168.10.") > > Can't say offhand either why not. Maybe we should simply demote errors > from substitute-in-file-name inside completion--sifn-requote. > > At the same time I wonder why (substitute-in-file-name > "/ssh:vagrant@192.168.10.") should signal an error: it looks like an > incomplete filename, so we don't know yet whether it'll really be an > error or not. For Tramp, it is a complete filename wrt syntax. "ssh" is recognised as host name, which is regarded as an error since we had decided this some weeks ago. See . Setting `non-essential' to t is a mean to tell Tramp not to check this. > Stefan Best regards, Michael.